Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2024-12-27 05:23:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix: avoid panic when parsing extern block

Browse source 
closes #10083
This commit is contained in:
Aleksey Kladov 2021-08-30 15:40:47 +03:00
parent a833fba98a
commit 8dc3b46017
5 changed files with 43 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
crates/parser/src/grammar/items.rs
View file

@ -93,6 +93,7 @@ pub(super) fn maybe_item(p: &mut Parser, m: Marker) -> Result<(), Marker> {
}; };
let mut has_mods = false; let mut has_mods = false;
let mut has_extern = false;
// modifiers // modifiers
if p.at(T![const]) && p.nth(1) != T!['{'] { if p.at(T![const]) && p.nth(1) != T!['{'] {
@ -102,7 +103,7 @@ pub(super) fn maybe_item(p: &mut Parser, m: Marker) -> Result<(), Marker> {
// test_err async_without_semicolon // test_err async_without_semicolon
// fn foo() { let _ = async {} } // fn foo() { let _ = async {} }
if p.at(T![async]) && p.nth(1) != T!['{'] && p.nth(1) != T![move] && p.nth(1) != T![|] { if p.at(T![async]) && !matches!(p.nth(1), T!['{'] | T![move] | T![|]) {
p.eat(T![async]); p.eat(T![async]);
has_mods = true; has_mods = true;
} }
@ -114,7 +115,8 @@ pub(super) fn maybe_item(p: &mut Parser, m: Marker) -> Result<(), Marker> {
has_mods = true; has_mods = true;
} }
if p.at(T![extern]) && p.nth(1) != T!['{'] && (p.nth(1) != STRING || p.nth(2) != T!['{']) { if p.at(T![extern]) {
has_extern = true;
has_mods = true; has_mods = true;
abi(p); abi(p);
} }
@ -211,25 +213,23 @@ pub(super) fn maybe_item(p: &mut Parser, m: Marker) -> Result<(), Marker> {
type_alias(p, m); type_alias(p, m);
} }
// test unsafe_extern_block
// unsafe extern "C" {} // unsafe extern "C" {}
T![extern] => { T!['{'] if has_extern => {
abi(p);
extern_item_list(p); extern_item_list(p);
m.complete(p, EXTERN_BLOCK); m.complete(p, EXTERN_BLOCK);
} }
_ => { _ if has_visibility || has_mods => {
if !has_visibility && !has_mods { if has_mods {
return Err(m); p.error("expected existential, fn, trait or impl");
} else { } else {
if has_mods { p.error("expected an item");
p.error("expected existential, fn, trait or impl");
} else {
p.error("expected an item");
}
m.complete(p, ERROR);
} }
m.complete(p, ERROR);
} }
_ => return Err(m),
} }
Ok(()) Ok(())
} }

15
crates/syntax/test_data/parser/err/0048_repated_extern_modifier.rast Normal file
View file

@ -0,0 +1,15 @@
SOURCE_FILE@0..22
ERROR@0..10
ABI@0..10
EXTERN_KW@0..6 "extern"
WHITESPACE@6..7 " "
STRING@7..10 "\"C\""
WHITESPACE@10..11 " "
ERROR@11..21
ABI@11..21
EXTERN_KW@11..17 "extern"
WHITESPACE@17..18 " "
STRING@18..21 "\"C\""
WHITESPACE@21..22 "\n"
error 10..10: expected existential, fn, trait or impl
error 21..21: expected existential, fn, trait or impl

1
crates/syntax/test_data/parser/err/0048_repated_extern_modifier.rs Normal file
View file

@ -0,0 +1 @@
extern "C" extern "C"

13
crates/syntax/test_data/parser/inline/ok/0167_unsafe_extern_block.rast Normal file
View file

@ -0,0 +1,13 @@
SOURCE_FILE@0..21
EXTERN_BLOCK@0..20
UNSAFE_KW@0..6 "unsafe"
WHITESPACE@6..7 " "
ABI@7..17
EXTERN_KW@7..13 "extern"
WHITESPACE@13..14 " "
STRING@14..17 "\"C\""
WHITESPACE@17..18 " "
EXTERN_ITEM_LIST@18..20
L_CURLY@18..19 "{"
R_CURLY@19..20 "}"
WHITESPACE@20..21 "\n"

1
crates/syntax/test_data/parser/inline/ok/0167_unsafe_extern_block.rs Normal file
View file

@ -0,0 +1 @@
unsafe extern "C" {}