Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2025-01-28 21:05:13 +00:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #15140 - tetsuharuohzeki:issue-15088-comment, r=Veykril

Browse source 
Add the comment why `HasSource::source()` returns `Option`

Fix https://github.com/rust-lang/rust-analyzer/issues/15088
This commit is contained in:
bors 2023-06-26 10:12:00 +00:00
commit 8769cd24bc
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/hir/src/has_source.rs
View file

@ -21,6 +21,10 @@ pub trait HasSource {
/// Fetches the definition's source node. /// Fetches the definition's source node.
/// Using [`crate::Semantics::source`] is preferred when working with [`crate::Semantics`], /// Using [`crate::Semantics::source`] is preferred when working with [`crate::Semantics`],
/// as that caches the parsed file in the semantics' cache. /// as that caches the parsed file in the semantics' cache.
///
/// The current some implementations can return `InFile` instead of `Option<InFile>`.
/// But we made this method `Option` to support rlib in the future
/// by https://github.com/rust-lang/rust-analyzer/issues/6913
fn source(self, db: &dyn HirDatabase) -> Option<InFile<Self::Ast>>; fn source(self, db: &dyn HirDatabase) -> Option<InFile<Self::Ast>>;
} }