refactoring to show more clearly the import problems

This commit is contained in:
Dmitry 2020-08-10 00:39:49 +07:00
parent 751d0367c2
commit 8366e3a7d5
2 changed files with 6 additions and 6 deletions

View file

@ -21,19 +21,19 @@ mod complete_trait_impl;
mod unstable_feature_descriptor; mod unstable_feature_descriptor;
use ra_ide_db::RootDatabase; use ra_ide_db::RootDatabase;
#[rustfmt::skip]
use crate::{ use crate::{
completion::{ completion::{
completion_context::CompletionContext, completion_context::CompletionContext,
completion_item::{CompletionKind, Completions}, completion_item::{CompletionKind, Completions},
//TODO: cyclic imports caused by xtask generation, this should be better
unstable_feature_descriptor::UNSTABLE_FEATURE_DESCRIPTOR,
complete_attribute::LintCompletion,
}, },
FilePosition, FilePosition,
}; };
//FIXME: cyclic imports caused by xtask generation, this should be better
use crate::completion::{
complete_attribute::LintCompletion, unstable_feature_descriptor::UNSTABLE_FEATURE_DESCRIPTOR,
};
pub use crate::completion::{ pub use crate::completion::{
completion_config::CompletionConfig, completion_config::CompletionConfig,
completion_item::{CompletionItem, CompletionItemKind, CompletionScore, InsertTextFormat}, completion_item::{CompletionItem, CompletionItemKind, CompletionScore, InsertTextFormat},

View file

@ -98,7 +98,7 @@ fn check_todo(path: &Path, text: &str) {
// `ast::make`. // `ast::make`.
"ast/make.rs", "ast/make.rs",
// The documentation in string literals may contain anything for its own purposes // The documentation in string literals may contain anything for its own purposes
"/completion/unstable_feature_descriptor.rs" "completion/unstable_feature_descriptor.rs",
]; ];
if need_todo.iter().any(|p| path.ends_with(p)) { if need_todo.iter().any(|p| path.ends_with(p)) {
return; return;