Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2024-12-27 13:33:31 +00:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #12626 - CuriousCorrelation:fix/empty-reasons, r=flodiebold

Browse source 
fix: trailing ':' on empty inactive reasons

## Description
Fixes trailing ':' even when there is no explanation. e.g.
``` sh
code is inactive due to #[cfg] directives:
```
## Issue
Fixes: #12615
This commit is contained in:
bors 2022-06-30 10:19:21 +00:00
commit 7f9c054686
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
crates/ide-diagnostics/src/handlers/inactive_code.rs
View file

@ -19,7 +19,13 @@ pub(crate) fn inactive_code(
let mut message = "code is inactive due to #[cfg] directives".to_string(); let mut message = "code is inactive due to #[cfg] directives".to_string();
if let Some(inactive) = inactive { if let Some(inactive) = inactive {
format_to!(message, ": {}", inactive); let inactive_reasons = inactive.to_string();
if inactive_reasons.is_empty() {
format_to!(message);
} else {
format_to!(message, ": {}", inactive);
}
} }
let res = Diagnostic::new( let res = Diagnostic::new(
@ -91,6 +97,9 @@ fn f() {
#[cfg(feature = "std")] use std; #[cfg(feature = "std")] use std;
//^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ weak: code is inactive due to #[cfg] directives: feature = "std" is disabled //^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ weak: code is inactive due to #[cfg] directives: feature = "std" is disabled
#[cfg(any())] pub fn f() {}
//^^^^^^^^^^^^^^^^^^^^^^^^^^^ weak: code is inactive due to #[cfg] directives
"#, "#,
); );
} }