From 773f3afd3628ed646fee561cb2a09a28454e72c8 Mon Sep 17 00:00:00 2001 From: Edwin Cheng Date: Tue, 10 Mar 2020 02:02:43 +0800 Subject: [PATCH] Add fixture meta for single file fixture --- crates/ra_db/src/fixture.rs | 51 ++++++++++++++++++++++++++---------- crates/ra_db/src/input.rs | 10 +++++++ crates/test_utils/src/lib.rs | 8 ++++++ 3 files changed, 55 insertions(+), 14 deletions(-) diff --git a/crates/ra_db/src/fixture.rs b/crates/ra_db/src/fixture.rs index 947d6ad568..7f43c29712 100644 --- a/crates/ra_db/src/fixture.rs +++ b/crates/ra_db/src/fixture.rs @@ -5,7 +5,7 @@ use std::sync::Arc; use ra_cfg::CfgOptions; use rustc_hash::FxHashMap; -use test_utils::{extract_offset, parse_fixture, CURSOR_MARKER}; +use test_utils::{extract_offset, parse_fixture, parse_single_fixture, CURSOR_MARKER}; use crate::{ input::CrateName, CrateGraph, CrateId, Edition, Env, FileId, FilePosition, RelativePathBuf, @@ -45,23 +45,37 @@ pub trait WithFixture: Default + SourceDatabaseExt + 'static { impl WithFixture for DB {} -fn with_single_file(db: &mut dyn SourceDatabaseExt, text: &str) -> FileId { +fn with_single_file(db: &mut dyn SourceDatabaseExt, ra_fixture: &str) -> FileId { let file_id = FileId(0); let rel_path: RelativePathBuf = "/main.rs".into(); let mut source_root = SourceRoot::new_local(); source_root.insert_file(rel_path.clone(), file_id); - let mut crate_graph = CrateGraph::default(); - crate_graph.add_crate_root( - file_id, - Edition::Edition2018, - None, - CfgOptions::default(), - Env::default(), - ); + let fixture = parse_single_fixture(ra_fixture); - db.set_file_text(file_id, Arc::new(text.to_string())); + let crate_graph = if let Some(entry) = fixture { + let meta = match parse_meta(&entry.meta) { + ParsedMeta::File(it) => it, + _ => panic!("with_single_file only support file meta"), + }; + + let mut crate_graph = CrateGraph::default(); + crate_graph.add_crate_root(file_id, meta.edition, meta.krate, meta.cfg, meta.env); + crate_graph + } else { + let mut crate_graph = CrateGraph::default(); + crate_graph.add_crate_root( + file_id, + Edition::Edition2018, + None, + CfgOptions::default(), + Env::default(), + ); + crate_graph + }; + + db.set_file_text(file_id, Arc::new(ra_fixture.to_string())); db.set_file_relative_path(file_id, rel_path); db.set_file_source_root(file_id, WORKSPACE); db.set_source_root(WORKSPACE, Arc::new(source_root)); @@ -104,7 +118,7 @@ fn with_files(db: &mut dyn SourceDatabaseExt, fixture: &str) -> Option, cfg: CfgOptions, edition: Edition, + env: Env, } -//- /lib.rs crate:foo deps:bar,baz +//- /lib.rs crate:foo deps:bar,baz cfg:foo=a,bar=b env:OUTDIR=path/to,OTHER=foo) fn parse_meta(meta: &str) -> ParsedMeta { let components = meta.split_ascii_whitespace().collect::>(); @@ -186,6 +201,7 @@ fn parse_meta(meta: &str) -> ParsedMeta { let mut deps = Vec::new(); let mut edition = Edition::Edition2018; let mut cfg = CfgOptions::default(); + let mut env = Env::default(); for component in components[1..].iter() { let (key, value) = split1(component, ':').unwrap(); match key { @@ -200,11 +216,18 @@ fn parse_meta(meta: &str) -> ParsedMeta { } } } + "env" => { + for key in value.split(',') { + if let Some((k, v)) = split1(key, '=') { + env.set(k.into(), v.into()); + } + } + } _ => panic!("bad component: {:?}", component), } } - ParsedMeta::File(FileMeta { path, krate, deps, edition, cfg }) + ParsedMeta::File(FileMeta { path, krate, deps, edition, cfg, env }) } fn split1(haystack: &str, delim: char) -> Option<(&str, &str)> { diff --git a/crates/ra_db/src/input.rs b/crates/ra_db/src/input.rs index b77640b2bc..1a1c642029 100644 --- a/crates/ra_db/src/input.rs +++ b/crates/ra_db/src/input.rs @@ -261,6 +261,16 @@ impl fmt::Display for Edition { } } +impl Env { + pub fn set(&mut self, env: &str, value: String) { + self.entries.insert(env.to_owned(), value); + } + + pub fn get(&self, env: &str) -> Option { + self.entries.get(env).cloned() + } +} + #[derive(Debug)] pub struct ParseEditionError { invalid_input: String, diff --git a/crates/test_utils/src/lib.rs b/crates/test_utils/src/lib.rs index 69deddcb5b..2432177b41 100644 --- a/crates/test_utils/src/lib.rs +++ b/crates/test_utils/src/lib.rs @@ -202,6 +202,14 @@ pub fn parse_fixture(fixture: &str) -> Vec { res } +/// Same as `parse_fixture`, except it allow empty fixture +pub fn parse_single_fixture(fixture: &str) -> Option { + if !fixture.lines().any(|it| it.trim_start().starts_with("//-")) { + return None; + } + parse_fixture(fixture).into_iter().nth(0) +} + // Comparison functionality borrowed from cargo: /// Compare a line with an expected pattern.