diff --git a/crates/hir/src/lib.rs b/crates/hir/src/lib.rs index a968b59bfe..6383a467eb 100644 --- a/crates/hir/src/lib.rs +++ b/crates/hir/src/lib.rs @@ -2517,18 +2517,35 @@ impl Type { krate: Crate, mut callback: impl FnMut(AssocItem) -> Option, ) -> Option { - for krate in method_resolution::def_crates(db, &self.ty, krate.id)? { + let mut slot = None; + self.iterate_assoc_items_dyn(db, krate, &mut |assoc_item_id| { + slot = callback(assoc_item_id.into()); + slot.is_some() + }); + slot + } + + fn iterate_assoc_items_dyn( + self, + db: &dyn HirDatabase, + krate: Crate, + callback: &mut dyn FnMut(AssocItemId) -> bool, + ) { + let def_crates = match method_resolution::def_crates(db, &self.ty, krate.id) { + Some(it) => it, + None => return, + }; + for krate in def_crates { let impls = db.inherent_impls_in_crate(krate); for impl_def in impls.for_self_ty(&self.ty) { for &item in db.impl_data(*impl_def).items.iter() { - if let Some(result) = callback(item.into()) { - return Some(result); + if callback(item) { + return; } } } } - None } pub fn type_arguments(&self) -> impl Iterator + '_ { @@ -2550,6 +2567,31 @@ impl Type { mut callback: impl FnMut(&Ty, Function) -> Option, ) -> Option { let _p = profile::span("iterate_method_candidates"); + let mut slot = None; + self.iterate_method_candidates_dyn( + db, + krate, + traits_in_scope, + name, + &mut |ty, assoc_item_id| match assoc_item_id { + AssocItemId::FunctionId(it) => { + slot = callback(ty, it.into()); + slot.is_some() + } + AssocItemId::ConstId(_) | AssocItemId::TypeAliasId(_) => false, + }, + ); + slot + } + + fn iterate_method_candidates_dyn( + &self, + db: &dyn HirDatabase, + krate: Crate, + traits_in_scope: &FxHashSet, + name: Option<&Name>, + callback: &mut dyn FnMut(&Ty, AssocItemId) -> bool, + ) { // There should be no inference vars in types passed here // FIXME check that? // FIXME replace Unknown by bound vars here @@ -2559,7 +2601,7 @@ impl Type { let env = self.env.clone(); let krate = krate.id; - method_resolution::iterate_method_candidates( + method_resolution::iterate_method_candidates_dyn( &canonical, db, env, @@ -2568,11 +2610,8 @@ impl Type { None, name, method_resolution::LookupMode::MethodCall, - |ty, it| match it { - AssocItemId::FunctionId(f) => callback(ty, f.into()), - _ => None, - }, - ) + callback, + ); } pub fn iterate_path_candidates( @@ -2584,12 +2623,34 @@ impl Type { mut callback: impl FnMut(&Ty, AssocItem) -> Option, ) -> Option { let _p = profile::span("iterate_path_candidates"); + let mut slot = None; + self.iterate_path_candidates_dyn( + db, + krate, + traits_in_scope, + name, + &mut |ty, assoc_item_id| { + slot = callback(ty, assoc_item_id.into()); + slot.is_some() + }, + ); + slot + } + + fn iterate_path_candidates_dyn( + &self, + db: &dyn HirDatabase, + krate: Crate, + traits_in_scope: &FxHashSet, + name: Option<&Name>, + callback: &mut dyn FnMut(&Ty, AssocItemId) -> bool, + ) { let canonical = hir_ty::replace_errors_with_variables(&self.ty); let env = self.env.clone(); let krate = krate.id; - method_resolution::iterate_method_candidates( + method_resolution::iterate_method_candidates_dyn( &canonical, db, env, @@ -2598,8 +2659,8 @@ impl Type { None, name, method_resolution::LookupMode::Path, - |ty, it| callback(ty, it.into()), - ) + callback, + ); } pub fn as_adt(&self) -> Option { diff --git a/crates/hir_ty/src/method_resolution.rs b/crates/hir_ty/src/method_resolution.rs index 3d233b1e20..0bd1d30bbf 100644 --- a/crates/hir_ty/src/method_resolution.rs +++ b/crates/hir_ty/src/method_resolution.rs @@ -410,7 +410,7 @@ pub enum LookupMode { // This would be nicer if it just returned an iterator, but that runs into // lifetime problems, because we need to borrow temp `CrateImplDefs`. // FIXME add a context type here? -pub fn iterate_method_candidates( +pub fn iterate_method_candidates( ty: &Canonical, db: &dyn HirDatabase, env: Arc, @@ -422,7 +422,7 @@ pub fn iterate_method_candidates( mut callback: impl FnMut(&Ty, AssocItemId) -> Option, ) -> Option { let mut slot = None; - iterate_method_candidates_impl( + iterate_method_candidates_dyn( ty, db, env, @@ -440,7 +440,7 @@ pub fn iterate_method_candidates( slot } -fn iterate_method_candidates_impl( +pub fn iterate_method_candidates_dyn( ty: &Canonical, db: &dyn HirDatabase, env: Arc,