11029: internal: Refactor release workflow to reduce duplication r=lnicola a=lnicola

This reduces duplication by using `matrix` and paves the way for https://github.com/rust-analyzer/rust-analyzer/issues/10483. The `musl` builder is unchanged because it uses a container.

~~We also get rid of the MacOS 11 SDK thing, which is from when most MacOS builders were on 10.~~ Or not, the default is still 10.15.

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
This commit is contained in:
bors[bot] 2021-12-15 22:00:51 +00:00 committed by GitHub
commit 661e3f933a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -1,14 +1,14 @@
name: release name: release
on: on:
schedule: schedule:
- cron: '0 0 * * *' # midnight UTC - cron: "0 0 * * *" # midnight UTC
workflow_dispatch: workflow_dispatch:
push: push:
branches: branches:
- release - release
- trigger-nightly - trigger-nightly
env: env:
CARGO_INCREMENTAL: 0 CARGO_INCREMENTAL: 0
@ -18,148 +18,98 @@ env:
FETCH_DEPTH: 0 # pull in the tags for the version string FETCH_DEPTH: 0 # pull in the tags for the version string
jobs: jobs:
dist-x86_64-pc-windows-msvc: dist:
name: dist (x86_64-pc-windows-msvc) strategy:
runs-on: windows-latest matrix:
include:
- os: windows-latest
target: x86_64-pc-windows-msvc
- os: windows-latest
target: aarch64-pc-windows-msvc
- os: ubuntu-20.04
target: x86_64-unknown-linux-gnu
- os: ubuntu-20.04
target: aarch64-unknown-linux-gnu
cross_linker: aarch64-linux-gnu-gcc
- os: macos-11
target: x86_64-apple-darwin
- os: macos-11
target: aarch64-apple-darwin
name: dist (${{ matrix.target }})
runs-on: ${{ matrix.os }}
env: env:
RA_TARGET: x86_64-pc-windows-msvc RA_TARGET: ${{ matrix.target }}
CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER: ${{ matrix.cross_linker }}
steps: steps:
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v2 uses: actions/checkout@v2
with: with:
fetch-depth: ${{ env.FETCH_DEPTH }} fetch-depth: ${{ env.FETCH_DEPTH }}
# We need to disable the existing toolchain to avoid updating rust-docs # We need to disable the existing toolchain to avoid updating rust-docs
# which takes a long time. The fastest way to do this is to rename the # which takes a long time. The fastest way to do this is to rename the
# existing folder, as deleting it takes about as much time as not doing # existing folder, as deleting it takes about as much time as not doing
# anything and just updating rust-docs. # anything and just updating rust-docs.
- name: Rename existing rust toolchain - name: Rename existing Rust toolchain
run: Rename-Item C:\Users\runneradmin\.rustup\toolchains\stable-x86_64-pc-windows-msvc C:\Users\runneradmin\.rustup\toolchains\stable-x86_64-pc-windows-msvc.old if: matrix.os == 'windows-latest'
run: Rename-Item C:\Users\runneradmin\.rustup\toolchains\stable-x86_64-pc-windows-msvc C:\Users\runneradmin\.rustup\toolchains\stable-x86_64-pc-windows-msvc.old
- name: Install Rust toolchain - name: Install Rust toolchain
uses: actions-rs/toolchain@v1 uses: actions-rs/toolchain@v1
with: with:
toolchain: stable toolchain: stable
profile: minimal target: ${{ matrix.target }}
override: true profile: minimal
override: true
- name: Dist - name: Install Rust library source
run: cargo xtask dist if: matrix.target == 'x86_64-unknown-linux-gnu'
uses: actions-rs/toolchain@v1
with:
toolchain: stable
target: ${{ matrix.target }}
profile: minimal
override: true
components: rust-src
- name: Upload artifacts - name: Install Node.js
uses: actions/upload-artifact@v1 if: matrix.target == 'x86_64-unknown-linux-gnu'
with: uses: actions/setup-node@v1
name: dist-x86_64-pc-windows-msvc with:
path: ./dist node-version: 14.x
dist-aarch64-pc-windows-msvc: - name: Update apt repositories
name: dist (aarch64-pc-windows-msvc) if: matrix.target == 'aarch64-unknown-linux-gnu'
runs-on: windows-latest run: sudo apt-get update
env:
RA_TARGET: aarch64-pc-windows-msvc
steps: - name: Install target toolchain
- name: Checkout repository if: matrix.target == 'aarch64-unknown-linux-gnu'
uses: actions/checkout@v2 run: sudo apt-get install gcc-aarch64-linux-gnu
with:
fetch-depth: ${{ env.FETCH_DEPTH }}
- name: Rename existing rust toolchain - name: Dist (generic)
run: Rename-Item C:\Users\runneradmin\.rustup\toolchains\stable-x86_64-pc-windows-msvc C:\Users\runneradmin\.rustup\toolchains\stable-x86_64-pc-windows-msvc.old if: matrix.target != 'x86_64-unknown-linux-gnu'
run: cargo xtask dist
- name: Install Rust toolchain - name: Dist (Linux)
uses: actions-rs/toolchain@v1 if: matrix.target == 'x86_64-unknown-linux-gnu'
with: run: cargo xtask dist --client-patch-version $GITHUB_RUN_NUMBER
toolchain: stable
target: aarch64-pc-windows-msvc
profile: minimal
override: true
- name: Dist - name: Run analysis-stats on rust-analyzer
run: cargo xtask dist if: matrix.target == 'x86_64-unknown-linux-gnu'
run: target/${{ matrix.target }}/release/rust-analyzer analysis-stats .
- name: Upload artifacts - name: Run analysis-stats on rust std library
uses: actions/upload-artifact@v1 if: matrix.target == 'x86_64-unknown-linux-gnu'
with: run: target/${{ matrix.target }}/release/rust-analyzer analysis-stats --with-deps $(rustc --print sysroot)/lib/rustlib/src/rust/library/std
name: dist-aarch64-pc-windows-msvc
path: ./dist
dist-x86_64-unknown-linux-gnu: - name: Upload artifacts
name: dist (x86_64-unknown-linux-gnu) uses: actions/upload-artifact@v1
runs-on: ubuntu-20.04 with:
env: name: dist-${{ matrix.target }}
RA_TARGET: x86_64-unknown-linux-gnu path: ./dist
steps:
- name: Checkout repository
uses: actions/checkout@v2
with:
fetch-depth: ${{ env.FETCH_DEPTH }}
- name: Install Rust toolchain
uses: actions-rs/toolchain@v1
with:
toolchain: stable
profile: minimal
override: true
components: rust-src
- name: Install Nodejs
uses: actions/setup-node@v1
with:
node-version: 14.x
- name: Dist
run: cargo xtask dist --client-patch-version $GITHUB_RUN_NUMBER
- name: Run analysis-stats on rust-analyzer
run: target/${{ env.RA_TARGET }}/release/rust-analyzer analysis-stats .
- name: Run analysis-stats on rust std library
run: target/${{ env.RA_TARGET }}/release/rust-analyzer analysis-stats --with-deps $(rustc --print sysroot)/lib/rustlib/src/rust/library/std
- name: Upload artifacts
uses: actions/upload-artifact@v1
with:
name: dist-x86_64-unknown-linux-gnu
path: ./dist
dist-aarch64-unknown-linux-gnu:
name: dist (aarch64-unknown-linux-gnu)
runs-on: ubuntu-20.04
env:
RA_TARGET: aarch64-unknown-linux-gnu
CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER: aarch64-linux-gnu-gcc
steps:
- name: Checkout repository
uses: actions/checkout@v2
with:
fetch-depth: ${{ env.FETCH_DEPTH }}
- name: Install Rust toolchain
uses: actions-rs/toolchain@v1
with:
toolchain: stable
target: aarch64-unknown-linux-gnu
profile: minimal
override: true
- name: Update apt repositories
run: sudo apt-get update
- name: Install target toolchain
run: sudo apt-get install gcc-aarch64-linux-gnu
- name: Dist
run: cargo xtask dist
- name: Upload artifacts
uses: actions/upload-artifact@v1
with:
name: dist-aarch64-unknown-linux-gnu
path: ./dist
dist-x86_64-unknown-linux-musl: dist-x86_64-unknown-linux-musl:
name: dist (x86_64-unknown-linux-musl) name: dist (x86_64-unknown-linux-musl)
@ -171,158 +121,92 @@ jobs:
container: container:
image: rust:alpine image: rust:alpine
volumes: volumes:
- /usr/local/cargo/registry - /usr/local/cargo/registry
steps: steps:
- name: Install dependencies - name: Install dependencies
run: apk add --no-cache git clang lld musl-dev run: apk add --no-cache git clang lld musl-dev
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v2 uses: actions/checkout@v2
with: with:
fetch-depth: ${{ env.FETCH_DEPTH }} fetch-depth: ${{ env.FETCH_DEPTH }}
- name: Dist - name: Dist
run: cargo xtask dist run: cargo xtask dist
- name: Upload artifacts - name: Upload artifacts
uses: actions/upload-artifact@v1 uses: actions/upload-artifact@v1
with: with:
name: dist-x86_64-unknown-linux-musl name: dist-x86_64-unknown-linux-musl
path: ./dist path: ./dist
dist-x86_64-apple-darwin:
name: dist (x86_64-apple-darwin)
runs-on: macos-latest
env:
RA_TARGET: x86_64-apple-darwin
# SELECT_XCODE: /Applications/Xcode_12.2.app
steps:
# use the default (12.5.1 as of today)
# - name: Select XCode version
# run: sudo xcode-select -s "${SELECT_XCODE}"
- name: Checkout repository
uses: actions/checkout@v2
with:
fetch-depth: ${{ env.FETCH_DEPTH }}
- name: Install Rust toolchain
uses: actions-rs/toolchain@v1
with:
toolchain: stable
profile: minimal
override: true
- name: Dist
run: cargo xtask dist
- name: Upload artifacts
uses: actions/upload-artifact@v1
with:
name: dist-x86_64-apple-darwin
path: ./dist
dist-aarch64-apple-darwin:
name: dist (aarch64-apple-darwin)
runs-on: macos-latest
env:
RA_TARGET: aarch64-apple-darwin
# SELECT_XCODE: /Applications/Xcode_12.2.app
steps:
# - name: Select XCode version
# run: sudo xcode-select -s "${SELECT_XCODE}"
- name: Checkout repository
uses: actions/checkout@v2
with:
fetch-depth: ${{ env.FETCH_DEPTH }}
- name: Install Rust toolchain
uses: actions-rs/toolchain@v1
with:
toolchain: stable
target: aarch64-apple-darwin
profile: minimal
override: true
- name: Dist
run: SDKROOT=$(xcrun -sdk macosx11.0 --show-sdk-path) MACOSX_DEPLOYMENT_TARGET=$(xcrun -sdk macosx11.0 --show-sdk-platform-version) cargo xtask dist
- name: Upload artifacts
uses: actions/upload-artifact@v1
with:
name: dist-aarch64-apple-darwin
path: ./dist
publish: publish:
name: publish name: publish
runs-on: ubuntu-latest runs-on: ubuntu-latest
needs: ['dist-x86_64-pc-windows-msvc', 'dist-aarch64-pc-windows-msvc', 'dist-x86_64-unknown-linux-gnu', 'dist-x86_64-unknown-linux-musl', 'dist-aarch64-unknown-linux-gnu', 'dist-x86_64-apple-darwin', 'dist-aarch64-apple-darwin'] needs: ["dist", "dist-x86_64-unknown-linux-musl"]
steps: steps:
- name: Install Nodejs - name: Install Nodejs
uses: actions/setup-node@v1 uses: actions/setup-node@v1
with: with:
node-version: 14.x node-version: 14.x
- run: echo "TAG=$(date --iso -u)" >> $GITHUB_ENV - run: echo "TAG=$(date --iso -u)" >> $GITHUB_ENV
if: github.ref == 'refs/heads/release' if: github.ref == 'refs/heads/release'
- run: echo "TAG=nightly" >> $GITHUB_ENV - run: echo "TAG=nightly" >> $GITHUB_ENV
if: github.ref != 'refs/heads/release' if: github.ref != 'refs/heads/release'
- run: 'echo "TAG: $TAG"' - run: 'echo "TAG: $TAG"'
- name: Checkout repository - name: Checkout repository
uses: actions/checkout@v2 uses: actions/checkout@v2
with: with:
fetch-depth: ${{ env.FETCH_DEPTH }} fetch-depth: ${{ env.FETCH_DEPTH }}
- run: echo "HEAD_SHA=$(git rev-parse HEAD)" >> $GITHUB_ENV - run: echo "HEAD_SHA=$(git rev-parse HEAD)" >> $GITHUB_ENV
- run: 'echo "HEAD_SHA: $HEAD_SHA"' - run: 'echo "HEAD_SHA: $HEAD_SHA"'
- uses: actions/download-artifact@v1 - uses: actions/download-artifact@v1
with: with:
name: dist-aarch64-apple-darwin name: dist-aarch64-apple-darwin
path: dist path: dist
- uses: actions/download-artifact@v1 - uses: actions/download-artifact@v1
with: with:
name: dist-x86_64-apple-darwin name: dist-x86_64-apple-darwin
path: dist path: dist
- uses: actions/download-artifact@v1 - uses: actions/download-artifact@v1
with: with:
name: dist-x86_64-unknown-linux-gnu name: dist-x86_64-unknown-linux-gnu
path: dist path: dist
- uses: actions/download-artifact@v1 - uses: actions/download-artifact@v1
with: with:
name: dist-x86_64-unknown-linux-musl name: dist-x86_64-unknown-linux-musl
path: dist path: dist
- uses: actions/download-artifact@v1 - uses: actions/download-artifact@v1
with: with:
name: dist-aarch64-unknown-linux-gnu name: dist-aarch64-unknown-linux-gnu
path: dist path: dist
- uses: actions/download-artifact@v1 - uses: actions/download-artifact@v1
with: with:
name: dist-x86_64-pc-windows-msvc name: dist-x86_64-pc-windows-msvc
path: dist path: dist
- uses: actions/download-artifact@v1 - uses: actions/download-artifact@v1
with: with:
name: dist-aarch64-pc-windows-msvc name: dist-aarch64-pc-windows-msvc
path: dist path: dist
- run: ls -al ./dist - run: ls -al ./dist
- name: Publish Release - name: Publish Release
uses: ./.github/actions/github-release uses: ./.github/actions/github-release
with: with:
files: "dist/*" files: "dist/*"
name: ${{ env.TAG }} name: ${{ env.TAG }}
token: ${{ secrets.GITHUB_TOKEN }} token: ${{ secrets.GITHUB_TOKEN }}
- run: npm ci - run: npm ci
working-directory: ./editors/code working-directory: ./editors/code
- name: Publish Extension - name: Publish Extension
if: github.ref == 'refs/heads/release' if: github.ref == 'refs/heads/release'
working-directory: ./editors/code working-directory: ./editors/code
# token from https://dev.azure.com/rust-analyzer/ # token from https://dev.azure.com/rust-analyzer/
run: npx vsce publish --pat ${{ secrets.MARKETPLACE_TOKEN }} --packagePath ../../dist/rust-analyzer.vsix run: npx vsce publish --pat ${{ secrets.MARKETPLACE_TOKEN }} --packagePath ../../dist/rust-analyzer.vsix