Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2024-11-10 07:04:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #17033 - ShoyuVanilla:flyck-log, r=Veykril

Browse source 
Log flycheck errors

Resolves #16969

The non-cargo messages are appended to the error strings here;

7a8374c162/crates/flycheck/src/lib.rs (L460-L482)

that one is formatted into `Err` here;

7a8374c162/crates/flycheck/src/command.rs (L144-L155)

and finally, this PR appends it at the end of existing Flycheck error message
This commit is contained in:
bors 2024-04-11 07:01:20 +00:00
commit 657b33b0cb
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
crates/flycheck/src/lib.rs
View file

@ -286,7 +286,7 @@ impl FlycheckActor {
tracing::debug!(?command, "will restart flycheck");
match CommandHandle::spawn(command) {
Ok(command_handle) => {
tracing::debug!(command = formatted_command, "did restart flycheck");
tracing::debug!(command = formatted_command, "did restart flycheck");
self.command_handle = Some(command_handle);
self.report_progress(Progress::DidStart);
}
@ -306,10 +306,11 @@ impl FlycheckActor {
let formatted_handle = format!("{:?}", command_handle);
let res = command_handle.join();
if res.is_err() {
if let Err(error) = &res {
tracing::error!(
"Flycheck failed to run the following command: {}",
formatted_handle
"Flycheck failed to run the following command: {}, error={}",
formatted_handle,
error
);
}
self.report_progress(Progress::DidFinish(res));