mirror of
https://github.com/rust-lang/rust-analyzer
synced 2024-12-26 04:53:34 +00:00
Move text-edit into ide-db
This commit is contained in:
parent
80e9d014be
commit
64f56f458f
63 changed files with 684 additions and 707 deletions
15
Cargo.lock
generated
15
Cargo.lock
generated
|
@ -671,7 +671,6 @@ dependencies = [
|
||||||
"syntax",
|
"syntax",
|
||||||
"test-fixture",
|
"test-fixture",
|
||||||
"test-utils",
|
"test-utils",
|
||||||
"text-edit",
|
|
||||||
"toolchain",
|
"toolchain",
|
||||||
"tracing",
|
"tracing",
|
||||||
"triomphe",
|
"triomphe",
|
||||||
|
@ -693,7 +692,6 @@ dependencies = [
|
||||||
"syntax",
|
"syntax",
|
||||||
"test-fixture",
|
"test-fixture",
|
||||||
"test-utils",
|
"test-utils",
|
||||||
"text-edit",
|
|
||||||
"tracing",
|
"tracing",
|
||||||
]
|
]
|
||||||
|
|
||||||
|
@ -712,7 +710,6 @@ dependencies = [
|
||||||
"syntax",
|
"syntax",
|
||||||
"test-fixture",
|
"test-fixture",
|
||||||
"test-utils",
|
"test-utils",
|
||||||
"text-edit",
|
|
||||||
"tracing",
|
"tracing",
|
||||||
]
|
]
|
||||||
|
|
||||||
|
@ -744,7 +741,6 @@ dependencies = [
|
||||||
"syntax",
|
"syntax",
|
||||||
"test-fixture",
|
"test-fixture",
|
||||||
"test-utils",
|
"test-utils",
|
||||||
"text-edit",
|
|
||||||
"tracing",
|
"tracing",
|
||||||
"triomphe",
|
"triomphe",
|
||||||
]
|
]
|
||||||
|
@ -766,7 +762,6 @@ dependencies = [
|
||||||
"syntax",
|
"syntax",
|
||||||
"test-fixture",
|
"test-fixture",
|
||||||
"test-utils",
|
"test-utils",
|
||||||
"text-edit",
|
|
||||||
"tracing",
|
"tracing",
|
||||||
]
|
]
|
||||||
|
|
||||||
|
@ -785,7 +780,6 @@ dependencies = [
|
||||||
"syntax",
|
"syntax",
|
||||||
"test-fixture",
|
"test-fixture",
|
||||||
"test-utils",
|
"test-utils",
|
||||||
"text-edit",
|
|
||||||
"triomphe",
|
"triomphe",
|
||||||
]
|
]
|
||||||
|
|
||||||
|
@ -1979,7 +1973,6 @@ dependencies = [
|
||||||
"smol_str",
|
"smol_str",
|
||||||
"stdx",
|
"stdx",
|
||||||
"test-utils",
|
"test-utils",
|
||||||
"text-edit",
|
|
||||||
"tracing",
|
"tracing",
|
||||||
"triomphe",
|
"triomphe",
|
||||||
]
|
]
|
||||||
|
@ -2027,14 +2020,6 @@ dependencies = [
|
||||||
"tracing",
|
"tracing",
|
||||||
]
|
]
|
||||||
|
|
||||||
[[package]]
|
|
||||||
name = "text-edit"
|
|
||||||
version = "0.0.0"
|
|
||||||
dependencies = [
|
|
||||||
"itertools",
|
|
||||||
"text-size",
|
|
||||||
]
|
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "text-size"
|
name = "text-size"
|
||||||
version = "1.1.1"
|
version = "1.1.1"
|
||||||
|
|
|
@ -79,7 +79,6 @@ span = { path = "./crates/span", version = "0.0.0" }
|
||||||
stdx = { path = "./crates/stdx", version = "0.0.0" }
|
stdx = { path = "./crates/stdx", version = "0.0.0" }
|
||||||
syntax = { path = "./crates/syntax", version = "0.0.0" }
|
syntax = { path = "./crates/syntax", version = "0.0.0" }
|
||||||
syntax-bridge = { path = "./crates/syntax-bridge", version = "0.0.0" }
|
syntax-bridge = { path = "./crates/syntax-bridge", version = "0.0.0" }
|
||||||
text-edit = { path = "./crates/text-edit", version = "0.0.0" }
|
|
||||||
toolchain = { path = "./crates/toolchain", version = "0.0.0" }
|
toolchain = { path = "./crates/toolchain", version = "0.0.0" }
|
||||||
tt = { path = "./crates/tt", version = "0.0.0" }
|
tt = { path = "./crates/tt", version = "0.0.0" }
|
||||||
vfs-notify = { path = "./crates/vfs-notify", version = "0.0.0" }
|
vfs-notify = { path = "./crates/vfs-notify", version = "0.0.0" }
|
||||||
|
|
|
@ -23,7 +23,6 @@ tracing.workspace = true
|
||||||
# local deps
|
# local deps
|
||||||
stdx.workspace = true
|
stdx.workspace = true
|
||||||
syntax.workspace = true
|
syntax.workspace = true
|
||||||
text-edit.workspace = true
|
|
||||||
ide-db.workspace = true
|
ide-db.workspace = true
|
||||||
hir.workspace = true
|
hir.workspace = true
|
||||||
|
|
||||||
|
|
|
@ -1,5 +1,6 @@
|
||||||
use either::Either;
|
use either::Either;
|
||||||
use hir::ModuleDef;
|
use hir::ModuleDef;
|
||||||
|
use ide_db::text_edit::TextRange;
|
||||||
use ide_db::{
|
use ide_db::{
|
||||||
assists::{AssistId, AssistKind},
|
assists::{AssistId, AssistKind},
|
||||||
defs::Definition,
|
defs::Definition,
|
||||||
|
@ -19,7 +20,6 @@ use syntax::{
|
||||||
},
|
},
|
||||||
AstNode, NodeOrToken, SyntaxKind, SyntaxNode, T,
|
AstNode, NodeOrToken, SyntaxKind, SyntaxNode, T,
|
||||||
};
|
};
|
||||||
use text_edit::TextRange;
|
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
assist_context::{AssistContext, Assists},
|
assist_context::{AssistContext, Assists},
|
||||||
|
|
|
@ -1,4 +1,5 @@
|
||||||
use hir::{sym, HasVisibility};
|
use hir::{sym, HasVisibility};
|
||||||
|
use ide_db::text_edit::TextRange;
|
||||||
use ide_db::{
|
use ide_db::{
|
||||||
assists::{AssistId, AssistKind},
|
assists::{AssistId, AssistKind},
|
||||||
defs::Definition,
|
defs::Definition,
|
||||||
|
@ -8,7 +9,6 @@ use ide_db::{
|
||||||
};
|
};
|
||||||
use itertools::Itertools;
|
use itertools::Itertools;
|
||||||
use syntax::{ast, ted, AstNode, Edition, SmolStr, SyntaxNode, ToSmolStr};
|
use syntax::{ast, ted, AstNode, Edition, SmolStr, SyntaxNode, ToSmolStr};
|
||||||
use text_edit::TextRange;
|
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
assist_context::{AssistContext, Assists, SourceChangeBuilder},
|
assist_context::{AssistContext, Assists, SourceChangeBuilder},
|
||||||
|
|
|
@ -1,3 +1,4 @@
|
||||||
|
use ide_db::text_edit::TextRange;
|
||||||
use ide_db::{
|
use ide_db::{
|
||||||
assists::{AssistId, AssistKind},
|
assists::{AssistId, AssistKind},
|
||||||
defs::Definition,
|
defs::Definition,
|
||||||
|
@ -8,7 +9,6 @@ use syntax::{
|
||||||
ast::{self, make, AstNode, FieldExpr, HasName, IdentPat},
|
ast::{self, make, AstNode, FieldExpr, HasName, IdentPat},
|
||||||
ted,
|
ted,
|
||||||
};
|
};
|
||||||
use text_edit::TextRange;
|
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
assist_context::{AssistContext, Assists, SourceChangeBuilder},
|
assist_context::{AssistContext, Assists, SourceChangeBuilder},
|
||||||
|
|
|
@ -1,6 +1,7 @@
|
||||||
use std::collections::hash_map::Entry;
|
use std::collections::hash_map::Entry;
|
||||||
|
|
||||||
use hir::{FileRange, HirFileIdExt, InFile, InRealFile, Module, ModuleSource};
|
use hir::{FileRange, HirFileIdExt, InFile, InRealFile, Module, ModuleSource};
|
||||||
|
use ide_db::text_edit::TextRange;
|
||||||
use ide_db::{
|
use ide_db::{
|
||||||
defs::Definition,
|
defs::Definition,
|
||||||
search::{FileReference, ReferenceCategory, SearchScope},
|
search::{FileReference, ReferenceCategory, SearchScope},
|
||||||
|
@ -10,7 +11,6 @@ use syntax::{
|
||||||
ast::{self, Rename},
|
ast::{self, Rename},
|
||||||
AstNode,
|
AstNode,
|
||||||
};
|
};
|
||||||
use text_edit::TextRange;
|
|
||||||
|
|
||||||
use crate::{AssistContext, AssistId, AssistKind, Assists};
|
use crate::{AssistContext, AssistId, AssistKind, Assists};
|
||||||
|
|
||||||
|
|
|
@ -1,4 +1,5 @@
|
||||||
use hir::{FileRange, Semantics};
|
use hir::{FileRange, Semantics};
|
||||||
|
use ide_db::text_edit::TextRange;
|
||||||
use ide_db::{
|
use ide_db::{
|
||||||
defs::Definition,
|
defs::Definition,
|
||||||
search::{SearchScope, UsageSearchResult},
|
search::{SearchScope, UsageSearchResult},
|
||||||
|
@ -11,7 +12,6 @@ use syntax::{
|
||||||
},
|
},
|
||||||
match_ast, ted, AstNode,
|
match_ast, ted, AstNode,
|
||||||
};
|
};
|
||||||
use text_edit::TextRange;
|
|
||||||
|
|
||||||
use crate::{AssistContext, AssistId, AssistKind, Assists};
|
use crate::{AssistContext, AssistId, AssistKind, Assists};
|
||||||
|
|
||||||
|
|
|
@ -25,7 +25,6 @@ base-db.workspace = true
|
||||||
ide-db.workspace = true
|
ide-db.workspace = true
|
||||||
stdx.workspace = true
|
stdx.workspace = true
|
||||||
syntax.workspace = true
|
syntax.workspace = true
|
||||||
text-edit.workspace = true
|
|
||||||
# completions crate should depend only on the top-level `hir` package. if you need
|
# completions crate should depend only on the top-level `hir` package. if you need
|
||||||
# something from some `hir-xxx` subpackage, reexport the API via `hir`.
|
# something from some `hir-xxx` subpackage, reexport the API via `hir`.
|
||||||
hir.workspace = true
|
hir.workspace = true
|
||||||
|
|
|
@ -32,6 +32,7 @@
|
||||||
//! ```
|
//! ```
|
||||||
|
|
||||||
use hir::{db::ExpandDatabase, HasAttrs, MacroFileId, Name};
|
use hir::{db::ExpandDatabase, HasAttrs, MacroFileId, Name};
|
||||||
|
use ide_db::text_edit::TextEdit;
|
||||||
use ide_db::{
|
use ide_db::{
|
||||||
documentation::HasDocs, path_transform::PathTransform,
|
documentation::HasDocs, path_transform::PathTransform,
|
||||||
syntax_helpers::prettify_macro_expansion, traits::get_missing_assoc_items, SymbolKind,
|
syntax_helpers::prettify_macro_expansion, traits::get_missing_assoc_items, SymbolKind,
|
||||||
|
@ -40,7 +41,6 @@ use syntax::{
|
||||||
ast::{self, edit_in_place::AttrsOwnerEdit, make, HasGenericArgs, HasTypeBounds},
|
ast::{self, edit_in_place::AttrsOwnerEdit, make, HasGenericArgs, HasTypeBounds},
|
||||||
format_smolstr, ted, AstNode, SmolStr, SyntaxElement, SyntaxKind, TextRange, ToSmolStr, T,
|
format_smolstr, ted, AstNode, SmolStr, SyntaxElement, SyntaxKind, TextRange, ToSmolStr, T,
|
||||||
};
|
};
|
||||||
use text_edit::TextEdit;
|
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
context::PathCompletionCtx, CompletionContext, CompletionItem, CompletionItemKind,
|
context::PathCompletionCtx, CompletionContext, CompletionItem, CompletionItemKind,
|
||||||
|
|
|
@ -3,6 +3,7 @@
|
||||||
mod format_like;
|
mod format_like;
|
||||||
|
|
||||||
use hir::ItemInNs;
|
use hir::ItemInNs;
|
||||||
|
use ide_db::text_edit::TextEdit;
|
||||||
use ide_db::{
|
use ide_db::{
|
||||||
documentation::{Documentation, HasDocs},
|
documentation::{Documentation, HasDocs},
|
||||||
imports::insert_use::ImportScope,
|
imports::insert_use::ImportScope,
|
||||||
|
@ -15,7 +16,6 @@ use syntax::{
|
||||||
SyntaxKind::{BLOCK_EXPR, EXPR_STMT, FOR_EXPR, IF_EXPR, LOOP_EXPR, STMT_LIST, WHILE_EXPR},
|
SyntaxKind::{BLOCK_EXPR, EXPR_STMT, FOR_EXPR, IF_EXPR, LOOP_EXPR, STMT_LIST, WHILE_EXPR},
|
||||||
TextRange, TextSize,
|
TextRange, TextSize,
|
||||||
};
|
};
|
||||||
use text_edit::TextEdit;
|
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
completions::postfix::format_like::add_format_like_completions,
|
completions::postfix::format_like::add_format_like_completions,
|
||||||
|
|
|
@ -20,7 +20,6 @@ use syntax::{
|
||||||
SyntaxKind::{self, *},
|
SyntaxKind::{self, *},
|
||||||
SyntaxToken, TextRange, TextSize, T,
|
SyntaxToken, TextRange, TextSize, T,
|
||||||
};
|
};
|
||||||
use text_edit::Indel;
|
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
context::analysis::{expand_and_analyze, AnalysisResult},
|
context::analysis::{expand_and_analyze, AnalysisResult},
|
||||||
|
@ -684,8 +683,7 @@ impl<'a> CompletionContext<'a> {
|
||||||
// actual completion.
|
// actual completion.
|
||||||
let file_with_fake_ident = {
|
let file_with_fake_ident = {
|
||||||
let parse = db.parse(file_id);
|
let parse = db.parse(file_id);
|
||||||
let edit = Indel::insert(offset, COMPLETION_MARKER.to_owned());
|
parse.reparse(TextRange::empty(offset), COMPLETION_MARKER, file_id.edition()).tree()
|
||||||
parse.reparse(&edit, file_id.edition()).tree()
|
|
||||||
};
|
};
|
||||||
|
|
||||||
// always pick the token to the immediate left of the cursor, as that is what we are actually
|
// always pick the token to the immediate left of the cursor, as that is what we are actually
|
||||||
|
|
|
@ -3,6 +3,7 @@
|
||||||
use std::{fmt, mem};
|
use std::{fmt, mem};
|
||||||
|
|
||||||
use hir::Mutability;
|
use hir::Mutability;
|
||||||
|
use ide_db::text_edit::TextEdit;
|
||||||
use ide_db::{
|
use ide_db::{
|
||||||
documentation::Documentation, imports::import_assets::LocatedImport, RootDatabase, SnippetCap,
|
documentation::Documentation, imports::import_assets::LocatedImport, RootDatabase, SnippetCap,
|
||||||
SymbolKind,
|
SymbolKind,
|
||||||
|
@ -11,7 +12,6 @@ use itertools::Itertools;
|
||||||
use smallvec::SmallVec;
|
use smallvec::SmallVec;
|
||||||
use stdx::{impl_from, never};
|
use stdx::{impl_from, never};
|
||||||
use syntax::{format_smolstr, Edition, SmolStr, TextRange, TextSize};
|
use syntax::{format_smolstr, Edition, SmolStr, TextRange, TextSize};
|
||||||
use text_edit::TextEdit;
|
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
context::{CompletionContext, PathCompletionCtx},
|
context::{CompletionContext, PathCompletionCtx},
|
||||||
|
@ -426,7 +426,7 @@ impl CompletionItem {
|
||||||
self.lookup.as_str()
|
self.lookup.as_str()
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn ref_match(&self) -> Option<(String, text_edit::Indel, CompletionRelevance)> {
|
pub fn ref_match(&self) -> Option<(String, ide_db::text_edit::Indel, CompletionRelevance)> {
|
||||||
// Relevance of the ref match should be the same as the original
|
// Relevance of the ref match should be the same as the original
|
||||||
// match, but with exact type match set because self.ref_match
|
// match, but with exact type match set because self.ref_match
|
||||||
// is only set if there is an exact type match.
|
// is only set if there is an exact type match.
|
||||||
|
@ -436,7 +436,10 @@ impl CompletionItem {
|
||||||
self.ref_match.map(|(mutability, offset)| {
|
self.ref_match.map(|(mutability, offset)| {
|
||||||
(
|
(
|
||||||
format!("&{}{}", mutability.as_keyword_for_ref(), self.label),
|
format!("&{}{}", mutability.as_keyword_for_ref(), self.label),
|
||||||
text_edit::Indel::insert(offset, format!("&{}", mutability.as_keyword_for_ref())),
|
ide_db::text_edit::Indel::insert(
|
||||||
|
offset,
|
||||||
|
format!("&{}", mutability.as_keyword_for_ref()),
|
||||||
|
),
|
||||||
relevance,
|
relevance,
|
||||||
)
|
)
|
||||||
})
|
})
|
||||||
|
|
|
@ -10,16 +10,17 @@ mod snippet;
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests;
|
mod tests;
|
||||||
|
|
||||||
|
use ide_db::text_edit::TextEdit;
|
||||||
use ide_db::{
|
use ide_db::{
|
||||||
helpers::mod_path_to_ast,
|
helpers::mod_path_to_ast,
|
||||||
imports::{
|
imports::{
|
||||||
import_assets::NameToImport,
|
import_assets::NameToImport,
|
||||||
insert_use::{self, ImportScope},
|
insert_use::{self, ImportScope},
|
||||||
},
|
},
|
||||||
items_locator, FilePosition, RootDatabase,
|
items_locator,
|
||||||
|
syntax_helpers::tree_diff::diff,
|
||||||
|
FilePosition, RootDatabase,
|
||||||
};
|
};
|
||||||
use syntax::algo;
|
|
||||||
use text_edit::TextEdit;
|
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
completions::Completions,
|
completions::Completions,
|
||||||
|
@ -297,6 +298,6 @@ pub fn resolve_completion_edits(
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
algo::diff(scope.as_syntax_node(), new_ast.as_syntax_node()).into_text_edit(&mut import_insert);
|
diff(scope.as_syntax_node(), new_ast.as_syntax_node()).into_text_edit(&mut import_insert);
|
||||||
Some(vec![import_insert.finish()])
|
Some(vec![import_insert.finish()])
|
||||||
}
|
}
|
||||||
|
|
|
@ -11,6 +11,7 @@ pub(crate) mod union_literal;
|
||||||
pub(crate) mod variant;
|
pub(crate) mod variant;
|
||||||
|
|
||||||
use hir::{sym, AsAssocItem, HasAttrs, HirDisplay, ModuleDef, ScopeDef, Type};
|
use hir::{sym, AsAssocItem, HasAttrs, HirDisplay, ModuleDef, ScopeDef, Type};
|
||||||
|
use ide_db::text_edit::TextEdit;
|
||||||
use ide_db::{
|
use ide_db::{
|
||||||
documentation::{Documentation, HasDocs},
|
documentation::{Documentation, HasDocs},
|
||||||
helpers::item_name,
|
helpers::item_name,
|
||||||
|
@ -18,7 +19,6 @@ use ide_db::{
|
||||||
RootDatabase, SnippetCap, SymbolKind,
|
RootDatabase, SnippetCap, SymbolKind,
|
||||||
};
|
};
|
||||||
use syntax::{ast, format_smolstr, AstNode, Edition, SmolStr, SyntaxKind, TextRange, ToSmolStr};
|
use syntax::{ast, format_smolstr, AstNode, Edition, SmolStr, SyntaxKind, TextRange, ToSmolStr};
|
||||||
use text_edit::TextEdit;
|
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
context::{DotAccess, DotAccessKind, PathCompletionCtx, PathKind, PatternContext},
|
context::{DotAccess, DotAccessKind, PathCompletionCtx, PathKind, PatternContext},
|
||||||
|
|
|
@ -35,7 +35,6 @@ parser.workspace = true
|
||||||
profile.workspace = true
|
profile.workspace = true
|
||||||
stdx.workspace = true
|
stdx.workspace = true
|
||||||
syntax.workspace = true
|
syntax.workspace = true
|
||||||
text-edit.workspace = true
|
|
||||||
span.workspace = true
|
span.workspace = true
|
||||||
# ide should depend only on the top-level `hir` package. if you need
|
# ide should depend only on the top-level `hir` package. if you need
|
||||||
# something from some `hir-xxx` subpackage, reexport the API via `hir`.
|
# something from some `hir-xxx` subpackage, reexport the API via `hir`.
|
||||||
|
|
|
@ -5,11 +5,11 @@ use hir::{
|
||||||
resolve_doc_path_on, sym, AttrId, AttrSourceMap, AttrsWithOwner, HasAttrs, InFile,
|
resolve_doc_path_on, sym, AttrId, AttrSourceMap, AttrsWithOwner, HasAttrs, InFile,
|
||||||
};
|
};
|
||||||
use itertools::Itertools;
|
use itertools::Itertools;
|
||||||
|
use span::{TextRange, TextSize};
|
||||||
use syntax::{
|
use syntax::{
|
||||||
ast::{self, IsString},
|
ast::{self, IsString},
|
||||||
AstToken,
|
AstToken,
|
||||||
};
|
};
|
||||||
use text_edit::{TextRange, TextSize};
|
|
||||||
|
|
||||||
/// Holds documentation
|
/// Holds documentation
|
||||||
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
|
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
|
||||||
|
|
|
@ -19,6 +19,7 @@ pub mod rust_doc;
|
||||||
pub mod search;
|
pub mod search;
|
||||||
pub mod source_change;
|
pub mod source_change;
|
||||||
pub mod symbol_index;
|
pub mod symbol_index;
|
||||||
|
pub mod text_edit;
|
||||||
pub mod traits;
|
pub mod traits;
|
||||||
pub mod ty_filter;
|
pub mod ty_filter;
|
||||||
pub mod use_trivial_constructor;
|
pub mod use_trivial_constructor;
|
||||||
|
@ -36,6 +37,7 @@ pub mod generated {
|
||||||
pub mod syntax_helpers {
|
pub mod syntax_helpers {
|
||||||
pub mod format_string;
|
pub mod format_string;
|
||||||
pub mod format_string_exprs;
|
pub mod format_string_exprs;
|
||||||
|
pub mod tree_diff;
|
||||||
pub use hir::prettify_macro_expansion;
|
pub use hir::prettify_macro_expansion;
|
||||||
pub mod node_ext;
|
pub mod node_ext;
|
||||||
pub mod suggest_name;
|
pub mod suggest_name;
|
||||||
|
|
|
@ -22,6 +22,7 @@
|
||||||
//! Our current behavior is ¯\_(ツ)_/¯.
|
//! Our current behavior is ¯\_(ツ)_/¯.
|
||||||
use std::fmt;
|
use std::fmt;
|
||||||
|
|
||||||
|
use crate::text_edit::{TextEdit, TextEditBuilder};
|
||||||
use base_db::AnchoredPathBuf;
|
use base_db::AnchoredPathBuf;
|
||||||
use either::Either;
|
use either::Either;
|
||||||
use hir::{FieldSource, FileRange, HirFileIdExt, InFile, ModuleSource, Semantics};
|
use hir::{FieldSource, FileRange, HirFileIdExt, InFile, ModuleSource, Semantics};
|
||||||
|
@ -32,7 +33,6 @@ use syntax::{
|
||||||
utils::is_raw_identifier,
|
utils::is_raw_identifier,
|
||||||
AstNode, SyntaxKind, TextRange, T,
|
AstNode, SyntaxKind, TextRange, T,
|
||||||
};
|
};
|
||||||
use text_edit::{TextEdit, TextEditBuilder};
|
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
defs::Definition,
|
defs::Definition,
|
||||||
|
|
|
@ -5,7 +5,8 @@
|
||||||
|
|
||||||
use std::{collections::hash_map::Entry, iter, mem};
|
use std::{collections::hash_map::Entry, iter, mem};
|
||||||
|
|
||||||
use crate::{assists::Command, SnippetCap};
|
use crate::text_edit::{TextEdit, TextEditBuilder};
|
||||||
|
use crate::{assists::Command, syntax_helpers::tree_diff::diff, SnippetCap};
|
||||||
use base_db::AnchoredPathBuf;
|
use base_db::AnchoredPathBuf;
|
||||||
use itertools::Itertools;
|
use itertools::Itertools;
|
||||||
use nohash_hasher::IntMap;
|
use nohash_hasher::IntMap;
|
||||||
|
@ -13,11 +14,9 @@ use rustc_hash::FxHashMap;
|
||||||
use span::FileId;
|
use span::FileId;
|
||||||
use stdx::never;
|
use stdx::never;
|
||||||
use syntax::{
|
use syntax::{
|
||||||
algo,
|
|
||||||
syntax_editor::{SyntaxAnnotation, SyntaxEditor},
|
syntax_editor::{SyntaxAnnotation, SyntaxEditor},
|
||||||
AstNode, SyntaxElement, SyntaxNode, SyntaxNodePtr, SyntaxToken, TextRange, TextSize,
|
AstNode, SyntaxElement, SyntaxNode, SyntaxNodePtr, SyntaxToken, TextRange, TextSize,
|
||||||
};
|
};
|
||||||
use text_edit::{TextEdit, TextEditBuilder};
|
|
||||||
|
|
||||||
#[derive(Default, Debug, Clone)]
|
#[derive(Default, Debug, Clone)]
|
||||||
pub struct SourceChange {
|
pub struct SourceChange {
|
||||||
|
@ -315,7 +314,7 @@ impl SourceChangeBuilder {
|
||||||
}
|
}
|
||||||
|
|
||||||
let mut edit = TextEdit::builder();
|
let mut edit = TextEdit::builder();
|
||||||
algo::diff(edit_result.old_root(), edit_result.new_root()).into_text_edit(&mut edit);
|
diff(edit_result.old_root(), edit_result.new_root()).into_text_edit(&mut edit);
|
||||||
let edit = edit.finish();
|
let edit = edit.finish();
|
||||||
|
|
||||||
let snippet_edit =
|
let snippet_edit =
|
||||||
|
@ -334,7 +333,7 @@ impl SourceChangeBuilder {
|
||||||
});
|
});
|
||||||
|
|
||||||
if let Some(tm) = self.mutated_tree.take() {
|
if let Some(tm) = self.mutated_tree.take() {
|
||||||
algo::diff(&tm.immutable, &tm.mutable_clone).into_text_edit(&mut self.edit);
|
diff(&tm.immutable, &tm.mutable_clone).into_text_edit(&mut self.edit);
|
||||||
}
|
}
|
||||||
|
|
||||||
let edit = mem::take(&mut self.edit).finish();
|
let edit = mem::take(&mut self.edit).finish();
|
||||||
|
@ -373,7 +372,7 @@ impl SourceChangeBuilder {
|
||||||
self.edit.replace(range, replace_with.into())
|
self.edit.replace(range, replace_with.into())
|
||||||
}
|
}
|
||||||
pub fn replace_ast<N: AstNode>(&mut self, old: N, new: N) {
|
pub fn replace_ast<N: AstNode>(&mut self, old: N, new: N) {
|
||||||
algo::diff(old.syntax(), new.syntax()).into_text_edit(&mut self.edit)
|
diff(old.syntax(), new.syntax()).into_text_edit(&mut self.edit)
|
||||||
}
|
}
|
||||||
pub fn create_file(&mut self, dst: AnchoredPathBuf, content: impl Into<String>) {
|
pub fn create_file(&mut self, dst: AnchoredPathBuf, content: impl Into<String>) {
|
||||||
let file_system_edit = FileSystemEdit::CreateFile { dst, initial_contents: content.into() };
|
let file_system_edit = FileSystemEdit::CreateFile { dst, initial_contents: content.into() };
|
||||||
|
|
559
crates/ide-db/src/syntax_helpers/tree_diff.rs
Normal file
559
crates/ide-db/src/syntax_helpers/tree_diff.rs
Normal file
|
@ -0,0 +1,559 @@
|
||||||
|
//! Basic tree diffing functionality.
|
||||||
|
use rustc_hash::FxHashMap;
|
||||||
|
use syntax::{NodeOrToken, SyntaxElement, SyntaxNode};
|
||||||
|
|
||||||
|
use crate::{text_edit::TextEditBuilder, FxIndexMap};
|
||||||
|
|
||||||
|
#[derive(Debug, Hash, PartialEq, Eq)]
|
||||||
|
enum TreeDiffInsertPos {
|
||||||
|
After(SyntaxElement),
|
||||||
|
AsFirstChild(SyntaxElement),
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug)]
|
||||||
|
pub struct TreeDiff {
|
||||||
|
replacements: FxHashMap<SyntaxElement, SyntaxElement>,
|
||||||
|
deletions: Vec<SyntaxElement>,
|
||||||
|
// the vec as well as the indexmap are both here to preserve order
|
||||||
|
insertions: FxIndexMap<TreeDiffInsertPos, Vec<SyntaxElement>>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl TreeDiff {
|
||||||
|
pub fn into_text_edit(&self, builder: &mut TextEditBuilder) {
|
||||||
|
let _p = tracing::info_span!("into_text_edit").entered();
|
||||||
|
|
||||||
|
for (anchor, to) in &self.insertions {
|
||||||
|
let offset = match anchor {
|
||||||
|
TreeDiffInsertPos::After(it) => it.text_range().end(),
|
||||||
|
TreeDiffInsertPos::AsFirstChild(it) => it.text_range().start(),
|
||||||
|
};
|
||||||
|
to.iter().for_each(|to| builder.insert(offset, to.to_string()));
|
||||||
|
}
|
||||||
|
for (from, to) in &self.replacements {
|
||||||
|
builder.replace(from.text_range(), to.to_string());
|
||||||
|
}
|
||||||
|
for text_range in self.deletions.iter().map(SyntaxElement::text_range) {
|
||||||
|
builder.delete(text_range);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn is_empty(&self) -> bool {
|
||||||
|
self.replacements.is_empty() && self.deletions.is_empty() && self.insertions.is_empty()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Finds a (potentially minimal) diff, which, applied to `from`, will result in `to`.
|
||||||
|
///
|
||||||
|
/// Specifically, returns a structure that consists of a replacements, insertions and deletions
|
||||||
|
/// such that applying this map on `from` will result in `to`.
|
||||||
|
///
|
||||||
|
/// This function tries to find a fine-grained diff.
|
||||||
|
pub fn diff(from: &SyntaxNode, to: &SyntaxNode) -> TreeDiff {
|
||||||
|
let _p = tracing::info_span!("diff").entered();
|
||||||
|
|
||||||
|
let mut diff = TreeDiff {
|
||||||
|
replacements: FxHashMap::default(),
|
||||||
|
insertions: FxIndexMap::default(),
|
||||||
|
deletions: Vec::new(),
|
||||||
|
};
|
||||||
|
let (from, to) = (from.clone().into(), to.clone().into());
|
||||||
|
|
||||||
|
if !syntax_element_eq(&from, &to) {
|
||||||
|
go(&mut diff, from, to);
|
||||||
|
}
|
||||||
|
return diff;
|
||||||
|
|
||||||
|
fn syntax_element_eq(lhs: &SyntaxElement, rhs: &SyntaxElement) -> bool {
|
||||||
|
lhs.kind() == rhs.kind()
|
||||||
|
&& lhs.text_range().len() == rhs.text_range().len()
|
||||||
|
&& match (&lhs, &rhs) {
|
||||||
|
(NodeOrToken::Node(lhs), NodeOrToken::Node(rhs)) => {
|
||||||
|
lhs == rhs || lhs.text() == rhs.text()
|
||||||
|
}
|
||||||
|
(NodeOrToken::Token(lhs), NodeOrToken::Token(rhs)) => lhs.text() == rhs.text(),
|
||||||
|
_ => false,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// FIXME: this is horribly inefficient. I bet there's a cool algorithm to diff trees properly.
|
||||||
|
fn go(diff: &mut TreeDiff, lhs: SyntaxElement, rhs: SyntaxElement) {
|
||||||
|
let (lhs, rhs) = match lhs.as_node().zip(rhs.as_node()) {
|
||||||
|
Some((lhs, rhs)) => (lhs, rhs),
|
||||||
|
_ => {
|
||||||
|
cov_mark::hit!(diff_node_token_replace);
|
||||||
|
diff.replacements.insert(lhs, rhs);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
let mut look_ahead_scratch = Vec::default();
|
||||||
|
|
||||||
|
let mut rhs_children = rhs.children_with_tokens();
|
||||||
|
let mut lhs_children = lhs.children_with_tokens();
|
||||||
|
let mut last_lhs = None;
|
||||||
|
loop {
|
||||||
|
let lhs_child = lhs_children.next();
|
||||||
|
match (lhs_child.clone(), rhs_children.next()) {
|
||||||
|
(None, None) => break,
|
||||||
|
(None, Some(element)) => {
|
||||||
|
let insert_pos = match last_lhs.clone() {
|
||||||
|
Some(prev) => {
|
||||||
|
cov_mark::hit!(diff_insert);
|
||||||
|
TreeDiffInsertPos::After(prev)
|
||||||
|
}
|
||||||
|
// first iteration, insert into out parent as the first child
|
||||||
|
None => {
|
||||||
|
cov_mark::hit!(diff_insert_as_first_child);
|
||||||
|
TreeDiffInsertPos::AsFirstChild(lhs.clone().into())
|
||||||
|
}
|
||||||
|
};
|
||||||
|
diff.insertions.entry(insert_pos).or_default().push(element);
|
||||||
|
}
|
||||||
|
(Some(element), None) => {
|
||||||
|
cov_mark::hit!(diff_delete);
|
||||||
|
diff.deletions.push(element);
|
||||||
|
}
|
||||||
|
(Some(ref lhs_ele), Some(ref rhs_ele)) if syntax_element_eq(lhs_ele, rhs_ele) => {}
|
||||||
|
(Some(lhs_ele), Some(rhs_ele)) => {
|
||||||
|
// nodes differ, look for lhs_ele in rhs, if its found we can mark everything up
|
||||||
|
// until that element as insertions. This is important to keep the diff minimal
|
||||||
|
// in regards to insertions that have been actually done, this is important for
|
||||||
|
// use insertions as we do not want to replace the entire module node.
|
||||||
|
look_ahead_scratch.push(rhs_ele.clone());
|
||||||
|
let mut rhs_children_clone = rhs_children.clone();
|
||||||
|
let mut insert = false;
|
||||||
|
for rhs_child in &mut rhs_children_clone {
|
||||||
|
if syntax_element_eq(&lhs_ele, &rhs_child) {
|
||||||
|
cov_mark::hit!(diff_insertions);
|
||||||
|
insert = true;
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
look_ahead_scratch.push(rhs_child);
|
||||||
|
}
|
||||||
|
let drain = look_ahead_scratch.drain(..);
|
||||||
|
if insert {
|
||||||
|
let insert_pos = if let Some(prev) = last_lhs.clone().filter(|_| insert) {
|
||||||
|
TreeDiffInsertPos::After(prev)
|
||||||
|
} else {
|
||||||
|
cov_mark::hit!(insert_first_child);
|
||||||
|
TreeDiffInsertPos::AsFirstChild(lhs.clone().into())
|
||||||
|
};
|
||||||
|
|
||||||
|
diff.insertions.entry(insert_pos).or_default().extend(drain);
|
||||||
|
rhs_children = rhs_children_clone;
|
||||||
|
} else {
|
||||||
|
go(diff, lhs_ele, rhs_ele);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
last_lhs = lhs_child.or(last_lhs);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use expect_test::{expect, Expect};
|
||||||
|
use itertools::Itertools;
|
||||||
|
use parser::{Edition, SyntaxKind};
|
||||||
|
use syntax::{AstNode, SourceFile, SyntaxElement};
|
||||||
|
|
||||||
|
use crate::text_edit::TextEdit;
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn replace_node_token() {
|
||||||
|
cov_mark::check!(diff_node_token_replace);
|
||||||
|
check_diff(
|
||||||
|
r#"use node;"#,
|
||||||
|
r#"ident"#,
|
||||||
|
expect![[r#"
|
||||||
|
insertions:
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
replacements:
|
||||||
|
|
||||||
|
Line 0: Token(USE_KW@0..3 "use") -> ident
|
||||||
|
|
||||||
|
deletions:
|
||||||
|
|
||||||
|
Line 1: " "
|
||||||
|
Line 1: node
|
||||||
|
Line 1: ;
|
||||||
|
"#]],
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn replace_parent() {
|
||||||
|
cov_mark::check!(diff_insert_as_first_child);
|
||||||
|
check_diff(
|
||||||
|
r#""#,
|
||||||
|
r#"use foo::bar;"#,
|
||||||
|
expect![[r#"
|
||||||
|
insertions:
|
||||||
|
|
||||||
|
Line 0: AsFirstChild(Node(SOURCE_FILE@0..0))
|
||||||
|
-> use foo::bar;
|
||||||
|
|
||||||
|
replacements:
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
deletions:
|
||||||
|
|
||||||
|
|
||||||
|
"#]],
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn insert_last() {
|
||||||
|
cov_mark::check!(diff_insert);
|
||||||
|
check_diff(
|
||||||
|
r#"
|
||||||
|
use foo;
|
||||||
|
use bar;"#,
|
||||||
|
r#"
|
||||||
|
use foo;
|
||||||
|
use bar;
|
||||||
|
use baz;"#,
|
||||||
|
expect![[r#"
|
||||||
|
insertions:
|
||||||
|
|
||||||
|
Line 2: After(Node(USE@10..18))
|
||||||
|
-> "\n"
|
||||||
|
-> use baz;
|
||||||
|
|
||||||
|
replacements:
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
deletions:
|
||||||
|
|
||||||
|
|
||||||
|
"#]],
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn insert_middle() {
|
||||||
|
check_diff(
|
||||||
|
r#"
|
||||||
|
use foo;
|
||||||
|
use baz;"#,
|
||||||
|
r#"
|
||||||
|
use foo;
|
||||||
|
use bar;
|
||||||
|
use baz;"#,
|
||||||
|
expect![[r#"
|
||||||
|
insertions:
|
||||||
|
|
||||||
|
Line 2: After(Token(WHITESPACE@9..10 "\n"))
|
||||||
|
-> use bar;
|
||||||
|
-> "\n"
|
||||||
|
|
||||||
|
replacements:
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
deletions:
|
||||||
|
|
||||||
|
|
||||||
|
"#]],
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn insert_first() {
|
||||||
|
check_diff(
|
||||||
|
r#"
|
||||||
|
use bar;
|
||||||
|
use baz;"#,
|
||||||
|
r#"
|
||||||
|
use foo;
|
||||||
|
use bar;
|
||||||
|
use baz;"#,
|
||||||
|
expect![[r#"
|
||||||
|
insertions:
|
||||||
|
|
||||||
|
Line 0: After(Token(WHITESPACE@0..1 "\n"))
|
||||||
|
-> use foo;
|
||||||
|
-> "\n"
|
||||||
|
|
||||||
|
replacements:
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
deletions:
|
||||||
|
|
||||||
|
|
||||||
|
"#]],
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn first_child_insertion() {
|
||||||
|
cov_mark::check!(insert_first_child);
|
||||||
|
check_diff(
|
||||||
|
r#"fn main() {
|
||||||
|
stdi
|
||||||
|
}"#,
|
||||||
|
r#"use foo::bar;
|
||||||
|
|
||||||
|
fn main() {
|
||||||
|
stdi
|
||||||
|
}"#,
|
||||||
|
expect![[r#"
|
||||||
|
insertions:
|
||||||
|
|
||||||
|
Line 0: AsFirstChild(Node(SOURCE_FILE@0..30))
|
||||||
|
-> use foo::bar;
|
||||||
|
-> "\n\n "
|
||||||
|
|
||||||
|
replacements:
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
deletions:
|
||||||
|
|
||||||
|
|
||||||
|
"#]],
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn delete_last() {
|
||||||
|
cov_mark::check!(diff_delete);
|
||||||
|
check_diff(
|
||||||
|
r#"use foo;
|
||||||
|
use bar;"#,
|
||||||
|
r#"use foo;"#,
|
||||||
|
expect![[r#"
|
||||||
|
insertions:
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
replacements:
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
deletions:
|
||||||
|
|
||||||
|
Line 1: "\n "
|
||||||
|
Line 2: use bar;
|
||||||
|
"#]],
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn delete_middle() {
|
||||||
|
cov_mark::check!(diff_insertions);
|
||||||
|
check_diff(
|
||||||
|
r#"
|
||||||
|
use expect_test::{expect, Expect};
|
||||||
|
use text_edit::TextEdit;
|
||||||
|
|
||||||
|
use crate::AstNode;
|
||||||
|
"#,
|
||||||
|
r#"
|
||||||
|
use expect_test::{expect, Expect};
|
||||||
|
|
||||||
|
use crate::AstNode;
|
||||||
|
"#,
|
||||||
|
expect![[r#"
|
||||||
|
insertions:
|
||||||
|
|
||||||
|
Line 1: After(Node(USE@1..35))
|
||||||
|
-> "\n\n"
|
||||||
|
-> use crate::AstNode;
|
||||||
|
|
||||||
|
replacements:
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
deletions:
|
||||||
|
|
||||||
|
Line 2: use text_edit::TextEdit;
|
||||||
|
Line 3: "\n\n"
|
||||||
|
Line 4: use crate::AstNode;
|
||||||
|
Line 5: "\n"
|
||||||
|
"#]],
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn delete_first() {
|
||||||
|
check_diff(
|
||||||
|
r#"
|
||||||
|
use text_edit::TextEdit;
|
||||||
|
|
||||||
|
use crate::AstNode;
|
||||||
|
"#,
|
||||||
|
r#"
|
||||||
|
use crate::AstNode;
|
||||||
|
"#,
|
||||||
|
expect![[r#"
|
||||||
|
insertions:
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
replacements:
|
||||||
|
|
||||||
|
Line 2: Token(IDENT@5..14 "text_edit") -> crate
|
||||||
|
Line 2: Token(IDENT@16..24 "TextEdit") -> AstNode
|
||||||
|
Line 2: Token(WHITESPACE@25..27 "\n\n") -> "\n"
|
||||||
|
|
||||||
|
deletions:
|
||||||
|
|
||||||
|
Line 3: use crate::AstNode;
|
||||||
|
Line 4: "\n"
|
||||||
|
"#]],
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn merge_use() {
|
||||||
|
check_diff(
|
||||||
|
r#"
|
||||||
|
use std::{
|
||||||
|
fmt,
|
||||||
|
hash::BuildHasherDefault,
|
||||||
|
ops::{self, RangeInclusive},
|
||||||
|
};
|
||||||
|
"#,
|
||||||
|
r#"
|
||||||
|
use std::fmt;
|
||||||
|
use std::hash::BuildHasherDefault;
|
||||||
|
use std::ops::{self, RangeInclusive};
|
||||||
|
"#,
|
||||||
|
expect![[r#"
|
||||||
|
insertions:
|
||||||
|
|
||||||
|
Line 2: After(Node(PATH_SEGMENT@5..8))
|
||||||
|
-> ::
|
||||||
|
-> fmt
|
||||||
|
Line 6: After(Token(WHITESPACE@86..87 "\n"))
|
||||||
|
-> use std::hash::BuildHasherDefault;
|
||||||
|
-> "\n"
|
||||||
|
-> use std::ops::{self, RangeInclusive};
|
||||||
|
-> "\n"
|
||||||
|
|
||||||
|
replacements:
|
||||||
|
|
||||||
|
Line 2: Token(IDENT@5..8 "std") -> std
|
||||||
|
|
||||||
|
deletions:
|
||||||
|
|
||||||
|
Line 2: ::
|
||||||
|
Line 2: {
|
||||||
|
fmt,
|
||||||
|
hash::BuildHasherDefault,
|
||||||
|
ops::{self, RangeInclusive},
|
||||||
|
}
|
||||||
|
"#]],
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn early_return_assist() {
|
||||||
|
check_diff(
|
||||||
|
r#"
|
||||||
|
fn main() {
|
||||||
|
if let Ok(x) = Err(92) {
|
||||||
|
foo(x);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
"#,
|
||||||
|
r#"
|
||||||
|
fn main() {
|
||||||
|
let x = match Err(92) {
|
||||||
|
Ok(it) => it,
|
||||||
|
_ => return,
|
||||||
|
};
|
||||||
|
foo(x);
|
||||||
|
}
|
||||||
|
"#,
|
||||||
|
expect![[r#"
|
||||||
|
insertions:
|
||||||
|
|
||||||
|
Line 3: After(Node(BLOCK_EXPR@40..63))
|
||||||
|
-> " "
|
||||||
|
-> match Err(92) {
|
||||||
|
Ok(it) => it,
|
||||||
|
_ => return,
|
||||||
|
}
|
||||||
|
-> ;
|
||||||
|
Line 3: After(Node(IF_EXPR@17..63))
|
||||||
|
-> "\n "
|
||||||
|
-> foo(x);
|
||||||
|
|
||||||
|
replacements:
|
||||||
|
|
||||||
|
Line 3: Token(IF_KW@17..19 "if") -> let
|
||||||
|
Line 3: Token(LET_KW@20..23 "let") -> x
|
||||||
|
Line 3: Node(BLOCK_EXPR@40..63) -> =
|
||||||
|
|
||||||
|
deletions:
|
||||||
|
|
||||||
|
Line 3: " "
|
||||||
|
Line 3: Ok(x)
|
||||||
|
Line 3: " "
|
||||||
|
Line 3: =
|
||||||
|
Line 3: " "
|
||||||
|
Line 3: Err(92)
|
||||||
|
"#]],
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn check_diff(from: &str, to: &str, expected_diff: Expect) {
|
||||||
|
let from_node = SourceFile::parse(from, Edition::CURRENT).tree().syntax().clone();
|
||||||
|
let to_node = SourceFile::parse(to, Edition::CURRENT).tree().syntax().clone();
|
||||||
|
let diff = super::diff(&from_node, &to_node);
|
||||||
|
|
||||||
|
let line_number =
|
||||||
|
|syn: &SyntaxElement| from[..syn.text_range().start().into()].lines().count();
|
||||||
|
|
||||||
|
let fmt_syntax = |syn: &SyntaxElement| match syn.kind() {
|
||||||
|
SyntaxKind::WHITESPACE => format!("{:?}", syn.to_string()),
|
||||||
|
_ => format!("{syn}"),
|
||||||
|
};
|
||||||
|
|
||||||
|
let insertions =
|
||||||
|
diff.insertions.iter().format_with("\n", |(k, v), f| -> Result<(), std::fmt::Error> {
|
||||||
|
f(&format!(
|
||||||
|
"Line {}: {:?}\n-> {}",
|
||||||
|
line_number(match k {
|
||||||
|
super::TreeDiffInsertPos::After(syn) => syn,
|
||||||
|
super::TreeDiffInsertPos::AsFirstChild(syn) => syn,
|
||||||
|
}),
|
||||||
|
k,
|
||||||
|
v.iter().format_with("\n-> ", |v, f| f(&fmt_syntax(v)))
|
||||||
|
))
|
||||||
|
});
|
||||||
|
|
||||||
|
let replacements = diff
|
||||||
|
.replacements
|
||||||
|
.iter()
|
||||||
|
.sorted_by_key(|(syntax, _)| syntax.text_range().start())
|
||||||
|
.format_with("\n", |(k, v), f| {
|
||||||
|
f(&format!("Line {}: {k:?} -> {}", line_number(k), fmt_syntax(v)))
|
||||||
|
});
|
||||||
|
|
||||||
|
let deletions = diff
|
||||||
|
.deletions
|
||||||
|
.iter()
|
||||||
|
.format_with("\n", |v, f| f(&format!("Line {}: {}", line_number(v), fmt_syntax(v))));
|
||||||
|
|
||||||
|
let actual = format!(
|
||||||
|
"insertions:\n\n{insertions}\n\nreplacements:\n\n{replacements}\n\ndeletions:\n\n{deletions}\n"
|
||||||
|
);
|
||||||
|
expected_diff.assert_eq(&actual);
|
||||||
|
|
||||||
|
let mut from = from.to_owned();
|
||||||
|
let mut text_edit = TextEdit::builder();
|
||||||
|
diff.into_text_edit(&mut text_edit);
|
||||||
|
text_edit.finish().apply(&mut from);
|
||||||
|
assert_eq!(&*from, to, "diff did not turn `from` to `to`");
|
||||||
|
}
|
||||||
|
}
|
|
@ -5,8 +5,8 @@
|
||||||
//! rust-analyzer.
|
//! rust-analyzer.
|
||||||
|
|
||||||
use itertools::Itertools;
|
use itertools::Itertools;
|
||||||
|
pub use span::{TextRange, TextSize};
|
||||||
use std::cmp::max;
|
use std::cmp::max;
|
||||||
pub use text_size::{TextRange, TextSize};
|
|
||||||
|
|
||||||
/// `InsertDelete` -- a single "atomic" change to text
|
/// `InsertDelete` -- a single "atomic" change to text
|
||||||
///
|
///
|
|
@ -22,7 +22,6 @@ tracing.workspace = true
|
||||||
# local deps
|
# local deps
|
||||||
stdx.workspace = true
|
stdx.workspace = true
|
||||||
syntax.workspace = true
|
syntax.workspace = true
|
||||||
text-edit.workspace = true
|
|
||||||
cfg.workspace = true
|
cfg.workspace = true
|
||||||
hir.workspace = true
|
hir.workspace = true
|
||||||
ide-db.workspace = true
|
ide-db.workspace = true
|
||||||
|
|
|
@ -1,9 +1,9 @@
|
||||||
//! Suggests shortening `Foo { field: field }` to `Foo { field }` in both
|
//! Suggests shortening `Foo { field: field }` to `Foo { field }` in both
|
||||||
//! expressions and patterns.
|
//! expressions and patterns.
|
||||||
|
|
||||||
|
use ide_db::text_edit::TextEdit;
|
||||||
use ide_db::{source_change::SourceChange, EditionedFileId, FileRange};
|
use ide_db::{source_change::SourceChange, EditionedFileId, FileRange};
|
||||||
use syntax::{ast, match_ast, AstNode, SyntaxNode};
|
use syntax::{ast, match_ast, AstNode, SyntaxNode};
|
||||||
use text_edit::TextEdit;
|
|
||||||
|
|
||||||
use crate::{fix, Diagnostic, DiagnosticCode};
|
use crate::{fix, Diagnostic, DiagnosticCode};
|
||||||
|
|
||||||
|
|
|
@ -14,7 +14,7 @@ use syntax::{
|
||||||
ast::{self, make},
|
ast::{self, make},
|
||||||
Edition, SyntaxKind, SyntaxNode,
|
Edition, SyntaxKind, SyntaxNode,
|
||||||
};
|
};
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{fix, Diagnostic, DiagnosticCode, DiagnosticsConfig, Severity};
|
use crate::{fix, Diagnostic, DiagnosticCode, DiagnosticsConfig, Severity};
|
||||||
|
|
||||||
|
|
|
@ -5,15 +5,14 @@ use hir::{
|
||||||
};
|
};
|
||||||
use ide_db::{
|
use ide_db::{
|
||||||
assists::Assist, famous_defs::FamousDefs, imports::import_assets::item_for_path_search,
|
assists::Assist, famous_defs::FamousDefs, imports::import_assets::item_for_path_search,
|
||||||
source_change::SourceChange, use_trivial_constructor::use_trivial_constructor, FxHashMap,
|
source_change::SourceChange, syntax_helpers::tree_diff::diff, text_edit::TextEdit,
|
||||||
|
use_trivial_constructor::use_trivial_constructor, FxHashMap,
|
||||||
};
|
};
|
||||||
use stdx::format_to;
|
use stdx::format_to;
|
||||||
use syntax::{
|
use syntax::{
|
||||||
algo,
|
|
||||||
ast::{self, make},
|
ast::{self, make},
|
||||||
AstNode, Edition, SyntaxNode, SyntaxNodePtr, ToSmolStr,
|
AstNode, Edition, SyntaxNode, SyntaxNodePtr, ToSmolStr,
|
||||||
};
|
};
|
||||||
use text_edit::TextEdit;
|
|
||||||
|
|
||||||
use crate::{fix, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
use crate::{fix, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
||||||
|
|
||||||
|
@ -77,7 +76,7 @@ fn fixes(ctx: &DiagnosticsContext<'_>, d: &hir::MissingFields) -> Option<Vec<Ass
|
||||||
// FIXME: this also currently discards a lot of whitespace in the input... we really need a formatter here
|
// FIXME: this also currently discards a lot of whitespace in the input... we really need a formatter here
|
||||||
builder.replace(old_range.range, new_syntax.to_string());
|
builder.replace(old_range.range, new_syntax.to_string());
|
||||||
} else {
|
} else {
|
||||||
algo::diff(old_syntax, new_syntax).into_text_edit(&mut builder);
|
diff(old_syntax, new_syntax).into_text_edit(&mut builder);
|
||||||
}
|
}
|
||||||
builder.finish()
|
builder.finish()
|
||||||
};
|
};
|
||||||
|
|
|
@ -3,7 +3,7 @@ use hir::HirFileIdExt;
|
||||||
use ide_db::{assists::Assist, source_change::SourceChange};
|
use ide_db::{assists::Assist, source_change::SourceChange};
|
||||||
use syntax::{ast, SyntaxNode};
|
use syntax::{ast, SyntaxNode};
|
||||||
use syntax::{match_ast, AstNode};
|
use syntax::{match_ast, AstNode};
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{fix, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
use crate::{fix, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
||||||
|
|
||||||
|
|
|
@ -1,7 +1,7 @@
|
||||||
use hir::db::ExpandDatabase;
|
use hir::db::ExpandDatabase;
|
||||||
use ide_db::source_change::SourceChange;
|
use ide_db::source_change::SourceChange;
|
||||||
use syntax::{ast, AstNode, SyntaxKind, SyntaxNode, SyntaxNodePtr, SyntaxToken, T};
|
use syntax::{ast, AstNode, SyntaxKind, SyntaxNode, SyntaxNodePtr, SyntaxToken, T};
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{fix, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
use crate::{fix, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
||||||
|
|
||||||
|
|
|
@ -5,7 +5,7 @@ use syntax::{
|
||||||
ast::{self, edit::IndentLevel, make},
|
ast::{self, edit::IndentLevel, make},
|
||||||
AstNode,
|
AstNode,
|
||||||
};
|
};
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{fix, Assist, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
use crate::{fix, Assist, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
||||||
|
|
||||||
|
|
|
@ -1,7 +1,7 @@
|
||||||
use hir::{db::ExpandDatabase, diagnostics::RemoveTrailingReturn, FileRange};
|
use hir::{db::ExpandDatabase, diagnostics::RemoveTrailingReturn, FileRange};
|
||||||
use ide_db::{assists::Assist, source_change::SourceChange};
|
use ide_db::{assists::Assist, source_change::SourceChange};
|
||||||
use syntax::{ast, AstNode};
|
use syntax::{ast, AstNode};
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{adjusted_display_range, fix, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
use crate::{adjusted_display_range, fix, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
||||||
|
|
||||||
|
|
|
@ -8,7 +8,7 @@ use syntax::{
|
||||||
},
|
},
|
||||||
AstNode, SyntaxToken, TextRange,
|
AstNode, SyntaxToken, TextRange,
|
||||||
};
|
};
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
adjusted_display_range, fix, Diagnostic, DiagnosticCode, DiagnosticsContext, Severity,
|
adjusted_display_range, fix, Diagnostic, DiagnosticCode, DiagnosticsContext, Severity,
|
||||||
|
|
|
@ -4,7 +4,7 @@ use syntax::{
|
||||||
ast::{self, HasArgList},
|
ast::{self, HasArgList},
|
||||||
AstNode, TextRange,
|
AstNode, TextRange,
|
||||||
};
|
};
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{fix, Assist, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
use crate::{fix, Assist, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
||||||
|
|
||||||
|
|
|
@ -5,7 +5,7 @@ use ide_db::{
|
||||||
source_change::SourceChangeBuilder,
|
source_change::SourceChangeBuilder,
|
||||||
};
|
};
|
||||||
use syntax::ToSmolStr;
|
use syntax::ToSmolStr;
|
||||||
use text_edit::TextRange;
|
use ide_db::text_edit::TextRange;
|
||||||
|
|
||||||
use crate::{Diagnostic, DiagnosticCode, DiagnosticsContext};
|
use crate::{Diagnostic, DiagnosticCode, DiagnosticsContext};
|
||||||
|
|
||||||
|
|
|
@ -9,7 +9,7 @@ use syntax::{
|
||||||
},
|
},
|
||||||
AstNode, AstPtr, TextSize,
|
AstNode, AstPtr, TextSize,
|
||||||
};
|
};
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{adjusted_display_range, fix, Assist, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
use crate::{adjusted_display_range, fix, Assist, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
||||||
|
|
||||||
|
|
|
@ -9,7 +9,7 @@ use ide_db::{
|
||||||
source_change::SourceChange,
|
source_change::SourceChange,
|
||||||
};
|
};
|
||||||
use itertools::Itertools;
|
use itertools::Itertools;
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{Diagnostic, DiagnosticCode, DiagnosticsContext};
|
use crate::{Diagnostic, DiagnosticCode, DiagnosticsContext};
|
||||||
|
|
||||||
|
|
|
@ -13,7 +13,7 @@ use syntax::{
|
||||||
ast::{self, edit::IndentLevel, HasModuleItem, HasName},
|
ast::{self, edit::IndentLevel, HasModuleItem, HasName},
|
||||||
AstNode, TextRange,
|
AstNode, TextRange,
|
||||||
};
|
};
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{fix, Assist, Diagnostic, DiagnosticCode, DiagnosticsContext, Severity};
|
use crate::{fix, Assist, Diagnostic, DiagnosticCode, DiagnosticsContext, Severity};
|
||||||
|
|
||||||
|
|
|
@ -16,7 +16,7 @@ use syntax::{
|
||||||
ast::{edit::AstNodeEdit, Type},
|
ast::{edit::AstNodeEdit, Type},
|
||||||
SyntaxNode,
|
SyntaxNode,
|
||||||
};
|
};
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{adjusted_display_range, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
use crate::{adjusted_display_range, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
||||||
|
|
||||||
|
|
|
@ -8,7 +8,7 @@ use syntax::{
|
||||||
ast::{self, make, HasArgList},
|
ast::{self, make, HasArgList},
|
||||||
format_smolstr, AstNode, SmolStr, TextRange, ToSmolStr,
|
format_smolstr, AstNode, SmolStr, TextRange, ToSmolStr,
|
||||||
};
|
};
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{adjusted_display_range, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
use crate::{adjusted_display_range, Diagnostic, DiagnosticCode, DiagnosticsContext};
|
||||||
|
|
||||||
|
|
|
@ -6,7 +6,7 @@ use ide_db::{
|
||||||
FileRange, RootDatabase,
|
FileRange, RootDatabase,
|
||||||
};
|
};
|
||||||
use syntax::{Edition, TextRange};
|
use syntax::{Edition, TextRange};
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{Diagnostic, DiagnosticCode, DiagnosticsContext};
|
use crate::{Diagnostic, DiagnosticCode, DiagnosticsContext};
|
||||||
|
|
||||||
|
|
|
@ -1,8 +1,8 @@
|
||||||
use hir::InFile;
|
use hir::InFile;
|
||||||
|
use ide_db::text_edit::TextEdit;
|
||||||
use ide_db::{source_change::SourceChange, EditionedFileId, FileRange};
|
use ide_db::{source_change::SourceChange, EditionedFileId, FileRange};
|
||||||
use itertools::Itertools;
|
use itertools::Itertools;
|
||||||
use syntax::{ast, AstNode, SyntaxNode, SyntaxNodePtr};
|
use syntax::{ast, AstNode, SyntaxNode, SyntaxNodePtr};
|
||||||
use text_edit::TextEdit;
|
|
||||||
|
|
||||||
use crate::{fix, Diagnostic, DiagnosticCode};
|
use crate::{fix, Diagnostic, DiagnosticCode};
|
||||||
|
|
||||||
|
|
|
@ -24,7 +24,6 @@ ide-db.workspace = true
|
||||||
parser.workspace = true
|
parser.workspace = true
|
||||||
stdx.workspace = true
|
stdx.workspace = true
|
||||||
syntax.workspace = true
|
syntax.workspace = true
|
||||||
text-edit.workspace = true
|
|
||||||
|
|
||||||
[dev-dependencies]
|
[dev-dependencies]
|
||||||
expect-test = "1.4.0"
|
expect-test = "1.4.0"
|
||||||
|
@ -34,4 +33,4 @@ test-utils.workspace = true
|
||||||
test-fixture.workspace = true
|
test-fixture.workspace = true
|
||||||
|
|
||||||
[lints]
|
[lints]
|
||||||
workspace = true
|
workspace = true
|
||||||
|
|
|
@ -84,10 +84,10 @@ pub use crate::{errors::SsrError, from_comment::ssr_from_comment, matching::Matc
|
||||||
|
|
||||||
use crate::{errors::bail, matching::MatchFailureReason};
|
use crate::{errors::bail, matching::MatchFailureReason};
|
||||||
use hir::{FileRange, Semantics};
|
use hir::{FileRange, Semantics};
|
||||||
|
use ide_db::text_edit::TextEdit;
|
||||||
use ide_db::{base_db::SourceDatabase, EditionedFileId, FileId, FxHashMap, RootDatabase};
|
use ide_db::{base_db::SourceDatabase, EditionedFileId, FileId, FxHashMap, RootDatabase};
|
||||||
use resolving::ResolvedRule;
|
use resolving::ResolvedRule;
|
||||||
use syntax::{ast, AstNode, SyntaxNode, TextRange};
|
use syntax::{ast, AstNode, SyntaxNode, TextRange};
|
||||||
use text_edit::TextEdit;
|
|
||||||
|
|
||||||
// A structured search replace rule. Create by calling `parse` on a str.
|
// A structured search replace rule. Create by calling `parse` on a str.
|
||||||
#[derive(Debug)]
|
#[derive(Debug)]
|
||||||
|
|
|
@ -1,5 +1,6 @@
|
||||||
//! Code for applying replacement templates for matches that have previously been found.
|
//! Code for applying replacement templates for matches that have previously been found.
|
||||||
|
|
||||||
|
use ide_db::text_edit::TextEdit;
|
||||||
use ide_db::{FxHashMap, FxHashSet};
|
use ide_db::{FxHashMap, FxHashSet};
|
||||||
use itertools::Itertools;
|
use itertools::Itertools;
|
||||||
use parser::Edition;
|
use parser::Edition;
|
||||||
|
@ -7,7 +8,6 @@ use syntax::{
|
||||||
ast::{self, AstNode, AstToken},
|
ast::{self, AstNode, AstToken},
|
||||||
SyntaxElement, SyntaxKind, SyntaxNode, SyntaxToken, TextRange, TextSize,
|
SyntaxElement, SyntaxKind, SyntaxNode, SyntaxToken, TextRange, TextSize,
|
||||||
};
|
};
|
||||||
use text_edit::TextEdit;
|
|
||||||
|
|
||||||
use crate::{fragments, resolving::ResolvedRule, Match, SsrMatches};
|
use crate::{fragments, resolving::ResolvedRule, Match, SsrMatches};
|
||||||
|
|
||||||
|
|
|
@ -39,7 +39,6 @@ profile.workspace = true
|
||||||
stdx.workspace = true
|
stdx.workspace = true
|
||||||
syntax.workspace = true
|
syntax.workspace = true
|
||||||
span.workspace = true
|
span.workspace = true
|
||||||
text-edit.workspace = true
|
|
||||||
# ide should depend only on the top-level `hir` package. if you need
|
# ide should depend only on the top-level `hir` package. if you need
|
||||||
# something from some `hir-xxx` subpackage, reexport the API via `hir`.
|
# something from some `hir-xxx` subpackage, reexport the API via `hir`.
|
||||||
hir.workspace = true
|
hir.workspace = true
|
||||||
|
|
|
@ -17,7 +17,7 @@ use syntax::{
|
||||||
ast::{self, AstNode, HasGenericParams},
|
ast::{self, AstNode, HasGenericParams},
|
||||||
format_smolstr, match_ast, SmolStr, SyntaxNode, TextRange, TextSize, WalkEvent,
|
format_smolstr, match_ast, SmolStr, SyntaxNode, TextRange, TextSize, WalkEvent,
|
||||||
};
|
};
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{navigation_target::TryToNav, FileId};
|
use crate::{navigation_target::TryToNav, FileId};
|
||||||
|
|
||||||
|
|
|
@ -17,7 +17,7 @@ use syntax::{
|
||||||
ast::{self, make, AstNode},
|
ast::{self, make, AstNode},
|
||||||
ted,
|
ted,
|
||||||
};
|
};
|
||||||
use text_edit::TextEditBuilder;
|
use ide_db::text_edit::TextEditBuilder;
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
AdjustmentHints, AdjustmentHintsMode, InlayHint, InlayHintLabel, InlayHintLabelPart,
|
AdjustmentHints, AdjustmentHintsMode, InlayHint, InlayHintLabel, InlayHintLabelPart,
|
||||||
|
|
|
@ -9,7 +9,7 @@ use ide_db::famous_defs::FamousDefs;
|
||||||
|
|
||||||
use span::EditionedFileId;
|
use span::EditionedFileId;
|
||||||
use syntax::ast::{self, AstNode};
|
use syntax::ast::{self, AstNode};
|
||||||
use text_edit::TextEditBuilder;
|
use ide_db::text_edit::TextEditBuilder;
|
||||||
|
|
||||||
use crate::{InlayHint, InlayHintLabel, InlayHintPosition, InlayHintsConfig, InlayKind};
|
use crate::{InlayHint, InlayHintLabel, InlayHintPosition, InlayHintsConfig, InlayKind};
|
||||||
|
|
||||||
|
|
|
@ -77,7 +77,7 @@ pub(super) fn hints(
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use expect_test::{expect, Expect};
|
use expect_test::{expect, Expect};
|
||||||
use text_edit::{TextRange, TextSize};
|
use ide_db::text_edit::{TextRange, TextSize};
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
fixture,
|
fixture,
|
||||||
|
|
|
@ -5,7 +5,7 @@ use ide_db::famous_defs::FamousDefs;
|
||||||
use span::EditionedFileId;
|
use span::EditionedFileId;
|
||||||
use stdx::{never, TupleExt};
|
use stdx::{never, TupleExt};
|
||||||
use syntax::ast::{self, AstNode};
|
use syntax::ast::{self, AstNode};
|
||||||
use text_edit::{TextRange, TextSize};
|
use ide_db::text_edit::{TextRange, TextSize};
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
InlayHint, InlayHintLabel, InlayHintLabelPart, InlayHintPosition, InlayHintsConfig, InlayKind,
|
InlayHint, InlayHintLabel, InlayHintLabelPart, InlayHintPosition, InlayHintsConfig, InlayKind,
|
||||||
|
|
|
@ -8,7 +8,7 @@ use hir::Semantics;
|
||||||
use ide_db::{famous_defs::FamousDefs, RootDatabase};
|
use ide_db::{famous_defs::FamousDefs, RootDatabase};
|
||||||
use span::EditionedFileId;
|
use span::EditionedFileId;
|
||||||
use syntax::ast::{self, AstNode, HasName};
|
use syntax::ast::{self, AstNode, HasName};
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
DiscriminantHints, InlayHint, InlayHintLabel, InlayHintPosition, InlayHintsConfig, InlayKind,
|
DiscriminantHints, InlayHint, InlayHintLabel, InlayHintPosition, InlayHintsConfig, InlayKind,
|
||||||
|
|
|
@ -9,7 +9,7 @@ use syntax::{
|
||||||
ast::{self, AstNode},
|
ast::{self, AstNode},
|
||||||
SyntaxKind,
|
SyntaxKind,
|
||||||
};
|
};
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{InlayHint, InlayHintPosition, InlayHintsConfig, InlayKind, LifetimeElisionHints};
|
use crate::{InlayHint, InlayHintPosition, InlayHintsConfig, InlayKind, LifetimeElisionHints};
|
||||||
|
|
||||||
|
|
|
@ -8,7 +8,7 @@ use syntax::{
|
||||||
SyntaxToken, TextRange, TextSize, T,
|
SyntaxToken, TextRange, TextSize, T,
|
||||||
};
|
};
|
||||||
|
|
||||||
use text_edit::{TextEdit, TextEditBuilder};
|
use ide_db::text_edit::{TextEdit, TextEditBuilder};
|
||||||
|
|
||||||
pub struct JoinLinesConfig {
|
pub struct JoinLinesConfig {
|
||||||
pub join_else_if: bool,
|
pub join_else_if: bool,
|
||||||
|
|
|
@ -139,7 +139,7 @@ pub use ide_diagnostics::{
|
||||||
pub use ide_ssr::SsrError;
|
pub use ide_ssr::SsrError;
|
||||||
pub use span::Edition;
|
pub use span::Edition;
|
||||||
pub use syntax::{TextRange, TextSize};
|
pub use syntax::{TextRange, TextSize};
|
||||||
pub use text_edit::{Indel, TextEdit};
|
pub use ide_db::text_edit::{Indel, TextEdit};
|
||||||
|
|
||||||
pub type Cancellable<T> = Result<T, Cancelled>;
|
pub type Cancellable<T> = Result<T, Cancelled>;
|
||||||
|
|
||||||
|
|
|
@ -1,10 +1,11 @@
|
||||||
use std::{iter::once, mem};
|
use std::{iter::once, mem};
|
||||||
|
|
||||||
use hir::Semantics;
|
use hir::Semantics;
|
||||||
|
use ide_db::syntax_helpers::tree_diff::diff;
|
||||||
|
use ide_db::text_edit::{TextEdit, TextEditBuilder};
|
||||||
use ide_db::{helpers::pick_best_token, FileRange, RootDatabase};
|
use ide_db::{helpers::pick_best_token, FileRange, RootDatabase};
|
||||||
use itertools::Itertools;
|
use itertools::Itertools;
|
||||||
use syntax::{algo, ast, match_ast, AstNode, SyntaxElement, SyntaxKind, SyntaxNode, TextRange};
|
use syntax::{ast, match_ast, AstNode, SyntaxElement, SyntaxKind, SyntaxNode, TextRange};
|
||||||
use text_edit::{TextEdit, TextEditBuilder};
|
|
||||||
|
|
||||||
#[derive(Copy, Clone, Debug)]
|
#[derive(Copy, Clone, Debug)]
|
||||||
pub enum Direction {
|
pub enum Direction {
|
||||||
|
@ -166,7 +167,7 @@ fn replace_nodes<'a>(
|
||||||
|
|
||||||
let mut edit = TextEditBuilder::default();
|
let mut edit = TextEditBuilder::default();
|
||||||
|
|
||||||
algo::diff(first, second).into_text_edit(&mut edit);
|
diff(first, second).into_text_edit(&mut edit);
|
||||||
edit.replace(second.text_range(), first_with_cursor);
|
edit.replace(second.text_range(), first_with_cursor);
|
||||||
|
|
||||||
edit.finish()
|
edit.finish()
|
||||||
|
|
|
@ -15,7 +15,7 @@ use itertools::Itertools;
|
||||||
use stdx::{always, never};
|
use stdx::{always, never};
|
||||||
use syntax::{ast, AstNode, SyntaxKind, SyntaxNode, TextRange, TextSize};
|
use syntax::{ast, AstNode, SyntaxKind, SyntaxNode, TextRange, TextSize};
|
||||||
|
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::{FilePosition, RangeInfo, SourceChange};
|
use crate::{FilePosition, RangeInfo, SourceChange};
|
||||||
|
|
||||||
|
@ -449,9 +449,9 @@ fn text_edit_from_self_param(self_param: &ast::SelfParam, new_name: &str) -> Opt
|
||||||
mod tests {
|
mod tests {
|
||||||
use expect_test::{expect, Expect};
|
use expect_test::{expect, Expect};
|
||||||
use ide_db::source_change::SourceChange;
|
use ide_db::source_change::SourceChange;
|
||||||
|
use ide_db::text_edit::TextEdit;
|
||||||
use stdx::trim_indent;
|
use stdx::trim_indent;
|
||||||
use test_utils::assert_eq_text;
|
use test_utils::assert_eq_text;
|
||||||
use text_edit::TextEdit;
|
|
||||||
|
|
||||||
use crate::fixture;
|
use crate::fixture;
|
||||||
|
|
||||||
|
|
|
@ -23,7 +23,7 @@ use syntax::{
|
||||||
AstNode, Parse, SourceFile, SyntaxKind, TextRange, TextSize, T,
|
AstNode, Parse, SourceFile, SyntaxKind, TextRange, TextSize, T,
|
||||||
};
|
};
|
||||||
|
|
||||||
use text_edit::{Indel, TextEdit};
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
use crate::SourceChange;
|
use crate::SourceChange;
|
||||||
|
|
||||||
|
@ -126,7 +126,7 @@ fn on_opening_bracket_typed(
|
||||||
return None;
|
return None;
|
||||||
}
|
}
|
||||||
// FIXME: Edition
|
// FIXME: Edition
|
||||||
let file = file.reparse(&Indel::delete(range), span::Edition::CURRENT_FIXME);
|
let file = file.reparse(range, "", span::Edition::CURRENT_FIXME);
|
||||||
|
|
||||||
if let Some(edit) = bracket_expr(&file.tree(), offset, opening_bracket, closing_bracket) {
|
if let Some(edit) = bracket_expr(&file.tree(), offset, opening_bracket, closing_bracket) {
|
||||||
return Some(edit);
|
return Some(edit);
|
||||||
|
|
|
@ -12,7 +12,7 @@ use syntax::{
|
||||||
SyntaxNode, SyntaxToken, TextRange, TextSize, TokenAtOffset,
|
SyntaxNode, SyntaxToken, TextRange, TextSize, TokenAtOffset,
|
||||||
};
|
};
|
||||||
|
|
||||||
use text_edit::TextEdit;
|
use ide_db::text_edit::TextEdit;
|
||||||
|
|
||||||
// Feature: On Enter
|
// Feature: On Enter
|
||||||
//
|
//
|
||||||
|
|
|
@ -27,7 +27,6 @@ ra-ap-rustc_lexer.workspace = true
|
||||||
|
|
||||||
parser.workspace = true
|
parser.workspace = true
|
||||||
stdx.workspace = true
|
stdx.workspace = true
|
||||||
text-edit.workspace = true
|
|
||||||
|
|
||||||
[dev-dependencies]
|
[dev-dependencies]
|
||||||
rayon.workspace = true
|
rayon.workspace = true
|
||||||
|
|
|
@ -1,11 +1,6 @@
|
||||||
//! Collection of assorted algorithms for syntax trees.
|
//! Collection of assorted algorithms for syntax trees.
|
||||||
|
|
||||||
use std::hash::BuildHasherDefault;
|
|
||||||
|
|
||||||
use indexmap::IndexMap;
|
|
||||||
use itertools::Itertools;
|
use itertools::Itertools;
|
||||||
use rustc_hash::FxHashMap;
|
|
||||||
use text_edit::TextEditBuilder;
|
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
AstNode, Direction, NodeOrToken, SyntaxElement, SyntaxKind, SyntaxNode, SyntaxToken, TextRange,
|
AstNode, Direction, NodeOrToken, SyntaxElement, SyntaxKind, SyntaxNode, SyntaxToken, TextRange,
|
||||||
|
@ -101,559 +96,3 @@ pub fn neighbor<T: AstNode>(me: &T, direction: Direction) -> Option<T> {
|
||||||
pub fn has_errors(node: &SyntaxNode) -> bool {
|
pub fn has_errors(node: &SyntaxNode) -> bool {
|
||||||
node.children().any(|it| it.kind() == SyntaxKind::ERROR)
|
node.children().any(|it| it.kind() == SyntaxKind::ERROR)
|
||||||
}
|
}
|
||||||
|
|
||||||
type FxIndexMap<K, V> = IndexMap<K, V, BuildHasherDefault<rustc_hash::FxHasher>>;
|
|
||||||
|
|
||||||
#[derive(Debug, Hash, PartialEq, Eq)]
|
|
||||||
enum TreeDiffInsertPos {
|
|
||||||
After(SyntaxElement),
|
|
||||||
AsFirstChild(SyntaxElement),
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Debug)]
|
|
||||||
pub struct TreeDiff {
|
|
||||||
replacements: FxHashMap<SyntaxElement, SyntaxElement>,
|
|
||||||
deletions: Vec<SyntaxElement>,
|
|
||||||
// the vec as well as the indexmap are both here to preserve order
|
|
||||||
insertions: FxIndexMap<TreeDiffInsertPos, Vec<SyntaxElement>>,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl TreeDiff {
|
|
||||||
pub fn into_text_edit(&self, builder: &mut TextEditBuilder) {
|
|
||||||
let _p = tracing::info_span!("into_text_edit").entered();
|
|
||||||
|
|
||||||
for (anchor, to) in &self.insertions {
|
|
||||||
let offset = match anchor {
|
|
||||||
TreeDiffInsertPos::After(it) => it.text_range().end(),
|
|
||||||
TreeDiffInsertPos::AsFirstChild(it) => it.text_range().start(),
|
|
||||||
};
|
|
||||||
to.iter().for_each(|to| builder.insert(offset, to.to_string()));
|
|
||||||
}
|
|
||||||
for (from, to) in &self.replacements {
|
|
||||||
builder.replace(from.text_range(), to.to_string());
|
|
||||||
}
|
|
||||||
for text_range in self.deletions.iter().map(SyntaxElement::text_range) {
|
|
||||||
builder.delete(text_range);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn is_empty(&self) -> bool {
|
|
||||||
self.replacements.is_empty() && self.deletions.is_empty() && self.insertions.is_empty()
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Finds a (potentially minimal) diff, which, applied to `from`, will result in `to`.
|
|
||||||
///
|
|
||||||
/// Specifically, returns a structure that consists of a replacements, insertions and deletions
|
|
||||||
/// such that applying this map on `from` will result in `to`.
|
|
||||||
///
|
|
||||||
/// This function tries to find a fine-grained diff.
|
|
||||||
pub fn diff(from: &SyntaxNode, to: &SyntaxNode) -> TreeDiff {
|
|
||||||
let _p = tracing::info_span!("diff").entered();
|
|
||||||
|
|
||||||
let mut diff = TreeDiff {
|
|
||||||
replacements: FxHashMap::default(),
|
|
||||||
insertions: FxIndexMap::default(),
|
|
||||||
deletions: Vec::new(),
|
|
||||||
};
|
|
||||||
let (from, to) = (from.clone().into(), to.clone().into());
|
|
||||||
|
|
||||||
if !syntax_element_eq(&from, &to) {
|
|
||||||
go(&mut diff, from, to);
|
|
||||||
}
|
|
||||||
return diff;
|
|
||||||
|
|
||||||
fn syntax_element_eq(lhs: &SyntaxElement, rhs: &SyntaxElement) -> bool {
|
|
||||||
lhs.kind() == rhs.kind()
|
|
||||||
&& lhs.text_range().len() == rhs.text_range().len()
|
|
||||||
&& match (&lhs, &rhs) {
|
|
||||||
(NodeOrToken::Node(lhs), NodeOrToken::Node(rhs)) => {
|
|
||||||
lhs == rhs || lhs.text() == rhs.text()
|
|
||||||
}
|
|
||||||
(NodeOrToken::Token(lhs), NodeOrToken::Token(rhs)) => lhs.text() == rhs.text(),
|
|
||||||
_ => false,
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// FIXME: this is horribly inefficient. I bet there's a cool algorithm to diff trees properly.
|
|
||||||
fn go(diff: &mut TreeDiff, lhs: SyntaxElement, rhs: SyntaxElement) {
|
|
||||||
let (lhs, rhs) = match lhs.as_node().zip(rhs.as_node()) {
|
|
||||||
Some((lhs, rhs)) => (lhs, rhs),
|
|
||||||
_ => {
|
|
||||||
cov_mark::hit!(diff_node_token_replace);
|
|
||||||
diff.replacements.insert(lhs, rhs);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
};
|
|
||||||
|
|
||||||
let mut look_ahead_scratch = Vec::default();
|
|
||||||
|
|
||||||
let mut rhs_children = rhs.children_with_tokens();
|
|
||||||
let mut lhs_children = lhs.children_with_tokens();
|
|
||||||
let mut last_lhs = None;
|
|
||||||
loop {
|
|
||||||
let lhs_child = lhs_children.next();
|
|
||||||
match (lhs_child.clone(), rhs_children.next()) {
|
|
||||||
(None, None) => break,
|
|
||||||
(None, Some(element)) => {
|
|
||||||
let insert_pos = match last_lhs.clone() {
|
|
||||||
Some(prev) => {
|
|
||||||
cov_mark::hit!(diff_insert);
|
|
||||||
TreeDiffInsertPos::After(prev)
|
|
||||||
}
|
|
||||||
// first iteration, insert into out parent as the first child
|
|
||||||
None => {
|
|
||||||
cov_mark::hit!(diff_insert_as_first_child);
|
|
||||||
TreeDiffInsertPos::AsFirstChild(lhs.clone().into())
|
|
||||||
}
|
|
||||||
};
|
|
||||||
diff.insertions.entry(insert_pos).or_default().push(element);
|
|
||||||
}
|
|
||||||
(Some(element), None) => {
|
|
||||||
cov_mark::hit!(diff_delete);
|
|
||||||
diff.deletions.push(element);
|
|
||||||
}
|
|
||||||
(Some(ref lhs_ele), Some(ref rhs_ele)) if syntax_element_eq(lhs_ele, rhs_ele) => {}
|
|
||||||
(Some(lhs_ele), Some(rhs_ele)) => {
|
|
||||||
// nodes differ, look for lhs_ele in rhs, if its found we can mark everything up
|
|
||||||
// until that element as insertions. This is important to keep the diff minimal
|
|
||||||
// in regards to insertions that have been actually done, this is important for
|
|
||||||
// use insertions as we do not want to replace the entire module node.
|
|
||||||
look_ahead_scratch.push(rhs_ele.clone());
|
|
||||||
let mut rhs_children_clone = rhs_children.clone();
|
|
||||||
let mut insert = false;
|
|
||||||
for rhs_child in &mut rhs_children_clone {
|
|
||||||
if syntax_element_eq(&lhs_ele, &rhs_child) {
|
|
||||||
cov_mark::hit!(diff_insertions);
|
|
||||||
insert = true;
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
look_ahead_scratch.push(rhs_child);
|
|
||||||
}
|
|
||||||
let drain = look_ahead_scratch.drain(..);
|
|
||||||
if insert {
|
|
||||||
let insert_pos = if let Some(prev) = last_lhs.clone().filter(|_| insert) {
|
|
||||||
TreeDiffInsertPos::After(prev)
|
|
||||||
} else {
|
|
||||||
cov_mark::hit!(insert_first_child);
|
|
||||||
TreeDiffInsertPos::AsFirstChild(lhs.clone().into())
|
|
||||||
};
|
|
||||||
|
|
||||||
diff.insertions.entry(insert_pos).or_default().extend(drain);
|
|
||||||
rhs_children = rhs_children_clone;
|
|
||||||
} else {
|
|
||||||
go(diff, lhs_ele, rhs_ele);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
last_lhs = lhs_child.or(last_lhs);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[cfg(test)]
|
|
||||||
mod tests {
|
|
||||||
use expect_test::{expect, Expect};
|
|
||||||
use itertools::Itertools;
|
|
||||||
use parser::{Edition, SyntaxKind};
|
|
||||||
use text_edit::TextEdit;
|
|
||||||
|
|
||||||
use crate::{AstNode, SyntaxElement};
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn replace_node_token() {
|
|
||||||
cov_mark::check!(diff_node_token_replace);
|
|
||||||
check_diff(
|
|
||||||
r#"use node;"#,
|
|
||||||
r#"ident"#,
|
|
||||||
expect![[r#"
|
|
||||||
insertions:
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
replacements:
|
|
||||||
|
|
||||||
Line 0: Token(USE_KW@0..3 "use") -> ident
|
|
||||||
|
|
||||||
deletions:
|
|
||||||
|
|
||||||
Line 1: " "
|
|
||||||
Line 1: node
|
|
||||||
Line 1: ;
|
|
||||||
"#]],
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn replace_parent() {
|
|
||||||
cov_mark::check!(diff_insert_as_first_child);
|
|
||||||
check_diff(
|
|
||||||
r#""#,
|
|
||||||
r#"use foo::bar;"#,
|
|
||||||
expect![[r#"
|
|
||||||
insertions:
|
|
||||||
|
|
||||||
Line 0: AsFirstChild(Node(SOURCE_FILE@0..0))
|
|
||||||
-> use foo::bar;
|
|
||||||
|
|
||||||
replacements:
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
deletions:
|
|
||||||
|
|
||||||
|
|
||||||
"#]],
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn insert_last() {
|
|
||||||
cov_mark::check!(diff_insert);
|
|
||||||
check_diff(
|
|
||||||
r#"
|
|
||||||
use foo;
|
|
||||||
use bar;"#,
|
|
||||||
r#"
|
|
||||||
use foo;
|
|
||||||
use bar;
|
|
||||||
use baz;"#,
|
|
||||||
expect![[r#"
|
|
||||||
insertions:
|
|
||||||
|
|
||||||
Line 2: After(Node(USE@10..18))
|
|
||||||
-> "\n"
|
|
||||||
-> use baz;
|
|
||||||
|
|
||||||
replacements:
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
deletions:
|
|
||||||
|
|
||||||
|
|
||||||
"#]],
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn insert_middle() {
|
|
||||||
check_diff(
|
|
||||||
r#"
|
|
||||||
use foo;
|
|
||||||
use baz;"#,
|
|
||||||
r#"
|
|
||||||
use foo;
|
|
||||||
use bar;
|
|
||||||
use baz;"#,
|
|
||||||
expect![[r#"
|
|
||||||
insertions:
|
|
||||||
|
|
||||||
Line 2: After(Token(WHITESPACE@9..10 "\n"))
|
|
||||||
-> use bar;
|
|
||||||
-> "\n"
|
|
||||||
|
|
||||||
replacements:
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
deletions:
|
|
||||||
|
|
||||||
|
|
||||||
"#]],
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn insert_first() {
|
|
||||||
check_diff(
|
|
||||||
r#"
|
|
||||||
use bar;
|
|
||||||
use baz;"#,
|
|
||||||
r#"
|
|
||||||
use foo;
|
|
||||||
use bar;
|
|
||||||
use baz;"#,
|
|
||||||
expect![[r#"
|
|
||||||
insertions:
|
|
||||||
|
|
||||||
Line 0: After(Token(WHITESPACE@0..1 "\n"))
|
|
||||||
-> use foo;
|
|
||||||
-> "\n"
|
|
||||||
|
|
||||||
replacements:
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
deletions:
|
|
||||||
|
|
||||||
|
|
||||||
"#]],
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn first_child_insertion() {
|
|
||||||
cov_mark::check!(insert_first_child);
|
|
||||||
check_diff(
|
|
||||||
r#"fn main() {
|
|
||||||
stdi
|
|
||||||
}"#,
|
|
||||||
r#"use foo::bar;
|
|
||||||
|
|
||||||
fn main() {
|
|
||||||
stdi
|
|
||||||
}"#,
|
|
||||||
expect![[r#"
|
|
||||||
insertions:
|
|
||||||
|
|
||||||
Line 0: AsFirstChild(Node(SOURCE_FILE@0..30))
|
|
||||||
-> use foo::bar;
|
|
||||||
-> "\n\n "
|
|
||||||
|
|
||||||
replacements:
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
deletions:
|
|
||||||
|
|
||||||
|
|
||||||
"#]],
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn delete_last() {
|
|
||||||
cov_mark::check!(diff_delete);
|
|
||||||
check_diff(
|
|
||||||
r#"use foo;
|
|
||||||
use bar;"#,
|
|
||||||
r#"use foo;"#,
|
|
||||||
expect![[r#"
|
|
||||||
insertions:
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
replacements:
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
deletions:
|
|
||||||
|
|
||||||
Line 1: "\n "
|
|
||||||
Line 2: use bar;
|
|
||||||
"#]],
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn delete_middle() {
|
|
||||||
cov_mark::check!(diff_insertions);
|
|
||||||
check_diff(
|
|
||||||
r#"
|
|
||||||
use expect_test::{expect, Expect};
|
|
||||||
use text_edit::TextEdit;
|
|
||||||
|
|
||||||
use crate::AstNode;
|
|
||||||
"#,
|
|
||||||
r#"
|
|
||||||
use expect_test::{expect, Expect};
|
|
||||||
|
|
||||||
use crate::AstNode;
|
|
||||||
"#,
|
|
||||||
expect![[r#"
|
|
||||||
insertions:
|
|
||||||
|
|
||||||
Line 1: After(Node(USE@1..35))
|
|
||||||
-> "\n\n"
|
|
||||||
-> use crate::AstNode;
|
|
||||||
|
|
||||||
replacements:
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
deletions:
|
|
||||||
|
|
||||||
Line 2: use text_edit::TextEdit;
|
|
||||||
Line 3: "\n\n"
|
|
||||||
Line 4: use crate::AstNode;
|
|
||||||
Line 5: "\n"
|
|
||||||
"#]],
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn delete_first() {
|
|
||||||
check_diff(
|
|
||||||
r#"
|
|
||||||
use text_edit::TextEdit;
|
|
||||||
|
|
||||||
use crate::AstNode;
|
|
||||||
"#,
|
|
||||||
r#"
|
|
||||||
use crate::AstNode;
|
|
||||||
"#,
|
|
||||||
expect![[r#"
|
|
||||||
insertions:
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
replacements:
|
|
||||||
|
|
||||||
Line 2: Token(IDENT@5..14 "text_edit") -> crate
|
|
||||||
Line 2: Token(IDENT@16..24 "TextEdit") -> AstNode
|
|
||||||
Line 2: Token(WHITESPACE@25..27 "\n\n") -> "\n"
|
|
||||||
|
|
||||||
deletions:
|
|
||||||
|
|
||||||
Line 3: use crate::AstNode;
|
|
||||||
Line 4: "\n"
|
|
||||||
"#]],
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn merge_use() {
|
|
||||||
check_diff(
|
|
||||||
r#"
|
|
||||||
use std::{
|
|
||||||
fmt,
|
|
||||||
hash::BuildHasherDefault,
|
|
||||||
ops::{self, RangeInclusive},
|
|
||||||
};
|
|
||||||
"#,
|
|
||||||
r#"
|
|
||||||
use std::fmt;
|
|
||||||
use std::hash::BuildHasherDefault;
|
|
||||||
use std::ops::{self, RangeInclusive};
|
|
||||||
"#,
|
|
||||||
expect![[r#"
|
|
||||||
insertions:
|
|
||||||
|
|
||||||
Line 2: After(Node(PATH_SEGMENT@5..8))
|
|
||||||
-> ::
|
|
||||||
-> fmt
|
|
||||||
Line 6: After(Token(WHITESPACE@86..87 "\n"))
|
|
||||||
-> use std::hash::BuildHasherDefault;
|
|
||||||
-> "\n"
|
|
||||||
-> use std::ops::{self, RangeInclusive};
|
|
||||||
-> "\n"
|
|
||||||
|
|
||||||
replacements:
|
|
||||||
|
|
||||||
Line 2: Token(IDENT@5..8 "std") -> std
|
|
||||||
|
|
||||||
deletions:
|
|
||||||
|
|
||||||
Line 2: ::
|
|
||||||
Line 2: {
|
|
||||||
fmt,
|
|
||||||
hash::BuildHasherDefault,
|
|
||||||
ops::{self, RangeInclusive},
|
|
||||||
}
|
|
||||||
"#]],
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn early_return_assist() {
|
|
||||||
check_diff(
|
|
||||||
r#"
|
|
||||||
fn main() {
|
|
||||||
if let Ok(x) = Err(92) {
|
|
||||||
foo(x);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
"#,
|
|
||||||
r#"
|
|
||||||
fn main() {
|
|
||||||
let x = match Err(92) {
|
|
||||||
Ok(it) => it,
|
|
||||||
_ => return,
|
|
||||||
};
|
|
||||||
foo(x);
|
|
||||||
}
|
|
||||||
"#,
|
|
||||||
expect![[r#"
|
|
||||||
insertions:
|
|
||||||
|
|
||||||
Line 3: After(Node(BLOCK_EXPR@40..63))
|
|
||||||
-> " "
|
|
||||||
-> match Err(92) {
|
|
||||||
Ok(it) => it,
|
|
||||||
_ => return,
|
|
||||||
}
|
|
||||||
-> ;
|
|
||||||
Line 3: After(Node(IF_EXPR@17..63))
|
|
||||||
-> "\n "
|
|
||||||
-> foo(x);
|
|
||||||
|
|
||||||
replacements:
|
|
||||||
|
|
||||||
Line 3: Token(IF_KW@17..19 "if") -> let
|
|
||||||
Line 3: Token(LET_KW@20..23 "let") -> x
|
|
||||||
Line 3: Node(BLOCK_EXPR@40..63) -> =
|
|
||||||
|
|
||||||
deletions:
|
|
||||||
|
|
||||||
Line 3: " "
|
|
||||||
Line 3: Ok(x)
|
|
||||||
Line 3: " "
|
|
||||||
Line 3: =
|
|
||||||
Line 3: " "
|
|
||||||
Line 3: Err(92)
|
|
||||||
"#]],
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn check_diff(from: &str, to: &str, expected_diff: Expect) {
|
|
||||||
let from_node = crate::SourceFile::parse(from, Edition::CURRENT).tree().syntax().clone();
|
|
||||||
let to_node = crate::SourceFile::parse(to, Edition::CURRENT).tree().syntax().clone();
|
|
||||||
let diff = super::diff(&from_node, &to_node);
|
|
||||||
|
|
||||||
let line_number =
|
|
||||||
|syn: &SyntaxElement| from[..syn.text_range().start().into()].lines().count();
|
|
||||||
|
|
||||||
let fmt_syntax = |syn: &SyntaxElement| match syn.kind() {
|
|
||||||
SyntaxKind::WHITESPACE => format!("{:?}", syn.to_string()),
|
|
||||||
_ => format!("{syn}"),
|
|
||||||
};
|
|
||||||
|
|
||||||
let insertions =
|
|
||||||
diff.insertions.iter().format_with("\n", |(k, v), f| -> Result<(), std::fmt::Error> {
|
|
||||||
f(&format!(
|
|
||||||
"Line {}: {:?}\n-> {}",
|
|
||||||
line_number(match k {
|
|
||||||
super::TreeDiffInsertPos::After(syn) => syn,
|
|
||||||
super::TreeDiffInsertPos::AsFirstChild(syn) => syn,
|
|
||||||
}),
|
|
||||||
k,
|
|
||||||
v.iter().format_with("\n-> ", |v, f| f(&fmt_syntax(v)))
|
|
||||||
))
|
|
||||||
});
|
|
||||||
|
|
||||||
let replacements = diff
|
|
||||||
.replacements
|
|
||||||
.iter()
|
|
||||||
.sorted_by_key(|(syntax, _)| syntax.text_range().start())
|
|
||||||
.format_with("\n", |(k, v), f| {
|
|
||||||
f(&format!("Line {}: {k:?} -> {}", line_number(k), fmt_syntax(v)))
|
|
||||||
});
|
|
||||||
|
|
||||||
let deletions = diff
|
|
||||||
.deletions
|
|
||||||
.iter()
|
|
||||||
.format_with("\n", |v, f| f(&format!("Line {}: {}", line_number(v), fmt_syntax(v))));
|
|
||||||
|
|
||||||
let actual = format!(
|
|
||||||
"insertions:\n\n{insertions}\n\nreplacements:\n\n{replacements}\n\ndeletions:\n\n{deletions}\n"
|
|
||||||
);
|
|
||||||
expected_diff.assert_eq(&actual);
|
|
||||||
|
|
||||||
let mut from = from.to_owned();
|
|
||||||
let mut text_edit = TextEdit::builder();
|
|
||||||
diff.into_text_edit(&mut text_edit);
|
|
||||||
text_edit.finish().apply(&mut from);
|
|
||||||
assert_eq!(&*from, to, "diff did not turn `from` to `to`");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
|
@ -5,7 +5,6 @@
|
||||||
use std::str::{self, FromStr};
|
use std::str::{self, FromStr};
|
||||||
|
|
||||||
use parser::Edition;
|
use parser::Edition;
|
||||||
use text_edit::Indel;
|
|
||||||
|
|
||||||
use crate::{validation, AstNode, SourceFile, TextRange};
|
use crate::{validation, AstNode, SourceFile, TextRange};
|
||||||
|
|
||||||
|
@ -22,7 +21,8 @@ pub fn check_parser(text: &str) {
|
||||||
#[derive(Debug, Clone)]
|
#[derive(Debug, Clone)]
|
||||||
pub struct CheckReparse {
|
pub struct CheckReparse {
|
||||||
text: String,
|
text: String,
|
||||||
edit: Indel,
|
delete: TextRange,
|
||||||
|
insert: String,
|
||||||
edited_text: String,
|
edited_text: String,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -43,14 +43,13 @@ impl CheckReparse {
|
||||||
TextRange::at(delete_start.try_into().unwrap(), delete_len.try_into().unwrap());
|
TextRange::at(delete_start.try_into().unwrap(), delete_len.try_into().unwrap());
|
||||||
let edited_text =
|
let edited_text =
|
||||||
format!("{}{}{}", &text[..delete_start], &insert, &text[delete_start + delete_len..]);
|
format!("{}{}{}", &text[..delete_start], &insert, &text[delete_start + delete_len..]);
|
||||||
let edit = Indel { insert, delete };
|
Some(CheckReparse { text, insert, delete, edited_text })
|
||||||
Some(CheckReparse { text, edit, edited_text })
|
|
||||||
}
|
}
|
||||||
|
|
||||||
#[allow(clippy::print_stderr)]
|
#[allow(clippy::print_stderr)]
|
||||||
pub fn run(&self) {
|
pub fn run(&self) {
|
||||||
let parse = SourceFile::parse(&self.text, Edition::CURRENT);
|
let parse = SourceFile::parse(&self.text, Edition::CURRENT);
|
||||||
let new_parse = parse.reparse(&self.edit, Edition::CURRENT);
|
let new_parse = parse.reparse(self.delete, &self.insert, Edition::CURRENT);
|
||||||
check_file_invariants(&new_parse.tree());
|
check_file_invariants(&new_parse.tree());
|
||||||
assert_eq!(&new_parse.tree().syntax().text().to_string(), &self.edited_text);
|
assert_eq!(&new_parse.tree().syntax().text().to_string(), &self.edited_text);
|
||||||
let full_reparse = SourceFile::parse(&self.edited_text, Edition::CURRENT);
|
let full_reparse = SourceFile::parse(&self.edited_text, Edition::CURRENT);
|
||||||
|
|
|
@ -44,10 +44,9 @@ pub mod syntax_editor;
|
||||||
pub mod ted;
|
pub mod ted;
|
||||||
pub mod utils;
|
pub mod utils;
|
||||||
|
|
||||||
use std::marker::PhantomData;
|
use std::{marker::PhantomData, ops::Range};
|
||||||
|
|
||||||
use stdx::format_to;
|
use stdx::format_to;
|
||||||
use text_edit::Indel;
|
|
||||||
use triomphe::Arc;
|
use triomphe::Arc;
|
||||||
|
|
||||||
pub use crate::{
|
pub use crate::{
|
||||||
|
@ -150,16 +149,22 @@ impl Parse<SourceFile> {
|
||||||
buf
|
buf
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn reparse(&self, indel: &Indel, edition: Edition) -> Parse<SourceFile> {
|
pub fn reparse(&self, delete: TextRange, insert: &str, edition: Edition) -> Parse<SourceFile> {
|
||||||
self.incremental_reparse(indel, edition)
|
self.incremental_reparse(delete, insert, edition)
|
||||||
.unwrap_or_else(|| self.full_reparse(indel, edition))
|
.unwrap_or_else(|| self.full_reparse(delete, insert, edition))
|
||||||
}
|
}
|
||||||
|
|
||||||
fn incremental_reparse(&self, indel: &Indel, edition: Edition) -> Option<Parse<SourceFile>> {
|
fn incremental_reparse(
|
||||||
|
&self,
|
||||||
|
delete: TextRange,
|
||||||
|
insert: &str,
|
||||||
|
edition: Edition,
|
||||||
|
) -> Option<Parse<SourceFile>> {
|
||||||
// FIXME: validation errors are not handled here
|
// FIXME: validation errors are not handled here
|
||||||
parsing::incremental_reparse(
|
parsing::incremental_reparse(
|
||||||
self.tree().syntax(),
|
self.tree().syntax(),
|
||||||
indel,
|
delete,
|
||||||
|
insert,
|
||||||
self.errors.as_deref().unwrap_or_default().iter().cloned(),
|
self.errors.as_deref().unwrap_or_default().iter().cloned(),
|
||||||
edition,
|
edition,
|
||||||
)
|
)
|
||||||
|
@ -170,9 +175,9 @@ impl Parse<SourceFile> {
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
fn full_reparse(&self, indel: &Indel, edition: Edition) -> Parse<SourceFile> {
|
fn full_reparse(&self, delete: TextRange, insert: &str, edition: Edition) -> Parse<SourceFile> {
|
||||||
let mut text = self.tree().syntax().text().to_string();
|
let mut text = self.tree().syntax().text().to_string();
|
||||||
indel.apply(&mut text);
|
text.replace_range(Range::<usize>::from(delete), insert);
|
||||||
SourceFile::parse(&text, edition)
|
SourceFile::parse(&text, edition)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -6,8 +6,9 @@
|
||||||
//! - otherwise, we search for the nearest `{}` block which contains the edit
|
//! - otherwise, we search for the nearest `{}` block which contains the edit
|
||||||
//! and try to parse only this block.
|
//! and try to parse only this block.
|
||||||
|
|
||||||
|
use std::ops::Range;
|
||||||
|
|
||||||
use parser::{Edition, Reparser};
|
use parser::{Edition, Reparser};
|
||||||
use text_edit::Indel;
|
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
parsing::build_tree,
|
parsing::build_tree,
|
||||||
|
@ -19,38 +20,48 @@ use crate::{
|
||||||
|
|
||||||
pub(crate) fn incremental_reparse(
|
pub(crate) fn incremental_reparse(
|
||||||
node: &SyntaxNode,
|
node: &SyntaxNode,
|
||||||
edit: &Indel,
|
delete: TextRange,
|
||||||
|
insert: &str,
|
||||||
errors: impl IntoIterator<Item = SyntaxError>,
|
errors: impl IntoIterator<Item = SyntaxError>,
|
||||||
edition: Edition,
|
edition: Edition,
|
||||||
) -> Option<(GreenNode, Vec<SyntaxError>, TextRange)> {
|
) -> Option<(GreenNode, Vec<SyntaxError>, TextRange)> {
|
||||||
if let Some((green, new_errors, old_range)) = reparse_token(node, edit, edition) {
|
if let Some((green, new_errors, old_range)) = reparse_token(node, delete, insert, edition) {
|
||||||
return Some((green, merge_errors(errors, new_errors, old_range, edit), old_range));
|
return Some((
|
||||||
|
green,
|
||||||
|
merge_errors(errors, new_errors, old_range, delete, insert),
|
||||||
|
old_range,
|
||||||
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
if let Some((green, new_errors, old_range)) = reparse_block(node, edit, edition) {
|
if let Some((green, new_errors, old_range)) = reparse_block(node, delete, insert, edition) {
|
||||||
return Some((green, merge_errors(errors, new_errors, old_range, edit), old_range));
|
return Some((
|
||||||
|
green,
|
||||||
|
merge_errors(errors, new_errors, old_range, delete, insert),
|
||||||
|
old_range,
|
||||||
|
));
|
||||||
}
|
}
|
||||||
None
|
None
|
||||||
}
|
}
|
||||||
|
|
||||||
fn reparse_token(
|
fn reparse_token(
|
||||||
root: &SyntaxNode,
|
root: &SyntaxNode,
|
||||||
edit: &Indel,
|
delete: TextRange,
|
||||||
|
insert: &str,
|
||||||
edition: Edition,
|
edition: Edition,
|
||||||
) -> Option<(GreenNode, Vec<SyntaxError>, TextRange)> {
|
) -> Option<(GreenNode, Vec<SyntaxError>, TextRange)> {
|
||||||
let prev_token = root.covering_element(edit.delete).as_token()?.clone();
|
let prev_token = root.covering_element(delete).as_token()?.clone();
|
||||||
let prev_token_kind = prev_token.kind();
|
let prev_token_kind = prev_token.kind();
|
||||||
match prev_token_kind {
|
match prev_token_kind {
|
||||||
WHITESPACE | COMMENT | IDENT | STRING | BYTE_STRING | C_STRING => {
|
WHITESPACE | COMMENT | IDENT | STRING | BYTE_STRING | C_STRING => {
|
||||||
if prev_token_kind == WHITESPACE || prev_token_kind == COMMENT {
|
if prev_token_kind == WHITESPACE || prev_token_kind == COMMENT {
|
||||||
// removing a new line may extends previous token
|
// removing a new line may extends previous token
|
||||||
let deleted_range = edit.delete - prev_token.text_range().start();
|
let deleted_range = delete - prev_token.text_range().start();
|
||||||
if prev_token.text()[deleted_range].contains('\n') {
|
if prev_token.text()[deleted_range].contains('\n') {
|
||||||
return None;
|
return None;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
let mut new_text = get_text_after_edit(prev_token.clone().into(), edit);
|
let mut new_text = get_text_after_edit(prev_token.clone().into(), delete, insert);
|
||||||
let (new_token_kind, new_err) = parser::LexedStr::single_token(edition, &new_text)?;
|
let (new_token_kind, new_err) = parser::LexedStr::single_token(edition, &new_text)?;
|
||||||
|
|
||||||
if new_token_kind != prev_token_kind
|
if new_token_kind != prev_token_kind
|
||||||
|
@ -85,11 +96,12 @@ fn reparse_token(
|
||||||
|
|
||||||
fn reparse_block(
|
fn reparse_block(
|
||||||
root: &SyntaxNode,
|
root: &SyntaxNode,
|
||||||
edit: &Indel,
|
delete: TextRange,
|
||||||
|
insert: &str,
|
||||||
edition: parser::Edition,
|
edition: parser::Edition,
|
||||||
) -> Option<(GreenNode, Vec<SyntaxError>, TextRange)> {
|
) -> Option<(GreenNode, Vec<SyntaxError>, TextRange)> {
|
||||||
let (node, reparser) = find_reparsable_node(root, edit.delete)?;
|
let (node, reparser) = find_reparsable_node(root, delete)?;
|
||||||
let text = get_text_after_edit(node.clone().into(), edit);
|
let text = get_text_after_edit(node.clone().into(), delete, insert);
|
||||||
|
|
||||||
let lexed = parser::LexedStr::new(edition, text.as_str());
|
let lexed = parser::LexedStr::new(edition, text.as_str());
|
||||||
let parser_input = lexed.to_input(edition);
|
let parser_input = lexed.to_input(edition);
|
||||||
|
@ -104,14 +116,14 @@ fn reparse_block(
|
||||||
Some((node.replace_with(green), new_parser_errors, node.text_range()))
|
Some((node.replace_with(green), new_parser_errors, node.text_range()))
|
||||||
}
|
}
|
||||||
|
|
||||||
fn get_text_after_edit(element: SyntaxElement, edit: &Indel) -> String {
|
fn get_text_after_edit(element: SyntaxElement, mut delete: TextRange, insert: &str) -> String {
|
||||||
let edit = Indel::replace(edit.delete - element.text_range().start(), edit.insert.clone());
|
delete -= element.text_range().start();
|
||||||
|
|
||||||
let mut text = match element {
|
let mut text = match element {
|
||||||
NodeOrToken::Token(token) => token.text().to_owned(),
|
NodeOrToken::Token(token) => token.text().to_owned(),
|
||||||
NodeOrToken::Node(node) => node.text().to_string(),
|
NodeOrToken::Node(node) => node.text().to_string(),
|
||||||
};
|
};
|
||||||
edit.apply(&mut text);
|
text.replace_range(Range::<usize>::from(delete), insert);
|
||||||
text
|
text
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -153,7 +165,8 @@ fn merge_errors(
|
||||||
old_errors: impl IntoIterator<Item = SyntaxError>,
|
old_errors: impl IntoIterator<Item = SyntaxError>,
|
||||||
new_errors: Vec<SyntaxError>,
|
new_errors: Vec<SyntaxError>,
|
||||||
range_before_reparse: TextRange,
|
range_before_reparse: TextRange,
|
||||||
edit: &Indel,
|
delete: TextRange,
|
||||||
|
insert: &str,
|
||||||
) -> Vec<SyntaxError> {
|
) -> Vec<SyntaxError> {
|
||||||
let mut res = Vec::new();
|
let mut res = Vec::new();
|
||||||
|
|
||||||
|
@ -162,8 +175,8 @@ fn merge_errors(
|
||||||
if old_err_range.end() <= range_before_reparse.start() {
|
if old_err_range.end() <= range_before_reparse.start() {
|
||||||
res.push(old_err);
|
res.push(old_err);
|
||||||
} else if old_err_range.start() >= range_before_reparse.end() {
|
} else if old_err_range.start() >= range_before_reparse.end() {
|
||||||
let inserted_len = TextSize::of(&edit.insert);
|
let inserted_len = TextSize::of(insert);
|
||||||
res.push(old_err.with_range((old_err_range + inserted_len) - edit.delete.len()));
|
res.push(old_err.with_range((old_err_range + inserted_len) - delete.len()));
|
||||||
// Note: extra parens are intentional to prevent uint underflow, HWAB (here was a bug)
|
// Note: extra parens are intentional to prevent uint underflow, HWAB (here was a bug)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -177,6 +190,8 @@ fn merge_errors(
|
||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
|
use std::ops::Range;
|
||||||
|
|
||||||
use parser::Edition;
|
use parser::Edition;
|
||||||
use test_utils::{assert_eq_text, extract_range};
|
use test_utils::{assert_eq_text, extract_range};
|
||||||
|
|
||||||
|
@ -185,10 +200,9 @@ mod tests {
|
||||||
|
|
||||||
fn do_check(before: &str, replace_with: &str, reparsed_len: u32) {
|
fn do_check(before: &str, replace_with: &str, reparsed_len: u32) {
|
||||||
let (range, before) = extract_range(before);
|
let (range, before) = extract_range(before);
|
||||||
let edit = Indel::replace(range, replace_with.to_owned());
|
|
||||||
let after = {
|
let after = {
|
||||||
let mut after = before.clone();
|
let mut after = before.clone();
|
||||||
edit.apply(&mut after);
|
after.replace_range(Range::<usize>::from(range), replace_with);
|
||||||
after
|
after
|
||||||
};
|
};
|
||||||
|
|
||||||
|
@ -197,7 +211,8 @@ mod tests {
|
||||||
let before = SourceFile::parse(&before, Edition::CURRENT);
|
let before = SourceFile::parse(&before, Edition::CURRENT);
|
||||||
let (green, new_errors, range) = incremental_reparse(
|
let (green, new_errors, range) = incremental_reparse(
|
||||||
before.tree().syntax(),
|
before.tree().syntax(),
|
||||||
&edit,
|
range,
|
||||||
|
replace_with,
|
||||||
before.errors.as_deref().unwrap_or_default().iter().cloned(),
|
before.errors.as_deref().unwrap_or_default().iter().cloned(),
|
||||||
Edition::CURRENT,
|
Edition::CURRENT,
|
||||||
)
|
)
|
||||||
|
|
|
@ -1,20 +0,0 @@
|
||||||
[package]
|
|
||||||
name = "text-edit"
|
|
||||||
version = "0.0.0"
|
|
||||||
repository.workspace = true
|
|
||||||
description = "Representation of a `TextEdit` for rust-analyzer."
|
|
||||||
|
|
||||||
authors.workspace = true
|
|
||||||
edition.workspace = true
|
|
||||||
license.workspace = true
|
|
||||||
rust-version.workspace = true
|
|
||||||
|
|
||||||
[lib]
|
|
||||||
doctest = false
|
|
||||||
|
|
||||||
[dependencies]
|
|
||||||
itertools.workspace = true
|
|
||||||
text-size.workspace = true
|
|
||||||
|
|
||||||
[lints]
|
|
||||||
workspace = true
|
|
Loading…
Reference in a new issue