Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2025-01-25 11:25:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

Rollup merge of #115011 - compiler-errors:warn-on-elided-assoc-ct-lt, r=cjgillot

Browse source 
Warn on elided lifetimes in associated constants (`ELIDED_LIFETIMES_IN_ASSOCIATED_CONSTANT`)

Elided lifetimes in associated constants (in impls) erroneously resolve to fresh lifetime parameters on the impl since #97313. This is not correct behavior (see #38831).

I originally opened #114716 to fix this, but given the time that has passed, the crater results seem pretty bad: https://github.com/rust-lang/rust/pull/114716#issuecomment-1682091952

This PR alternatively implements a lint against this behavior, and I'm hoping to bump this to deny in a few versions.
This commit is contained in:
Michael Goulet 2023-08-22 09:00:49 -07:00 committed by GitHub
commit 64d9364933
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/test-utils/src/fixture.rs
View file

@ -313,7 +313,7 @@ impl FixtureWithProjectMeta {
}
impl MiniCore {
const RAW_SOURCE: &str = include_str!("./minicore.rs");
const RAW_SOURCE: &'static str = include_str!("./minicore.rs");
fn has_flag(&self, flag: &str) -> bool {
self.activated_flags.iter().any(|it| it == flag)