2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2025-01-16 23:24:03 +00:00

Auto merge of - workingjubilee:say-turings-prayer, r=BoxyUwU

compiler: Never debug_assert in codegen

In the name of Turing and his Hoarey heralds, assert our truths before creating a monster!

The `rustc_codegen_llvm` and `rustc_codegen_ssa` crates are fairly critical for rustc's correctness. Small mistakes here can easily result in undefined behavior, since a "small mistake" can mean something like "link and execute the wrong code". We should probably run any and all asserts in these modules unconditionally on whether this is a "debug build", and damn the costs in performance.

...Especially because the costs in performance seem to be *nothing*. It is not clear how much correctness we gain here, but I'll take free correctness improvements.
This commit is contained in:
bors 2024-07-25 07:52:31 +00:00
commit 55c9bf894f

Diff content is not available