Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2025-01-14 14:13:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add comments for why skip highlighting for invalid char/byte literals

Browse source
This commit is contained in:
oxalica 2023-07-23 04:24:35 +08:00
parent 1f35e4d3f1
commit 51b35ccb1b
No known key found for this signature in database
GPG key ID: D425CB23CADE82D9
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/ide/src/syntax_highlighting/escape.rs
View file

@ -26,6 +26,9 @@ pub(super) fn highlight_escape_string<T: IsString>(
pub(super) fn highlight_escape_char(stack: &mut Highlights, char: &Char, start: TextSize) { pub(super) fn highlight_escape_char(stack: &mut Highlights, char: &Char, start: TextSize) {
if char.value().is_none() { if char.value().is_none() {
// We do not emit invalid escapes highlighting here. The lexer would likely be in a bad
// state and this token contains junks, since `'` is not a reliable delimiter (consider
// lifetimes). Nonetheless, parser errors should already be emitted.
return; return;
} }
@ -46,6 +49,7 @@ pub(super) fn highlight_escape_char(stack: &mut Highlights, char: &Char, start:
pub(super) fn highlight_escape_byte(stack: &mut Highlights, byte: &Byte, start: TextSize) { pub(super) fn highlight_escape_byte(stack: &mut Highlights, byte: &Byte, start: TextSize) {
if byte.value().is_none() { if byte.value().is_none() {
// See `highlight_escape_char` for why no error highlighting here.
return; return;
} }