From da34676104b5a9496bc66edacd27e8ea6cfea268 Mon Sep 17 00:00:00 2001 From: Tyler Mandry Date: Thu, 15 Aug 2024 15:18:15 -0700 Subject: [PATCH] Allow flycheck process to exit gracefully Assuming it isn't cancelled. Closes #17902. The only place CommandHandle::join is used is when the flycheck command finishes, so this commit changes the behavior of the method itself. --- crates/rust-analyzer/src/command.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/crates/rust-analyzer/src/command.rs b/crates/rust-analyzer/src/command.rs index f1009eb466..b19a1b8d16 100644 --- a/crates/rust-analyzer/src/command.rs +++ b/crates/rust-analyzer/src/command.rs @@ -148,7 +148,6 @@ impl CommandHandle { } pub(crate) fn join(mut self) -> io::Result<()> { - let _ = self.child.0.kill(); let exit_status = self.child.0.wait()?; let (read_at_least_one_message, error) = self.thread.join()?; if read_at_least_one_message || exit_status.success() {