Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2025-01-01 07:48:45 +00:00
Code Issues Projects Releases Packages Wiki Activity

Treat scope info retrieval failure as assist failure

Browse source
This commit is contained in:
Ryo Yoshida 2023-02-02 17:47:11 +09:00
parent 3edde6fcc1
commit 493cabbde7
No known key found for this signature in database
GPG key ID: E25698A930586171
1 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
crates/ide-assists/src/handlers/generate_function.rs
View file

@ -290,7 +290,7 @@ impl FunctionBuilder {
); );
let (generic_param_list, where_clause) = let (generic_param_list, where_clause) =
fn_generic_params(ctx, necessary_generic_params, &target); fn_generic_params(ctx, necessary_generic_params, &target)?;
Some(Self { Some(Self {
target, target,
@ -336,7 +336,7 @@ impl FunctionBuilder {
); );
let (generic_param_list, where_clause) = let (generic_param_list, where_clause) =
fn_generic_params(ctx, necessary_generic_params, &target); fn_generic_params(ctx, necessary_generic_params, &target)?;
Some(Self { Some(Self {
target, target,
@ -551,7 +551,8 @@ fn fn_args(
)) ))
} }
/// Gets parameter bounds and where predicates in scope and filters out irrelevant ones. /// Gets parameter bounds and where predicates in scope and filters out irrelevant ones. Returns
/// `None` when it fails to get scope information.
/// ///
/// See comment on `filter_unnecessary_bounds()` for what bounds we consider relevant. /// See comment on `filter_unnecessary_bounds()` for what bounds we consider relevant.
/// ///
@ -562,10 +563,10 @@ fn fn_generic_params(
ctx: &AssistContext<'_>, ctx: &AssistContext<'_>,
necessary_params: FxHashSet<hir::GenericParam>, necessary_params: FxHashSet<hir::GenericParam>,
target: &GeneratedFunctionTarget, target: &GeneratedFunctionTarget,
) -> (Option<ast::GenericParamList>, Option<ast::WhereClause>) { ) -> Option<(Option<ast::GenericParamList>, Option<ast::WhereClause>)> {
if necessary_params.is_empty() { if necessary_params.is_empty() {
// Not really needed but fast path. // Not really needed but fast path.
return (None, None); return Some((None, None));
} }
// 1. Get generic parameters (with bounds) and where predicates in scope. // 1. Get generic parameters (with bounds) and where predicates in scope.
@ -592,8 +593,8 @@ fn fn_generic_params(
// 4. Rewrite paths // 4. Rewrite paths
if let Some(param) = generic_params.first() { if let Some(param) = generic_params.first() {
let source_scope = ctx.sema.scope(param.syntax()).unwrap(); let source_scope = ctx.sema.scope(param.syntax())?;
let target_scope = ctx.sema.scope(&target.parent()).unwrap(); let target_scope = ctx.sema.scope(&target.parent())?;
if source_scope.module() != target_scope.module() { if source_scope.module() != target_scope.module() {
let transform = PathTransform::generic_transformation(&target_scope, &source_scope); let transform = PathTransform::generic_transformation(&target_scope, &source_scope);
let generic_params = generic_params.iter().map(|it| it.syntax()); let generic_params = generic_params.iter().map(|it| it.syntax());
@ -606,7 +607,7 @@ fn fn_generic_params(
let where_clause = let where_clause =
if where_preds.is_empty() { None } else { Some(make::where_clause(where_preds)) }; if where_preds.is_empty() { None } else { Some(make::where_clause(where_preds)) };
(Some(generic_param_list), where_clause) Some((Some(generic_param_list), where_clause))
} }
fn params_and_where_preds_in_scope( fn params_and_where_preds_in_scope(