diff --git a/crates/rust-analyzer/src/cli/load_cargo.rs b/crates/rust-analyzer/src/cli/load_cargo.rs index b1250f2fe0..d8677c2311 100644 --- a/crates/rust-analyzer/src/cli/load_cargo.rs +++ b/crates/rust-analyzer/src/cli/load_cargo.rs @@ -54,7 +54,7 @@ pub fn load_cargo( Ok((host, vfs)) } -pub(crate) fn load( +fn load( crate_graph: CrateGraph, source_root_config: SourceRootConfig, vfs: &mut vfs::Vfs, diff --git a/crates/rust-analyzer/src/global_state.rs b/crates/rust-analyzer/src/global_state.rs index a9a1d09fde..7533bb319a 100644 --- a/crates/rust-analyzer/src/global_state.rs +++ b/crates/rust-analyzer/src/global_state.rs @@ -12,8 +12,6 @@ use parking_lot::RwLock; use ra_db::{CrateId, VfsPath}; use ra_ide::{Analysis, AnalysisChange, AnalysisHost, FileId}; use ra_project_model::{CargoWorkspace, ProcMacroClient, ProjectWorkspace, Target}; -use stdx::format_to; -use vfs::loader::Handle as _; use crate::{ config::Config, @@ -83,15 +81,15 @@ pub(crate) struct GlobalStateSnapshot { pub(crate) check_fixes: CheckFixes, pub(crate) latest_requests: Arc>, vfs: Arc)>>, - workspaces: Arc>, + pub(crate) workspaces: Arc>, } impl GlobalState { pub(crate) fn new(sender: Sender, config: Config) -> GlobalState { let loader = { let (sender, receiver) = unbounded::(); - let handle = - vfs_notify::NotifyHandle::spawn(Box::new(move |msg| sender.send(msg).unwrap())); + let handle: vfs_notify::NotifyHandle = + vfs::loader::Handle::spawn(Box::new(move |msg| sender.send(msg).unwrap())); let handle = Box::new(handle) as Box; Handle { handle, receiver } }; @@ -171,14 +169,6 @@ impl GlobalState { } } - pub(crate) fn maybe_collect_garbage(&mut self) { - self.analysis_host.maybe_collect_garbage() - } - - pub(crate) fn collect_garbage(&mut self) { - self.analysis_host.collect_garbage() - } - pub(crate) fn send(&mut self, message: lsp_server::Message) { self.sender.send(message).unwrap() } @@ -242,26 +232,6 @@ impl GlobalStateSnapshot { ProjectWorkspace::Json { .. } => None, }) } - - pub(crate) fn status(&self) -> String { - let mut buf = String::new(); - if self.workspaces.is_empty() { - buf.push_str("no workspaces\n") - } else { - buf.push_str("workspaces:\n"); - for w in self.workspaces.iter() { - format_to!(buf, "{} packages loaded\n", w.n_packages()); - } - } - buf.push_str("\nanalysis:\n"); - buf.push_str( - &self - .analysis - .status() - .unwrap_or_else(|_| "Analysis retrieval was cancelled".to_owned()), - ); - buf - } } pub(crate) fn file_id_to_url(vfs: &vfs::Vfs, id: FileId) -> Url { diff --git a/crates/rust-analyzer/src/handlers.rs b/crates/rust-analyzer/src/handlers.rs index 12b494496f..6c21f25fe4 100644 --- a/crates/rust-analyzer/src/handlers.rs +++ b/crates/rust-analyzer/src/handlers.rs @@ -39,7 +39,20 @@ use crate::{ pub(crate) fn handle_analyzer_status(snap: GlobalStateSnapshot, _: ()) -> Result { let _p = profile("handle_analyzer_status"); - let mut buf = snap.status(); + + let mut buf = String::new(); + if snap.workspaces.is_empty() { + buf.push_str("no workspaces\n") + } else { + buf.push_str("workspaces:\n"); + for w in snap.workspaces.iter() { + format_to!(buf, "{} packages loaded\n", w.n_packages()); + } + } + buf.push_str("\nanalysis:\n"); + buf.push_str( + &snap.analysis.status().unwrap_or_else(|_| "Analysis retrieval was cancelled".to_owned()), + ); format_to!(buf, "\n\nrequests:\n"); let requests = snap.latest_requests.read(); for (is_last, r) in requests.iter() { diff --git a/crates/rust-analyzer/src/main_loop.rs b/crates/rust-analyzer/src/main_loop.rs index 386a47621b..162c0057e9 100644 --- a/crates/rust-analyzer/src/main_loop.rs +++ b/crates/rust-analyzer/src/main_loop.rs @@ -158,7 +158,7 @@ impl GlobalState { } Task::Unit => (), } - self.maybe_collect_garbage(); + self.analysis_host.maybe_collect_garbage(); } Event::Vfs(task) => match task { vfs::loader::Message::Loaded { files } => { @@ -274,7 +274,7 @@ impl GlobalState { self.req_queue.incoming.register(req.id.clone(), (req.method.clone(), request_received)); RequestDispatcher { req: Some(req), global_state: self } - .on_sync::(|s, ()| Ok(s.collect_garbage()))? + .on_sync::(|s, ()| Ok(s.analysis_host.collect_garbage()))? .on_sync::(|s, p| handlers::handle_join_lines(s.snapshot(), p))? .on_sync::(|s, p| handlers::handle_on_enter(s.snapshot(), p))? .on_sync::(|_, ()| Ok(()))?