Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2024-12-25 20:43:21 +00:00
Code Issues Projects Releases Packages Wiki Activity

Check for path dev-dependencies with a version number

Browse source
This commit is contained in:
Laurențiu Nicola 2021-03-01 21:13:16 +02:00
parent 9860a39603
commit 203cfff826
1 changed files with 33 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
xtask/src/tidy.rs
View file

@ -101,22 +101,45 @@ fn cargo_files_are_tidy() {
let mut section = None; let mut section = None;
for (line_no, text) in read_file(&cargo).unwrap().lines().enumerate() { for (line_no, text) in read_file(&cargo).unwrap().lines().enumerate() {
let text = text.trim(); let text = text.trim();
if text.starts_with("[") { if text.starts_with('[') {
section = Some(text); if !text.ends_with(']') {
continue;
}
if !section.map(|it| it.starts_with("[dependencies")).unwrap_or(false) {
continue;
}
let text: String = text.split_whitespace().collect();
if text.contains("path=") && !text.contains("version") {
panic!( panic!(
"\ncargo internal dependencies should have version.\n\ "\nplease don't add comments or trailing whitespace in section lines.\n\
{}:{}\n", {}:{}\n",
cargo.display(), cargo.display(),
line_no + 1 line_no + 1
) )
} }
section = Some(text);
continue;
}
let text: String = text.split_whitespace().collect();
if !text.contains("path=") {
continue;
}
match section {
Some(s) if s.contains("dev-dependencies") => {
if text.contains("version") {
panic!(
"\ncargo internal dev-dependencies should not have a version.\n\
{}:{}\n",
cargo.display(),
line_no + 1
);
}
}
Some(s) if s.contains("dependencies") => {
if !text.contains("version") {
panic!(
"\ncargo internal dependencies should have a version.\n\
{}:{}\n",
cargo.display(),
line_no + 1
);
}
}
_ => {}
}
} }
} }
} }