Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2024-11-17 02:08:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge #9129

Browse source 
9129: NFC: remove redundant clones (clippy::perf) r=Veykril a=matthiaskrgr



Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
This commit is contained in:
bors[bot] 2021-06-03 13:45:17 +00:00 committed by GitHub
commit 1dbdac8f51
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/hir_def/src/item_tree/lower.rs
View file

@ -130,7 +130,7 @@ impl<'a> Ctx<'a> {
ast::Item::ExternBlock(ast) => self.lower_extern_block(ast).into(), ast::Item::ExternBlock(ast) => self.lower_extern_block(ast).into(),
}; };
self.add_attrs(item.into(), attrs.clone()); self.add_attrs(item.into(), attrs);
Some(item) Some(item)
} }

2
crates/ide_assists/src/handlers/extract_type_alias.rs
View file

@ -31,7 +31,7 @@ pub(crate) fn extract_type_alias(acc: &mut Assists, ctx: &AssistContext) -> Opti
let item = ctx.find_node_at_offset::<ast::Item>()?; let item = ctx.find_node_at_offset::<ast::Item>()?;
let insert = match_ast! { let insert = match_ast! {
match (item.syntax().parent()?) { match (item.syntax().parent()?) {
ast::AssocItemList(it) => it.syntax().parent()?.clone(), ast::AssocItemList(it) => it.syntax().parent()?,
_ => item.syntax().clone(), _ => item.syntax().clone(),
} }
}; };

2
crates/ide_completion/src/context.rs
View file

@ -567,7 +567,7 @@ impl<'a> CompletionContext<'a> {
None => return, None => return,
}; };
if let Some(segment) = ast::PathSegment::cast(parent.clone()) { if let Some(segment) = ast::PathSegment::cast(parent) {
let path = segment.parent_path(); let path = segment.parent_path();
self.is_call = path self.is_call = path
.syntax() .syntax()

2
crates/proc_macro_api/src/msg.rs
View file

@ -92,7 +92,7 @@ fn read_json<'a>(
// Some ill behaved macro try to use stdout for debugging // Some ill behaved macro try to use stdout for debugging
// We ignore it here // We ignore it here
if !buf.starts_with("{") { if !buf.starts_with('{') {
log::error!("proc-macro tried to print : {}", buf); log::error!("proc-macro tried to print : {}", buf);
continue; continue;
} }

2
crates/rust-analyzer/src/handlers.rs
View file

@ -1640,7 +1640,7 @@ fn run_rustfmt(
.into()); .into());
} }
let frange = from_proto::file_range(&snap, text_document.clone(), range)?; let frange = from_proto::file_range(&snap, text_document, range)?;
let start_line = line_index.index.line_col(frange.range.start()).line; let start_line = line_index.index.line_col(frange.range.start()).line;
let end_line = line_index.index.line_col(frange.range.end()).line; let end_line = line_index.index.line_col(frange.range.end()).line;