Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2024-12-27 05:23:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

Don't inline mutable locals in 'inline_local_variable'

Browse source
This commit is contained in:
Lukas Wirth 2021-06-04 20:36:43 +02:00
parent 98395f29a4
commit 1bd04d9064
1 changed files with 17 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
crates/ide_assists/src/handlers/inline_local_variable.rs
View file

@ -182,6 +182,10 @@ fn inline_usage(ctx: &AssistContext) -> Option<InlineData> {
PathResolution::Local(local) => local,
_ => return None,
};
if local.is_mut(ctx.sema.db) {
cov_mark::hit!(test_not_inline_mut_variable_use);
return None;
}
let bind_pat = match local.source(ctx.db()).value {
Either::Left(ident) => ident,
@ -426,6 +430,19 @@ fn foo() {
);
}
#[test]
fn test_not_inline_mut_variable_use() {
cov_mark::check!(test_not_inline_mut_variable_use);
check_assist_not_applicable(
inline_local_variable,
r"
fn foo() {
let mut a = 1 + 1;
a$0 + 1;
}",
);
}
#[test]
fn test_call_expr() {
check_assist(