Merge #5235 #5236 #5241

5235: Don't ping people in PRs r=matklad a=lnicola



5236: Disable ES module interop r=matklad a=lnicola



5241: Clippy perf warnings r=matklad a=kjeremy

Removes redundant clones

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Co-authored-by: kjeremy <kjeremy@gmail.com>

crates/ra_hir_ty/src/display.rs

@@ -369,7 +369,7 @@ impl HirDisplay for ApplicationTy {
                         let data = (*datas)
                             .as_ref()
                             .map(|rpit| rpit.impl_traits[idx as usize].bounds.clone());
-                        data.clone().subst(&self.parameters)
+                        data.subst(&self.parameters)
                     }
                 };
                 write!(f, "impl ")?;
@@ -456,7 +456,7 @@ impl HirDisplay for Ty {
                         let data = (*datas)
                             .as_ref()
                             .map(|rpit| rpit.impl_traits[idx as usize].bounds.clone());
-                        data.clone().subst(&opaque_ty.parameters)
+                        data.subst(&opaque_ty.parameters)
                     }
                 };
                 write!(f, "impl ")?;

crates/ra_hir_ty/src/infer/expr.rs

@@ -85,10 +85,8 @@ impl<'a> InferenceContext<'a> {
             ctor: TypeCtor::Tuple { cardinality: num_args as u16 },
             parameters,
         });
-        let substs = Substs::build_for_generics(&generic_params)
+        let substs =
-            .push(ty.clone())
+            Substs::build_for_generics(&generic_params).push(ty.clone()).push(arg_ty).build();
-            .push(arg_ty.clone())
-            .build();
 
         let trait_env = Arc::clone(&self.trait_env);
         let implements_fn_trait =

crates/ra_hir_ty/src/lib.rs

@@ -891,7 +891,7 @@ impl Ty {
                             let data = (*it)
                                 .as_ref()
                                 .map(|rpit| rpit.impl_traits[idx as usize].bounds.clone());
-                            data.clone().subst(&opaque_ty.parameters)
+                            data.subst(&opaque_ty.parameters)
                         })
                     }
                 };

crates/ra_hir_ty/src/lower.rs

@@ -720,8 +720,7 @@ fn assoc_type_bindings_from_type_bound<'a>(
                 None => return SmallVec::<[GenericPredicate; 1]>::new(),
                 Some(t) => t,
             };
-            let projection_ty =
+            let projection_ty = ProjectionTy { associated_ty, parameters: super_trait_ref.substs };
-                ProjectionTy { associated_ty, parameters: super_trait_ref.substs.clone() };
             let mut preds = SmallVec::with_capacity(
                 binding.type_ref.as_ref().map_or(0, |_| 1) + binding.bounds.len(),
             );

crates/ra_syntax/src/ast/edit.rs

@@ -299,12 +299,8 @@ impl ast::UseTree {
             Some(it) => it,
             None => return self.clone(),
         };
-        let use_tree = make::use_tree(
+        let use_tree =
-            suffix.clone(),
+            make::use_tree(suffix, self.use_tree_list(), self.alias(), self.star_token().is_some());
-            self.use_tree_list(),
-            self.alias(),
-            self.star_token().is_some(),
-        );
         let nested = make::use_tree_list(iter::once(use_tree));
         return make::use_tree(prefix.clone(), Some(nested), None, false);
 

crates/test_utils/src/fixture.rs

@@ -62,7 +62,7 @@ impl Fixture {
         let components = meta.split_ascii_whitespace().collect::<Vec<_>>();
 
         let path = components[0].to_string();
-        assert!(path.starts_with("/"));
+        assert!(path.starts_with('/'));
 
         let mut krate = None;
         let mut deps = Vec::new();

docs/dev/README.md

@@ -314,7 +314,7 @@ We don't have specific rules around git history hygiene.
 Maintaining clean git history is encouraged, but not enforced.
 We use rebase workflow, it's OK to rewrite history during PR review process.
 
-Avoid @mentioning people in commit messages, as such messages create a lot of duplicate notification traffic during rebases.
+Avoid @mentioning people in commit messages and pull request descriptions (they are added to commit message by bors), as such messages create a lot of duplicate notification traffic during rebases.
 
 # Architecture Invariants
 

editors/code/tests/unit/index.ts

@@ -1,6 +1,6 @@
 import * as path from 'path';
-import Mocha from 'mocha';
+import * as Mocha from 'mocha';
-import glob from 'glob';
+import * as glob from 'glob';
 
 export function run(): Promise<void> {
     // Create the mocha test

editors/code/tsconfig.json

@@ -6,8 +6,6 @@
         "lib": [
             "es2019"
         ],
-        "esModuleInterop": true,
-        "allowSyntheticDefaultImports": true,
         "sourceMap": true,
         "rootDir": ".",
         "strict": true,