Merge #9773

Browse source

9773: internal: Improve `extract_function` assist r=Veykril a=Veykril

- fix: It doesn't try to overwrite parts of selected comments any longer
- fix: It doesn't wrap tail expressions and return types in a result or option unnecessarily
- feat?: It now adds a `const` modifier to the created function if extract somethings from a const context 

Fixes #7840

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

...

This commit is contained in:

bors[bot] 2021-08-03 16:53:12 +00:00 committed by GitHub

parent 00c8cab20b 9edaf0cad8

commit 09ec0a15fa

No known key found for this signature in database

GPG key ID: 4AEE18F83AFDEB23

1 changed files with 519 additions and 341 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show stats Download patch file Download diff file Expand all files Collapse all files

860

crates/ide_assists/src/handlers/extract_function.rs

View file

File diff suppressed because it is too large Load diff