rust-analyzer/crates/ra_ide/src/typing.rs

367 lines
9.1 KiB
Rust
Raw Normal View History

//! This module handles auto-magic editing actions applied together with users
//! edits. For example, if the user typed
//!
//! ```text
//! foo
//! .bar()
//! .baz()
//! | // <- cursor is here
//! ```
//!
//! and types `.` next, we want to indent the dot.
//!
//! Language server executes such typing assists synchronously. That is, they
//! block user's typing and should be pretty fast for this reason!
2020-03-11 11:46:36 +00:00
mod on_enter;
use ra_db::{FilePosition, SourceDatabase};
use ra_fmt::leading_indent;
2020-06-08 19:44:42 +00:00
use ra_ide_db::{source_change::SourceFileEdit, RootDatabase};
2018-09-16 09:54:24 +00:00
use ra_syntax::{
2019-07-21 10:28:58 +00:00
algo::find_node_at_offset,
2019-04-02 07:23:18 +00:00
ast::{self, AstToken},
AstNode, SourceFile,
SyntaxKind::{FIELD_EXPR, METHOD_CALL_EXPR},
TextRange, TextSize,
2018-08-23 17:55:23 +00:00
};
2020-05-06 09:31:26 +00:00
use ra_text_edit::TextEdit;
2018-08-23 17:55:23 +00:00
2020-05-06 09:31:26 +00:00
use crate::SourceChange;
2020-03-11 11:46:36 +00:00
pub(crate) use on_enter::on_enter;
2019-10-25 09:16:56 +00:00
pub(crate) const TRIGGER_CHARS: &str = ".=>";
2019-10-25 09:04:17 +00:00
2020-05-30 23:54:54 +00:00
// Feature: On Typing Assists
//
// Some features trigger on typing certain characters:
//
// - typing `let =` tries to smartly add `;` if `=` is followed by an existing expression
// - Enter inside comments automatically inserts `///`
// - typing `.` in a chain method call auto-indents
pub(crate) fn on_char_typed(
db: &RootDatabase,
position: FilePosition,
char_typed: char,
) -> Option<SourceChange> {
2019-10-25 09:04:17 +00:00
assert!(TRIGGER_CHARS.contains(char_typed));
let file = &db.parse(position.file_id).tree();
assert_eq!(file.syntax().text().char_at(position.offset), Some(char_typed));
2020-06-08 19:44:42 +00:00
let edit = on_char_typed_inner(file, position.offset, char_typed)?;
Some(SourceFileEdit { file_id: position.file_id, edit }.into())
}
fn on_char_typed_inner(file: &SourceFile, offset: TextSize, char_typed: char) -> Option<TextEdit> {
2019-10-25 09:16:56 +00:00
assert!(TRIGGER_CHARS.contains(char_typed));
2019-10-25 09:04:17 +00:00
match char_typed {
'.' => on_dot_typed(file, offset),
'=' => on_eq_typed(file, offset),
2019-10-25 09:16:56 +00:00
'>' => on_arrow_typed(file, offset),
_ => unreachable!(),
2019-10-25 09:04:17 +00:00
}
}
/// Returns an edit which should be applied after `=` was typed. Primarily,
/// this works when adding `let =`.
// FIXME: use a snippet completion instead of this hack here.
fn on_eq_typed(file: &SourceFile, offset: TextSize) -> Option<TextEdit> {
assert_eq!(file.syntax().text().char_at(offset), Some('='));
let let_stmt: ast::LetStmt = find_node_at_offset(file.syntax(), offset)?;
2020-04-10 08:11:05 +00:00
if let_stmt.semicolon_token().is_some() {
2018-08-28 08:12:42 +00:00
return None;
}
if let Some(expr) = let_stmt.initializer() {
2019-07-20 09:58:27 +00:00
let expr_range = expr.syntax().text_range();
if expr_range.contains(offset) && offset != expr_range.start() {
2018-08-28 08:12:42 +00:00
return None;
}
if file.syntax().text().slice(offset..expr_range.start()).contains_char('\n') {
2018-08-28 18:45:59 +00:00
return None;
}
2018-08-28 08:17:08 +00:00
} else {
return None;
2018-08-28 08:12:42 +00:00
}
2019-07-20 09:58:27 +00:00
let offset = let_stmt.syntax().text_range().end();
Some(TextEdit::insert(offset, ";".to_string()))
2018-08-28 08:12:42 +00:00
}
/// Returns an edit which should be applied when a dot ('.') is typed on a blank line, indenting the line appropriately.
fn on_dot_typed(file: &SourceFile, offset: TextSize) -> Option<TextEdit> {
assert_eq!(file.syntax().text().char_at(offset), Some('.'));
let whitespace =
file.syntax().token_at_offset(offset).left_biased().and_then(ast::Whitespace::cast)?;
2019-01-06 20:59:14 +00:00
2019-01-11 11:57:19 +00:00
let current_indent = {
let text = whitespace.text();
let newline = text.rfind('\n')?;
&text[newline + 1..]
};
2020-04-24 21:40:41 +00:00
let current_indent_len = TextSize::of(current_indent);
2019-01-06 20:59:14 +00:00
let parent = whitespace.syntax().parent();
2019-01-11 11:57:19 +00:00
// Make sure dot is a part of call chain
if !matches!(parent.kind(), FIELD_EXPR | METHOD_CALL_EXPR) {
return None;
}
let prev_indent = leading_indent(&parent)?;
2019-01-11 11:57:19 +00:00
let target_indent = format!(" {}", prev_indent);
2020-04-24 21:40:41 +00:00
let target_indent_len = TextSize::of(&target_indent);
2019-01-11 11:57:19 +00:00
if current_indent_len == target_indent_len {
return None;
}
Some(TextEdit::replace(TextRange::new(offset - current_indent_len, offset), target_indent))
2019-01-06 20:59:14 +00:00
}
2019-10-25 09:16:56 +00:00
/// Adds a space after an arrow when `fn foo() { ... }` is turned into `fn foo() -> { ... }`
fn on_arrow_typed(file: &SourceFile, offset: TextSize) -> Option<TextEdit> {
2019-10-25 09:16:56 +00:00
let file_text = file.syntax().text();
assert_eq!(file_text.char_at(offset), Some('>'));
2020-04-24 21:40:41 +00:00
let after_arrow = offset + TextSize::of('>');
2019-10-25 09:16:56 +00:00
if file_text.char_at(after_arrow) != Some('{') {
return None;
}
if find_node_at_offset::<ast::RetType>(file.syntax(), offset).is_none() {
return None;
}
Some(TextEdit::insert(after_arrow, " ".to_string()))
2019-10-25 09:16:56 +00:00
}
2018-08-28 11:47:12 +00:00
#[cfg(test)]
mod tests {
2020-03-11 11:46:36 +00:00
use test_utils::{assert_eq_text, extract_offset};
2019-03-23 15:55:47 +00:00
2019-01-10 14:50:49 +00:00
use super::*;
2018-08-28 11:47:12 +00:00
2020-05-20 22:46:08 +00:00
fn do_type_char(char_typed: char, before: &str) -> Option<String> {
2019-10-25 09:04:17 +00:00
let (offset, before) = extract_offset(before);
let edit = TextEdit::insert(offset, char_typed.to_string());
2020-05-05 21:48:26 +00:00
let mut before = before.to_string();
edit.apply(&mut before);
2019-10-25 09:04:17 +00:00
let parse = SourceFile::parse(&before);
2020-05-05 21:48:26 +00:00
on_char_typed_inner(&parse.tree(), offset, char_typed).map(|it| {
it.apply(&mut before);
2020-05-20 22:46:08 +00:00
before.to_string()
2020-05-05 21:48:26 +00:00
})
2019-10-25 09:04:17 +00:00
}
fn type_char(char_typed: char, ra_fixture_before: &str, ra_fixture_after: &str) {
let actual = do_type_char(char_typed, ra_fixture_before)
2019-10-30 17:36:37 +00:00
.unwrap_or_else(|| panic!("typing `{}` did nothing", char_typed));
2019-10-25 09:16:56 +00:00
assert_eq_text!(ra_fixture_after, &actual);
2019-10-25 09:04:17 +00:00
}
2019-10-25 09:16:56 +00:00
fn type_char_noop(char_typed: char, before: &str) {
let file_change = do_type_char(char_typed, before);
assert!(file_change.is_none())
2019-10-25 09:04:17 +00:00
}
2018-08-28 11:47:12 +00:00
#[test]
fn test_on_eq_typed() {
// do_check(r"
// fn foo() {
// let foo =<|>
// }
// ", r"
// fn foo() {
// let foo =;
// }
// ");
2019-10-25 09:16:56 +00:00
type_char(
'=',
r"
2018-08-28 11:47:12 +00:00
fn foo() {
2019-01-11 12:48:06 +00:00
let foo <|> 1 + 1
2018-08-28 11:47:12 +00:00
}
",
r"
2018-08-28 11:47:12 +00:00
fn foo() {
let foo = 1 + 1;
}
",
);
2018-08-28 11:47:12 +00:00
// do_check(r"
// fn foo() {
// let foo =<|>
// let bar = 1;
// }
// ", r"
// fn foo() {
// let foo =;
// let bar = 1;
// }
// ");
}
2019-01-05 23:58:03 +00:00
#[test]
2019-01-11 12:48:06 +00:00
fn indents_new_chain_call() {
2019-10-25 09:16:56 +00:00
type_char(
'.',
2019-01-05 23:58:03 +00:00
r"
2020-03-13 17:00:23 +00:00
fn main() {
xs.foo()
2019-01-11 12:48:06 +00:00
<|>
2019-01-11 11:57:19 +00:00
}
",
2019-01-05 23:58:03 +00:00
r"
2020-03-13 17:00:23 +00:00
fn main() {
xs.foo()
2019-01-11 11:57:19 +00:00
.
}
",
2019-01-06 11:24:33 +00:00
);
2019-10-25 09:16:56 +00:00
type_char_noop(
'.',
2019-01-06 11:24:33 +00:00
r"
2020-03-13 17:00:23 +00:00
fn main() {
xs.foo()
2019-01-11 12:48:06 +00:00
<|>
2019-01-11 11:57:19 +00:00
}
",
2019-01-11 12:48:06 +00:00
)
}
2019-01-06 11:24:33 +00:00
2019-01-13 15:21:23 +00:00
#[test]
fn indents_new_chain_call_with_semi() {
2019-10-25 09:16:56 +00:00
type_char(
'.',
2019-01-13 15:21:23 +00:00
r"
2020-03-13 17:00:23 +00:00
fn main() {
xs.foo()
2019-01-13 15:21:23 +00:00
<|>;
}
",
r"
2020-03-13 17:00:23 +00:00
fn main() {
xs.foo()
2019-01-13 15:21:23 +00:00
.;
}
",
);
2019-10-25 09:16:56 +00:00
type_char_noop(
'.',
2019-01-13 15:21:23 +00:00
r"
2020-03-13 17:00:23 +00:00
fn main() {
xs.foo()
2019-01-13 15:21:23 +00:00
<|>;
}
",
)
}
#[test]
fn indents_new_chain_call_with_let() {
type_char(
'.',
r#"
fn main() {
let _ = foo
<|>
bar()
}
"#,
r#"
fn main() {
let _ = foo
.
bar()
}
"#,
);
}
2019-01-11 12:48:06 +00:00
#[test]
fn indents_continued_chain_call() {
2019-10-25 09:16:56 +00:00
type_char(
'.',
2019-01-06 11:24:33 +00:00
r"
2020-03-13 17:00:23 +00:00
fn main() {
xs.foo()
2019-01-11 11:57:19 +00:00
.first()
2019-01-11 12:48:06 +00:00
<|>
2019-01-11 11:57:19 +00:00
}
",
2019-01-06 11:24:33 +00:00
r"
2020-03-13 17:00:23 +00:00
fn main() {
xs.foo()
2019-01-11 11:57:19 +00:00
.first()
.
}
",
2019-01-06 11:24:33 +00:00
);
2019-10-25 09:16:56 +00:00
type_char_noop(
'.',
2019-01-06 11:24:33 +00:00
r"
2020-03-13 17:00:23 +00:00
fn main() {
xs.foo()
2019-01-11 11:57:19 +00:00
.first()
2019-01-11 12:48:06 +00:00
<|>
2019-01-11 11:57:19 +00:00
}
",
2019-01-06 20:59:14 +00:00
);
2019-01-11 12:48:06 +00:00
}
2019-01-06 20:59:14 +00:00
2019-01-25 08:23:15 +00:00
#[test]
fn indents_middle_of_chain_call() {
2019-10-25 09:16:56 +00:00
type_char(
'.',
2019-01-25 08:23:15 +00:00
r"
fn source_impl() {
let var = enum_defvariant_list().unwrap()
<|>
.nth(92)
.unwrap();
}
",
r"
fn source_impl() {
let var = enum_defvariant_list().unwrap()
.
.nth(92)
.unwrap();
}
",
);
2019-10-25 09:16:56 +00:00
type_char_noop(
'.',
2019-01-25 08:23:15 +00:00
r"
fn source_impl() {
let var = enum_defvariant_list().unwrap()
<|>
.nth(92)
.unwrap();
}
",
);
}
2019-01-11 12:48:06 +00:00
#[test]
fn dont_indent_freestanding_dot() {
2019-10-25 09:16:56 +00:00
type_char_noop(
'.',
2019-01-06 20:59:14 +00:00
r"
2020-03-13 17:00:23 +00:00
fn main() {
2019-01-11 12:48:06 +00:00
<|>
2019-01-11 11:57:19 +00:00
}
",
2019-01-06 20:59:14 +00:00
);
2019-10-25 09:16:56 +00:00
type_char_noop(
'.',
2019-01-06 20:59:14 +00:00
r"
2020-03-13 17:00:23 +00:00
fn main() {
2019-01-11 12:48:06 +00:00
<|>
}
2019-01-11 11:57:19 +00:00
",
2019-01-05 23:58:03 +00:00
);
}
#[test]
2019-10-25 09:16:56 +00:00
fn adds_space_after_return_type() {
2020-05-20 22:46:08 +00:00
type_char('>', "fn foo() -<|>{ 92 }", "fn foo() -> { 92 }")
}
2018-08-28 11:47:12 +00:00
}