Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2024-12-31 23:38:45 +00:00
Code Issues Projects Releases Packages Wiki Activity
rust-analyzer/crates/ra_hir_def/src/db.rs

122 lines
4.6 KiB
Rust
Raw Normal View History

Move ids to hir_def crate
2019-10-30 10:10:38 +00:00
//! Defines database & queries for name resolution.
move raw_items to hir_def
2019-10-30 13:12:55 +00:00
use std::sync::Arc;
Move ids to hir_def crate
2019-10-30 10:10:38 +00:00
Use `ImportMap` in `find_path`, remove old queries
2020-06-04 17:30:29 +00:00
use hir_expand::{db::AstDatabase, HirFileId};
Use `dyn Trait` for working with databse It improves compile time in `--release` mode quite a bit, it doesn't really slow things down and, conceptually, it seems closer to what we want the physical architecture to look like (we don't want to monomorphise EVERYTHING in a single leaf crate).
2020-03-13 15:05:46 +00:00
use ra_db::{salsa, CrateId, SourceDatabase, Upcast};
Split `crate_def_map` into two methods This change: - introduces `compute_crate_def_map` query and renames `CrateDefMap::crate_def_map_query` for consistency, - annotates `crate_def_map` as `salsa::transparent` and adds a top-level `crate_def_map` wrapper function around that starts the profiler and immediately calls into `compute_crate_def_map` query. This allows us to better understand where we spent the time, in particular, how much is spent in the recomputaiton and how much in salsa. Example output (where we don't actually re-compute anything, but the query still takes a non-trivial amount of time): ``` 211ms - handle_inlay_hints 150ms - get_inlay_hints 150ms - SourceAnalyzer::new 65ms - def_with_body_from_child_node 65ms - analyze_container 65ms - analyze_container 65ms - Module::from_definition 65ms - Module::from_file 65ms - crate_def_map 1ms - parse_macro_query (6 calls) 0ms - raw_items_query (1 calls) 64ms - ??? ``` Signed-off-by: Michal Terepeta <michal.terepeta@gmail.com>
2020-01-03 12:59:46 +00:00
use ra_prof::profile;
Move enum&union to new loc
2019-12-12 14:11:57 +00:00
use ra_syntax::SmolStr;
Move ids to hir_def crate
2019-10-30 10:10:38 +00:00
move struct & enum data to hir_def
2019-10-31 13:40:36 +00:00
use crate::{
adt::{EnumData, StructData},
Move attrs query to hir_def
2019-11-23 08:14:10 +00:00
attr::Attrs,
Move body queries to hir_def
2019-11-14 14:37:22 +00:00
body::{scope::ExprScopes, Body, BodySourceMap},
Highlight mutable statics as mutable
2020-05-10 15:08:28 +00:00
data::{ConstData, FunctionData, ImplData, StaticData, TraitData, TypeAliasData},
Move docs to hir_def
2019-11-23 11:43:38 +00:00
docs::Documentation,
Move generic_params query to HIR
2019-11-20 17:33:18 +00:00
generics::GenericParams,
Add an ImportMap
2020-05-20 21:51:20 +00:00
import_map::ImportMap,
Hook up query, add impls, lower moar
2020-06-11 17:46:56 +00:00
item_tree::ItemTree,
Move lang_items to hir_def
2019-11-23 09:58:01 +00:00
lang_item::{LangItemTarget, LangItems},
Remove raw item query
2020-06-15 17:16:43 +00:00
nameres::CrateDefMap,
Move enum&union to new loc
2019-12-12 14:11:57 +00:00
AttrDefId, ConstId, ConstLoc, DefWithBodyId, EnumId, EnumLoc, FunctionId, FunctionLoc,
GenericDefId, ImplId, ImplLoc, ModuleId, StaticId, StaticLoc, StructId, StructLoc, TraitId,
TraitLoc, TypeAliasId, TypeAliasLoc, UnionId, UnionLoc,
move struct & enum data to hir_def
2019-10-31 13:40:36 +00:00
};
move raw_items to hir_def
2019-10-30 13:12:55 +00:00
Move ids to hir_def crate
2019-10-30 10:10:38 +00:00
#[salsa::query_group(InternDatabaseStorage)]
pub trait InternDatabase: SourceDatabase {
#[salsa::interned]
Cleanup imports
2019-11-23 12:33:21 +00:00
fn intern_function(&self, loc: FunctionLoc) -> FunctionId;
Move ids to hir_def crate
2019-10-30 10:10:38 +00:00
#[salsa::interned]
Move structs to new loc
2019-12-12 13:58:04 +00:00
fn intern_struct(&self, loc: StructLoc) -> StructId;
Fix hir for ast::UnionDef
2019-11-25 14:30:50 +00:00
#[salsa::interned]
Move enum&union to new loc
2019-12-12 14:11:57 +00:00
fn intern_union(&self, loc: UnionLoc) -> UnionId;
move raw_items to hir_def
2019-10-30 13:12:55 +00:00
#[salsa::interned]
Move enum&union to new loc
2019-12-12 14:11:57 +00:00
fn intern_enum(&self, loc: EnumLoc) -> EnumId;
Move ids to hir_def crate
2019-10-30 10:10:38 +00:00
#[salsa::interned]
Cleanup imports
2019-11-23 12:33:21 +00:00
fn intern_const(&self, loc: ConstLoc) -> ConstId;
Move ids to hir_def crate
2019-10-30 10:10:38 +00:00
#[salsa::interned]
Switch to StaticLoc for statics
2019-11-24 12:13:56 +00:00
fn intern_static(&self, loc: StaticLoc) -> StaticId;
Move ids to hir_def crate
2019-10-30 10:10:38 +00:00
#[salsa::interned]
Move traits to the new loc
2019-12-12 13:34:03 +00:00
fn intern_trait(&self, loc: TraitLoc) -> TraitId;
Move ids to hir_def crate
2019-10-30 10:10:38 +00:00
#[salsa::interned]
Cleanup imports
2019-11-23 12:33:21 +00:00
fn intern_type_alias(&self, loc: TypeAliasLoc) -> TypeAliasId;
Add ImplId
2019-11-15 16:14:50 +00:00
#[salsa::interned]
Switch to the new location for impls
2019-12-12 13:09:13 +00:00
fn intern_impl(&self, loc: ImplLoc) -> ImplId;
Move ids to hir_def crate
2019-10-30 10:10:38 +00:00
}
move raw_items to hir_def
2019-10-30 13:12:55 +00:00
Get rid of DefDatabase2
2019-11-23 11:44:43 +00:00
#[salsa::query_group(DefDatabaseStorage)]
Use `dyn Trait` for working with databse It improves compile time in `--release` mode quite a bit, it doesn't really slow things down and, conceptually, it seems closer to what we want the physical architecture to look like (we don't want to monomorphise EVERYTHING in a single leaf crate).
2020-03-13 15:05:46 +00:00
pub trait DefDatabase: InternDatabase + AstDatabase + Upcast<dyn AstDatabase> {
Hook up query, add impls, lower moar
2020-06-11 17:46:56 +00:00
#[salsa::invoke(ItemTree::item_tree_query)]
fn item_tree(&self, file_id: HirFileId) -> Arc<ItemTree>;
Normalize waiting queries names
2020-03-06 23:11:52 +00:00
#[salsa::invoke(crate_def_map_wait)]
Cleanup memory usage stats
2020-03-25 17:41:46 +00:00
#[salsa::transparent]
Move CrateDefMap to hir_def
2019-10-31 15:45:10 +00:00
fn crate_def_map(&self, krate: CrateId) -> Arc<CrateDefMap>;
Normalize waiting queries names
2020-03-06 23:11:52 +00:00
#[salsa::invoke(CrateDefMap::crate_def_map_query)]
fn crate_def_map_query(&self, krate: CrateId) -> Arc<CrateDefMap>;
Split `crate_def_map` into two methods This change: - introduces `compute_crate_def_map` query and renames `CrateDefMap::crate_def_map_query` for consistency, - annotates `crate_def_map` as `salsa::transparent` and adds a top-level `crate_def_map` wrapper function around that starts the profiler and immediately calls into `compute_crate_def_map` query. This allows us to better understand where we spent the time, in particular, how much is spent in the recomputaiton and how much in salsa. Example output (where we don't actually re-compute anything, but the query still takes a non-trivial amount of time): ``` 211ms - handle_inlay_hints 150ms - get_inlay_hints 150ms - SourceAnalyzer::new 65ms - def_with_body_from_child_node 65ms - analyze_container 65ms - analyze_container 65ms - Module::from_definition 65ms - Module::from_file 65ms - crate_def_map 1ms - parse_macro_query (6 calls) 0ms - raw_items_query (1 calls) 64ms - ??? ``` Signed-off-by: Michal Terepeta <michal.terepeta@gmail.com>
2020-01-03 12:59:46 +00:00
move struct & enum data to hir_def
2019-10-31 13:40:36 +00:00
#[salsa::invoke(StructData::struct_data_query)]
Fix hir for ast::UnionDef
2019-11-25 14:30:50 +00:00
fn struct_data(&self, id: StructId) -> Arc<StructData>;
#[salsa::invoke(StructData::union_data_query)]
fn union_data(&self, id: UnionId) -> Arc<StructData>;
Move CrateDefMap to hir_def
2019-10-31 15:45:10 +00:00
move struct & enum data to hir_def
2019-10-31 13:40:36 +00:00
#[salsa::invoke(EnumData::enum_data_query)]
fn enum_data(&self, e: EnumId) -> Arc<EnumData>;
Move body queries to hir_def
2019-11-14 14:37:22 +00:00
Remove old impls infrastructure
2019-11-15 18:28:00 +00:00
#[salsa::invoke(ImplData::impl_data_query)]
fn impl_data(&self, e: ImplId) -> Arc<ImplData>;
Move traits to hir_def
2019-11-20 11:22:06 +00:00
#[salsa::invoke(TraitData::trait_data_query)]
fn trait_data(&self, e: TraitId) -> Arc<TraitData>;
Move TypeAlias to hir_def
2019-11-22 09:57:40 +00:00
#[salsa::invoke(TypeAliasData::type_alias_data_query)]
fn type_alias_data(&self, e: TypeAliasId) -> Arc<TypeAliasData>;
Move FunctionData to hir_def
2019-11-22 14:10:51 +00:00
#[salsa::invoke(FunctionData::fn_data_query)]
fn function_data(&self, func: FunctionId) -> Arc<FunctionData>;
Move const&static date to hir_def
2019-11-22 15:46:39 +00:00
#[salsa::invoke(ConstData::const_data_query)]
fn const_data(&self, konst: ConstId) -> Arc<ConstData>;
Highlight mutable statics as mutable
2020-05-10 15:08:28 +00:00
#[salsa::invoke(StaticData::static_data_query)]
fn static_data(&self, konst: StaticId) -> Arc<StaticData>;
Move const&static date to hir_def
2019-11-22 15:46:39 +00:00
Move body queries to hir_def
2019-11-14 14:37:22 +00:00
#[salsa::invoke(Body::body_with_source_map_query)]
fn body_with_source_map(&self, def: DefWithBodyId) -> (Arc<Body>, Arc<BodySourceMap>);
#[salsa::invoke(Body::body_query)]
fn body(&self, def: DefWithBodyId) -> Arc<Body>;
#[salsa::invoke(ExprScopes::expr_scopes_query)]
fn expr_scopes(&self, def: DefWithBodyId) -> Arc<ExprScopes>;
Move generic_params query to HIR
2019-11-20 17:33:18 +00:00
#[salsa::invoke(GenericParams::generic_params_query)]
fn generic_params(&self, def: GenericDefId) -> Arc<GenericParams>;
Move attrs query to hir_def
2019-11-23 08:14:10 +00:00
#[salsa::invoke(Attrs::attrs_query)]
fn attrs(&self, def: AttrDefId) -> Attrs;
Move lang_items to hir_def
2019-11-23 09:58:01 +00:00
#[salsa::invoke(LangItems::module_lang_items_query)]
fn module_lang_items(&self, module: ModuleId) -> Option<Arc<LangItems>>;
#[salsa::invoke(LangItems::crate_lang_items_query)]
fn crate_lang_items(&self, krate: CrateId) -> Arc<LangItems>;
#[salsa::invoke(LangItems::lang_item_query)]
fn lang_item(&self, start_crate: CrateId, item: SmolStr) -> Option<LangItemTarget>;
Move docs to hir_def
2019-11-23 11:43:38 +00:00
// FIXME(https://github.com/rust-analyzer/rust-analyzer/issues/2148#issuecomment-550519102)
// Remove this query completely, in favor of `Attrs::docs` method
#[salsa::invoke(Documentation::documentation_query)]
fn documentation(&self, def: AttrDefId) -> Option<Documentation>;
Querify `importable_locations_in_crate` This brings the time needed to compute the `add_missing_impl_members` assist down from ~5 minutes to 20 seconds
2020-05-18 19:42:39 +00:00
Add an ImportMap
2020-05-20 21:51:20 +00:00
#[salsa::invoke(ImportMap::import_map_query)]
fn import_map(&self, krate: CrateId) -> Arc<ImportMap>;
move raw_items to hir_def
2019-10-30 13:12:55 +00:00
}
Split `crate_def_map` into two methods This change: - introduces `compute_crate_def_map` query and renames `CrateDefMap::crate_def_map_query` for consistency, - annotates `crate_def_map` as `salsa::transparent` and adds a top-level `crate_def_map` wrapper function around that starts the profiler and immediately calls into `compute_crate_def_map` query. This allows us to better understand where we spent the time, in particular, how much is spent in the recomputaiton and how much in salsa. Example output (where we don't actually re-compute anything, but the query still takes a non-trivial amount of time): ``` 211ms - handle_inlay_hints 150ms - get_inlay_hints 150ms - SourceAnalyzer::new 65ms - def_with_body_from_child_node 65ms - analyze_container 65ms - analyze_container 65ms - Module::from_definition 65ms - Module::from_file 65ms - crate_def_map 1ms - parse_macro_query (6 calls) 0ms - raw_items_query (1 calls) 64ms - ??? ``` Signed-off-by: Michal Terepeta <michal.terepeta@gmail.com>
2020-01-03 12:59:46 +00:00
Normalize waiting queries names
2020-03-06 23:11:52 +00:00
fn crate_def_map_wait(db: &impl DefDatabase, krate: CrateId) -> Arc<CrateDefMap> {
let _p = profile("crate_def_map:wait");
db.crate_def_map_query(krate)
Split `crate_def_map` into two methods This change: - introduces `compute_crate_def_map` query and renames `CrateDefMap::crate_def_map_query` for consistency, - annotates `crate_def_map` as `salsa::transparent` and adds a top-level `crate_def_map` wrapper function around that starts the profiler and immediately calls into `compute_crate_def_map` query. This allows us to better understand where we spent the time, in particular, how much is spent in the recomputaiton and how much in salsa. Example output (where we don't actually re-compute anything, but the query still takes a non-trivial amount of time): ``` 211ms - handle_inlay_hints 150ms - get_inlay_hints 150ms - SourceAnalyzer::new 65ms - def_with_body_from_child_node 65ms - analyze_container 65ms - analyze_container 65ms - Module::from_definition 65ms - Module::from_file 65ms - crate_def_map 1ms - parse_macro_query (6 calls) 0ms - raw_items_query (1 calls) 64ms - ??? ``` Signed-off-by: Michal Terepeta <michal.terepeta@gmail.com>
2020-01-03 12:59:46 +00:00
}
Reference in a new issue Copy permalink