Commit graph

3769 commits

Author SHA1 Message Date
Georgios Bitzes
07df49a5af Fix bugs relating to hotkeys with modifiers
This commit makes the following changes:
1) Fix a bad check introduced in dee0bfb, which checks the modstate of the
event with the keysym of the switcher, not its modmask:

        modstate & ( switchers[i].keysym )

I think it was broken before as well, a binary AND between the two masks
will not tell much about whether they are equal. Instead, the masks are
now checked for equality after removing LockMask and NumlockMask.

2) Stop binding to AnyModifier when none is used. This conflicts with the case
in which we want to bind different modes to the same key, but different
modifiers.

for example, rofi -key-run F2 -key-ssh alt+F2 -key-window shift+F2

Binding F2 with AnyModifier would prevent alt+F2 and shift+F2 from being used.

3) Remove UngrabKey from x11_grab_key to make the above example possible.
4) Refactor search for any of the global keybindings into function locate_switcher.
2015-02-16 03:20:28 +02:00
QC
faf6a708dc Fix travis test. 2015-02-15 21:34:13 +01:00
QC
dee0bfb821 Fix #128: Better handling of keybindings and remove deprecated launching.
See manpage.
2015-02-15 21:15:16 +01:00
QC
b6652a0221 Small move 2015-02-14 19:42:04 +01:00
Dave Davenport
8347963ed8 Fix some warnings from clang-check. 2015-02-13 15:37:55 +01:00
Dave Davenport
7e1063803a Comments, compile order and Display argument. 2015-02-13 08:26:23 +01:00
QC
1b5d0d1ad1 Update copyright 2015-02-12 23:00:47 +01:00
QC
ee24b209bb Fixing i3 crash. 2015-02-12 22:42:29 +01:00
QC
4e55889223 Update indenting. 2015-02-12 22:34:33 +01:00
QC
877c8051c6 Update copyright license. 2015-02-12 22:34:06 +01:00
QC
c760432a6c Moving files around, dialogs in dialog directory. 2015-02-12 22:26:28 +01:00
Dave Davenport
605fe4911c Refactor code, split out window switcher code. 2015-02-12 22:16:32 +01:00
Dave Davenport
9240a636d4 Fix stupid typo in previous commit, swapping columns/rows in positioning textboxes. 2015-02-12 07:55:23 +01:00
Dave Davenport
f74c8c1839 Cleanup. 2015-02-11 23:07:55 +01:00
Dave Davenport
c5f95d4e25 Small comment updates. 2015-02-10 08:12:03 +01:00
Dave Davenport
472dc452d5 Update Changelog and Authors file. 2015-02-10 08:00:18 +01:00
Dave Davenport
a50219e903 Remove hmode. (Rather no implementation then a bad one.) 2015-02-10 07:42:40 +01:00
QC
e76db3fce3 Fix indenting. 2015-02-09 20:23:55 +01:00
QC
a69eb4e22c Simplify paste code. 2015-02-09 20:20:51 +01:00
QC
67cbd48c8b Add some comments, rename. 2015-02-09 20:05:30 +01:00
QC
f6bc8f7c32 Fix test compile warning. 2015-02-09 19:58:17 +01:00
Dave Davenport
682907d340 Splitting over more files. 2015-02-09 19:35:51 +01:00
Dave Davenport
f7eeaec60f Fix #126: Allow (simplistic) word movement and deletion.
* Ctrl-Alt-d: Delete word
        * Ctrl-Alt-h: Delete previous word
        * Alt-f: Forward one word
        * Alt-b: Backwards one word
2015-02-07 16:42:42 +01:00
Dave Davenport
00e48fdcf7 fix tiny typo 2015-02-07 14:04:57 +01:00
Dave Davenport
fda5badeb6 Fix #125: Use shift-left/right for moving between switchers. 2015-02-06 08:45:21 +01:00
Dave Davenport
b0b8a0c477 Merge pull request #124 from vimeitor/patch-1
Fix documentation
2015-02-05 08:13:39 +01:00
vimeitor
04378179b9 Fix documentation 2015-02-04 23:28:14 +01:00
Dave Davenport
9a197e4e04 Merge pull request #123 from hexchain/patch-1
Fix `-width' example value
2015-02-04 20:04:13 +01:00
Hexchain Tong
50c8476abc Fix `-width' example value
A full HD monitor should be 1920px wide.
2015-02-04 21:02:33 +08:00
Dave Davenport
d9aef65ea7 Cleanups. 2015-02-04 09:37:34 +01:00
Dave Davenport
63fd534ba2 Move data around, constness, etc. 2015-02-03 08:21:59 +01:00
Dave Davenport
f86cf8988b Move stuff around. Try to reduce size rofi.c. 2015-02-03 08:00:33 +01:00
QC
3a98c71fa1 Fix: #121 Print utf8 until invalid character. 2015-02-02 16:44:08 +01:00
Dave Davenport
e42a60f87a Remove i3 build in travis... it is to old. 2015-02-02 15:08:44 +01:00
Dave Davenport
65abc093ca Install i3-wm in travin and compile with and without. 2015-02-02 14:56:05 +01:00
Dave Davenport
ca876feec6 Put i3 specific interaction code in separate file. 2015-02-02 14:49:19 +01:00
QC
d081b3e6f5 Fix #119. Fix dmenu mode when called with full path. 2015-02-01 20:15:21 +01:00
Dave Davenport
1a590aa8df Do not lock rofi when in daemon mode, only when showing. 2015-02-01 15:17:43 +01:00
Dave Davenport
5d4ab2e626 Always compile with Extra warnings. 2015-02-01 15:12:29 +01:00
Dave Davenport
1156c19cbf Fix compiler warnings about signed v.s. unsigned 2015-02-01 15:00:01 +01:00
Dave Davenport
382b93ae03 Fix LLVM compiler warnings. 2015-02-01 10:43:28 +01:00
Dave Davenport
97c11d7d85 Fix compiler warnings. (return value ftrunc/write) 2015-02-01 10:03:16 +01:00
QC
b74e6b791a Fix not grabbing keyboard, and add pid file to ensure one instance. 2015-01-31 18:23:17 +01:00
QC
983fff61b4 Removed some unused headers. 2015-01-30 21:55:31 +01:00
QC
6760d05d18 Small cleanup + comments. 2015-01-30 18:01:25 +01:00
Dave Davenport
f40e072802 Grab keyboard from X mainloop.
Should fix small 'jerk' when starting from keybinding and having to wait for keyboard grab.
2015-01-29 17:37:12 +01:00
QC
de9e78bb57 Fix issue #118.
unsigned long is %lu not %ul
2015-01-28 21:27:49 +01:00
Dave Davenport
1ad7f755c7 Update build instructions. 2015-01-28 12:36:23 +01:00
Dave Davenport
b469674085 Add some comments. 2015-01-28 07:50:47 +01:00
Dave Davenport
836036574b Add file browser example.
-switchers "file:rofi-file-browser.sh" -show file
2015-01-28 07:49:52 +01:00