Commit graph

166 commits

Author SHA1 Message Date
Dave Davenport
294a22f3dd Fix some memory leaks. 2021-09-06 21:26:04 +02:00
Dave Davenport
c64565e877 [CppCheck] Fix some shadowing variables. 2021-08-21 01:08:40 +02:00
Dave Davenport
e60e6bab2a [Doc] Try to fix some of the doxygen coverage warnings. 2021-08-20 11:37:03 +02:00
Dave Davenport
954fc728b2 [Cleanup] Using clang-tidy 2021-08-18 01:16:45 +02:00
a1346054
c62137f8ab
Simple maintenance improvements (#1370)
* rofi moved to libera.chat

* unify some theme headers and whitespace

* consistently use the same hashbang for bash

* improve obsolete way of testing equality

see https://github.com/koalaman/shellcheck/wiki/SC2268 for explanation

* use consistent function definitions in bash scripts

* remove duplicated author and fix whitespace

* quote all variables in scripts

fixes many warnings identified through shellcheck

* fix whitespace in scripts

* fix whitespace in non-source files

* fix spelling in non-source files

* fix whitespace and indentation in source files

* fix spelling in source files
2021-08-14 13:03:16 +02:00
Dave Davenport
f72bae02bb [DRun] Add advanced parse-user and parse-system config option. 2021-06-15 16:19:57 +02:00
Zachary Freed
44140ac5b4
Made it so the presence of a field in drun-display-format is enough to parse the .desktop files for that field. Also fixed helper_string_replace_if_exists only allowing one guarded field in the display format by making the regex ungreedy (#911)
Co-authored-by: Dave Davenport <DaveDavenport@users.noreply.github.com>
2021-06-15 14:32:46 +02:00
Dave Davenport
9d85bcb914 Update copyright header. 2021-06-09 14:50:39 +02:00
Dave Davenport
3950204760 [DRun] Do not use show-icons options, handle no-icon desktopfile better. 2021-06-09 01:20:36 +02:00
Dave Davenport
cb250fa73a Add fallback icon option. 2021-06-08 20:21:28 +02:00
Dave Davenport
6178970499 [DRun] Only go to file completer if desktop file support url. 2021-06-08 19:35:51 +02:00
Dave Davenport
6b9de4644e [DRun] Add file completer to drun mode.
Add icons to run mode.
2021-06-08 19:28:13 +02:00
Dave Davenport
3b297ee80d Re-indent the code using indenter. 2021-06-01 10:44:23 +02:00
Dave Davenport
ac179cd2d9 [DRun] Add support for service files
Untested as I do not have these files myself.

Issue: #1152
2021-05-30 23:21:42 +02:00
Dave Davenport
2c30035640 [DRun] Fix sorting when name is NULL.
Thanks to nick87720z
2021-05-23 00:31:38 +02:00
Dave Davenport
a3f12837cb Partially fix switching between modi, does not work for script mode.
Issue: #1286
2021-04-10 23:04:05 +02:00
Dave Davenport
7061eb21ae Indent round. 2020-11-03 23:57:02 +01:00
Dave Davenport
011908e1ff
issue 1187: If error on launching application, show error message and return to list` (#1193)
* Show error message, then possibly pop back to main window.

Fix drun/run dialog to use this for command execution.

Issue #1187

* [Combi] When no line selected, handle using the first entry.

* [Window] Add execute on invalid input to window dialog.

* Update view.h doxygen docu

* Update manpage with running application changes.
2020-09-13 21:56:25 +02:00
Dave Davenport
bff8948116 [DRun] Fix broken cache after URL type was added. 2020-09-09 22:46:18 +02:00
nick87720z
96cd34d24f
Fix and optimize 20200908 (#1184)
* combi: Reuse own get_num_entries in self-init

* combi_mode_parse_switchers: Remove duplicated mode pointer

* combi_mode_parse_switchers: Regroup mode search lines

* combi_mode_result: Simplify switcher search quit

* mode_result: Check for mode switch actions before hook

These are over-mode actions, which should not be handled
in mode hooks at all.
2020-09-08 17:30:03 +02:00
Dave Davenport
30735791b4 Run indenter. 2020-08-28 16:41:59 +02:00
Mike Dalessio
5bec191d2e
Follow Type=Link standard desktop entries with drun (#1168)
* [DRun] Introduce data structure changes for Link desktop entries

From the [freedesktop spec][1]:

> This specification defines 3 types of desktop entries:
> Application (type 1), Link (type 2) and Directory (type 3). To allow
> the addition of new types in the future, implementations should
> ignore desktop entries with an unknown type.

This commit adds an enum to capture these types, and adds `type` to
DRunModeEntry.

  [1]: https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html

part of #1166

* [DRun] Sanity check Link entries and capture the URL

Note that we're introducing some logic that will differ depending on
the Desktop entry type (Application or Link). The logic is:

- if entry is Application type,
  - then Exec is required
  - and the value is saved in .exec
  - and drun_mode_result calls exec_cmd_entry
- if entry is Link type,
  - then URL is required (but is not saved in the DRunModeEntry)
  - and drun_mode_result calls new function launch_link_entry

part of #1166

* [DRun] Launch desktop links via xdg-open

Note that this introduces a new dependency on xdg-open, which may not
be installed. In that case, rofi will display an error dialog
with something like:

  "Failed to execute child process xdg-open (No such file or directory)"

which hopefully is explanatory enough for folks.

part of #1166

* Make drun options comments consistent and add a bit of whitespace

* [DRun] new config option drun-url-launcher for opening links

In previous commit, this was a hard-coded string.

part of #1166
2020-08-26 21:10:04 +02:00
Dave Davenport
1104d1d53a [DRun] cleanup debug message. 2020-04-15 19:08:01 +02:00
Dave Davenport
0214d5a6e4 [DRun] Adding %% as escape character. 2020-04-15 19:06:39 +02:00
Dave Davenport
b169289996 Indent all the code. 2020-02-02 13:56:37 +01:00
Dave Davenport
a35a898816 [DRun] Add desktop cache
Add a desktop cache file. Usable for system with slow filesystems.

* -drun-use-desktop-cache
* -drun-reload-desktop-cache

Fixes: #1040
2020-01-26 12:47:04 +01:00
Dave Davenport
b03edc5cf3 Update copyright dates. 2020-01-01 12:23:12 +01:00
Dave Davenport
8d9e403659 Update copyright. 2019-09-27 11:58:32 +02:00
Dave Davenport
aa35ecc40a [DRun] Add keywords to match and printing. 2019-08-20 22:51:07 +02:00
Dave Davenport
204008d389 [DRun] Do not run custom command in drun mode.
Fixes: #966
2019-08-09 20:08:41 +02:00
Dave Davenport
f896146217 [DRUN] Add option to only show desktop files in certain categories
closes: #817
2019-08-09 19:33:23 +02:00
Dave Davenport
335adc30b3 [DRun] Fix sorting of drun.
Thanks to ChrisJAllan
2019-02-17 20:42:14 +01:00
Dave Davenport
fbd34c9635 [DRun] Sort the (non history) entries by name. Escape for pango. 2019-02-10 14:15:35 +01:00
Dave Davenport
964af7ad35 [DRUN] Fix small memory leak loading desktop files. 2019-01-29 09:29:47 +01:00
Dave Davenport
76ceac1f20 [DRUN] Add drun-display-format. 2018-10-17 23:02:50 +02:00
Dave Davenport
11afb8e678 [Icon] Fix loading icons that are already in cache.
fixes: #860
2018-10-05 11:01:48 +02:00
Dave Davenport
859a9c79d6 Indent the code. 2018-08-08 15:55:13 +02:00
Dave Davenport
4538303be6 [DRUN] Add option to show actions in drun.
Fixes: #836
2018-07-28 11:12:11 +02:00
Dave Davenport
b837c3fdff Change log domain from Utils.IconFetcher to Helpers.IconFetcher
Matches doxygen.
2018-06-12 11:47:03 +02:00
Dave Davenport
441c511296
Add an generic icon fetcher that can be used by any widget and re-uses the main threadpool.
Add an generic icon fetcher that can be used by any widget and re-uses the main threadpool.

* Make threadpool more generic usable.
* Add generic icon fetcher, that caches icons.
* Make DRUN use this fetcher.
* Add icon widget.

#809
2018-06-09 19:13:57 +02:00
Dave Davenport
6abc8c920c DRun: Allow to select based on comment field.
Fixes: #733
2017-12-09 19:55:39 +01:00
Quentin Glidic
53e0f957d0
drun: Early return if already initialized
Signed-off-by: Quentin Glidic <sardemff7+git@sardemff7.net>
2017-12-09 10:34:11 +01:00
Quentin Glidic
955cdf5ba5
drun: Standardize debug messages
Signed-off-by: Quentin Glidic <sardemff7+git@sardemff7.net>
2017-11-17 14:20:03 +01:00
Dave Davenport
9cd1e3fac2 Indent 2017-11-07 20:04:07 +01:00
Dave Davenport
e689f2d98b Check result g_key_file_load_from_file to make coverity happy. 2017-11-05 21:32:43 +01:00
Dave Davenport
f7d7fd4573
[DRun] Obey OnlyShowIn NotShowIn (#715)
* [DRun] Obey OnlyShowIn NotShowIn

* Replace g_strv_contains.
2017-11-02 21:05:07 +01:00
Askrenteam
0dc71fcc00 Added option -name-only to match only desktop entry name with drun (#690)
* Added option -name-only to match only desktop entry name with drun

* fixed indent and xrdump test

* fixed test

* option -drun-match-fields

* option -window-match-fields

* matching fields as static in window/drun + enums for field indexes

* prevent window_mode_parse_fields() from executing twice
2017-10-21 11:18:52 +02:00
Quentin Glidic
af81a54adf
drun: Load absolute path icons properly
This was lost in the rework commit
4d8784cf85 and never added back.

Fixes #701

Signed-off-by: Quentin Glidic <sardemff7+git@sardemff7.net>
2017-10-20 22:53:17 +02:00
Dave Davenport
9ae62960c1 Indent files. 2017-10-05 17:45:50 +02:00
Dave Davenport
6ba31683c6 [DRun] Desktop id is not equal to application id. 2017-10-04 08:59:09 +02:00