dvdsk
1ed1197cfd
style, removes a needless clone()
...
Was needed before a cargo update call. Update to cpal made the type
copy though.
2024-04-06 12:14:08 +02:00
dvdsk
a4d167f9ec
fix(seek) conditional compilation
2024-04-06 12:07:31 +02:00
dvdsk
34366fe656
style clippy fixes
2024-04-06 12:02:51 +02:00
dvdsk
6f1f44f04a
Merge branch 'master' into seek_runtime_err
2024-04-06 12:00:17 +02:00
dvdsk
7cf0451a1e
fix(seek/delay) seek < delay duration ate up the delay
2024-04-05 15:14:06 +02:00
dvdsk
aa0880ddee
seek/error symphonia seekerror is now more precise
2024-04-05 13:59:40 +02:00
dvdsk
6034af32fe
fix(decoder/symphonia) seek is no longer off
2024-04-05 13:31:29 +02:00
dvdsk
40a9447fa1
refactor(decoder/sympthonia) use for loop instead loop + match & escape
...
More readable, prep for using the same lines in new refine_position fn.
Since that is already pretty complex this needed to be made simpler.
This code retries on all errors not only decode errors. Retries will not
work on anything else then a decode error however they also wont cause
any problems. Not checking the result does however make the code
simpler.
2024-04-05 13:28:16 +02:00
dvdsk
a52a41bd86
refactor(decoder/symphonia) logic reorderd
2024-04-04 23:47:47 +02:00
dvdsk
f846cdf38d
fix(seek) hound(wav) now keeps channel order consistent
2024-04-04 23:36:01 +02:00
dvdsk
26e9db7b87
remove seek support for (lewton) vorbis
...
seek is broken, https://github.com/RustAudio/lewton/issues/73 .
We could work around it by:
- using unsafe to create an instance of Self
- use mem::swap to turn the &mut self into a mut self
- take out the underlying Read+Seek
- make a new self and seek
If this issue is fixed use the implementation in
commit: 3bafe32388
2024-04-04 12:54:09 +02:00
dvdsk
3bafe32388
refactor(seek) explain why seek to sample works
2024-04-03 14:04:59 +02:00
dvdsk
4e14b0acea
Vorbis actually can be implemented since the sample rate is constant
...
This reverts commit 80add81532
2024-04-03 13:49:10 +02:00
dvdsk
80add81532
removes seeking from vorbis decoder, can not be implemented
2024-04-03 13:08:21 +02:00
dvdsk
5562241f39
commit to save work on vorbis try_seek
2024-04-03 13:02:30 +02:00
dvdsk
1c821362fd
fix(seek) vorbis decoder now respects channel order
2024-04-03 12:40:59 +02:00
dvdsk
d0fce09bb0
fix(seek) vorbis decoder crashing when seeking
2024-04-03 11:45:17 +02:00
David Kleingeld
e0485beb06
Merge pull request #559 from ideka/fix-channel-upscaling
...
Fix channel count upscaling
2024-04-01 21:00:30 +02:00
dvdsk
766fbbf1fa
implement try_seek for SamplesBuffer
2024-04-01 14:16:56 +02:00
Gerardo Marset
2f3daa9e6c
Fix size_hint bug, improve size_hint test
2024-03-31 05:02:30 +01:00
Gerardo Marset
a5f06750ef
Clarify some code, fix small docs typo
2024-03-27 02:53:11 +01:00
Gerardo Marset
e6424ffd0a
Update size_hint to work with previous changes
...
Update tests as well.
2024-03-27 02:50:57 +01:00
David Kleingeld
e0b8e9bb57
Merge pull request #563 from RustAudio/clippy_warnings
...
This fixes all clippy warnings
2024-03-26 18:19:30 +01:00
dvdsk
77ca23a450
This fixes all clippy warnings
...
Made an issue for missing `is_empty()`, see:
https://github.com/RustAudio/rodio/issues/562
The DecoderImpl enum triggerd large_enum_variant. There is not an easy
fix for that. We could box the VorbisDecoder but at 572 bytes
I really do not think thats worth it. Annotated it with an allow
2024-03-26 12:35:36 +01:00
Gerardo Marset
41604cf54c
Avoid duplicating signals when upscaling channels
...
Mono -> stereo remain the only exception.
2024-03-26 12:07:10 +01:00
Hamir Mahal
a2c2548a4d
refactor: remove unnecessary let binding
2024-03-26 02:01:29 -07:00
Hamir Mahal
371d9634f2
refactor: remove unnecessary Box::new conversion
2024-03-25 10:40:33 -07:00
Hamir Mahal
93d8215d7b
refactor: remove unnecessary Box from into_inner
2024-03-25 00:29:02 -07:00
Gerardo Marset
6de6f22a12
Fix channel count upscaling
...
This changes channel upscaling so all input samples are spread out
across the output channels, instead of repeating the last sample over
and over. This approach should yield more accurate results. Fixes #558 .
2024-03-25 01:08:35 +01:00
Hamir Mahal
616ee26756
refactor: remove unnecessary Default::default() ( #557 )
2024-03-24 19:29:11 +01:00
Hamir Mahal
0466f60c94
refactor: remove reference that is unnecessary ( #556 )
2024-03-20 18:14:21 +01:00
Hamir Mahal
9289947974
fix: failing nightly CI tests ( #554 )
2024-03-18 19:07:12 +01:00
Hamir Mahal
f88a759d8b
refactor: remove unnecessary casting ( #552 )
2024-03-18 19:03:57 +01:00
Hamir Mahal
1d3a37a594
refactor: replace seek(SeekFrom::Current(0)) ( #551 )
...
with more concise `stream_position()`
2024-03-10 17:02:55 +01:00
Matty
01ec33f40b
Lift Sink::clear into SpatialSink ( #548 )
2024-03-10 05:33:33 +01:00
Hamir Mahal
77c5c5485c
refactor: remove unnecessary clone() calls ( #550 )
2024-03-10 03:15:03 +01:00
Hamir Mahal
698ca2d5c2
refactor: remove returns that are unnecessary ( #549 )
2024-03-08 17:56:34 +01:00
dvdsk
fb44f71dc9
Fixes seek example and various spell/grammar issues
...
Co-authored-by: naglis <827324+naglis@users.noreply.github.com>
2024-01-31 14:53:10 +01:00
dvdsk
4dea149dc2
fixes spell errors in docs and SeekError
2024-01-26 21:23:04 +01:00
dvdsk
470eba8328
Merge branch 'master' into seek_runtime_err
2024-01-26 21:21:34 +01:00
0Ahmed-0
8e604cfc08
chore: fix a typo ( #537 )
2024-01-07 15:17:46 +01:00
Alphyr
1b9c1933b3
Add Decoder::new_vorbis when symphonia-vorbis feature is enabled ( #529 )
2023-12-25 02:52:11 +01:00
dexterdy
e153a193ed
impl source for mut references ( #532 )
2023-12-25 01:36:26 +01:00
willxw
35dc35f426
Update sink.rs ( #521 )
2023-10-23 14:06:28 +02:00
dvdsk
57f2a3ca36
cargo fmt
2023-10-21 21:32:43 +02:00
David Kleingeld
50a781a093
Merge branch 'master' into seek_runtime_err
2023-10-21 21:00:51 +02:00
Alphyr
8eaa226cef
Fix build with minimp3 ( #519 )
2023-10-20 23:27:40 +02:00
David Kleingeld
b7b5735afe
Merge branch 'master' into seek_runtime_err
2023-10-17 13:21:21 +02:00
willxw
98bae98d05
added q value parameter to be passed to filter functions ( #515 )
...
I have added a 2nd parameter to the filter functions low_pass, high_pass, to_low_pass, and to_high pass; allowing a q value to be passed along with the frequency.
Co-authored-by: David Kleingeld <git@davidsk.dev>
2023-10-17 12:32:17 +02:00
David Kleingeld
5dd41356e8
Remove duplicate doc section and fix spelling in docs
...
Co-authored-by: naglis <827324+naglis@users.noreply.github.com>
Co-authored-by: naglis <827324+naglis@users.noreply.github.com>
2023-10-13 16:49:33 +02:00
