David Kleingeld
23fe481fcb
Merge pull request #582 from apolunar/fix_m4a_mp4a_decode_seek
...
Fix m4a and mp4a playback
2024-06-06 23:40:04 +02:00
apolunar
eac5a32f3d
improved error handling pt 2
2024-06-06 16:29:36 -05:00
apolunar
5f1b057b14
improved error handling
2024-06-05 09:37:28 -05:00
apolunar
3bc964737c
fix formatting, error handling, and remove uneccesary features
2024-06-02 18:27:23 -05:00
apolunar
6bbd95ed83
fix clippy complaint that the struct is overdeclared
2024-06-01 21:00:10 -05:00
apolunar
d08d9e71a6
re-disable symphonia-isomp4 test due to (upstream?) failure
2024-06-01 20:55:45 -05:00
apolunar
b712559418
possibly fixed m4a and mp4a playback
2024-06-01 13:44:53 -05:00
David Kleingeld
ee73f6d97d
Merge pull request #579 from RustAudio/fix_hang_seek_on_empty_queue
...
Fix hang seek on empty queue
2024-05-23 13:33:33 +02:00
dvdsk
3d61bddd03
fmt
2024-05-23 13:27:03 +02:00
dvdsk
d6e64dc80c
disables known broken decoder in test (see #577 )
2024-05-23 13:18:29 +02:00
dvdsk
7cd55a1bb3
increment version (patch) and update changelog
2024-05-23 13:15:36 +02:00
dvdsk
66cbef992b
Merge branch 'master' into fix_hang_seek_on_empty_queue
2024-05-23 13:10:49 +02:00
dvdsk
7473837814
add test checking for #578
2024-05-23 13:10:37 +02:00
dvdsk
749a4845a2
check if any sound is playing before waiting for seek result
2024-05-23 13:07:09 +02:00
dvdsk
11221a8609
fixes typo in test
2024-05-05 10:46:02 +02:00
dvdsk
97cff09fe2
Fixes two clippy lint issues
...
Clippy updated and has a new lint regarding clone efficiency. This was
not yet a thing when the previous version was prepared.
2024-05-05 10:39:56 +02:00
dvdsk
50f0177b74
Merge branch 'master' of github.com:RustAudio/rodio
2024-05-05 10:29:28 +02:00
dvdsk
2eb6246884
release 0.18.0
2024-05-05 10:28:50 +02:00
David Kleingeld
149443717f
Merge pull request #575 from senlizishi/document
...
Add comment about Sink and OutputStream
2024-04-22 11:00:33 +02:00
weixubin
0b1bdb9bfa
fix
2024-04-22 16:56:59 +08:00
weixubin
934b1c0525
Add comment about Sink and OutputStream
2024-04-22 16:20:14 +08:00
David Kleingeld
a618afccf9
Merge pull request #574 from RustAudio/fix_cpal_version
...
The cpal version requirement is too low causing #573
2024-04-21 17:26:01 +02:00
dvdsk
1d15760f3e
The cpal version requirement is too low causing #573
...
Specifically cpal changed `SupportedStreamConfigRange` and made it Copy.
As that relaxes the requirements on it its a non breaking change. Rodio was
then refactored to remove the now no longer needed `.clone()` in 77c5c54
2024-04-21 12:52:29 +02:00
David Kleingeld
a9045662b2
Merge pull request #572 from hamirmahal/refactor/replace-archived-action-with-similar-functionality
...
refactor: replace archived action
2024-04-20 10:36:26 +02:00
Hamir Mahal
799ed85f87
refactor: replace archived action
2024-04-20 00:57:02 -07:00
David Kleingeld
e51594892a
Merge pull request #570 from hamirmahal/fix/usage-of-deprecated-version-of-nodejs
...
fix: usage of `deprecated` version of `Node.js`
2024-04-16 21:35:29 +02:00
Hamir Mahal
e036e43fe5
fix: usage of deprecated version of Node.js
2024-04-16 11:06:13 -07:00
David Kleingeld
cefb123311
Merge pull request #568 from YXL76/patch-1
...
fix: no variant found for `source::SeekError`
2024-04-13 20:09:24 +02:00
兰陈昕
85c35c317c
Update mod.rs
2024-04-13 23:15:41 +08:00
dvdsk
818f557466
docs(changelog) adds missing entry to changelog
2024-04-06 13:06:31 +02:00
David Kleingeld
d103517b19
Merge pull request #513 from dvdsk/seek_runtime_err
...
Implements Seek
2024-04-06 12:34:48 +02:00
dvdsk
1ed1197cfd
style, removes a needless clone()
...
Was needed before a cargo update call. Update to cpal made the type
copy though.
2024-04-06 12:14:08 +02:00
dvdsk
bbc8f00a34
update changelog
2024-04-06 12:11:19 +02:00
dvdsk
b49b22af88
Merge branch 'master' into seek_runtime_err
2024-04-06 12:08:41 +02:00
dvdsk
a4d167f9ec
fix(seek) conditional compilation
2024-04-06 12:07:31 +02:00
dvdsk
34366fe656
style clippy fixes
2024-04-06 12:02:51 +02:00
David Kleingeld
2a7b351345
Merge pull request #565 from RustAudio/add_unreleased_section_to_changelog
...
The changelog is now in 'keep a changelog' format
2024-04-06 12:01:00 +02:00
dvdsk
6f1f44f04a
Merge branch 'master' into seek_runtime_err
2024-04-06 12:00:17 +02:00
dvdsk
7cf0451a1e
fix(seek/delay) seek < delay duration ate up the delay
2024-04-05 15:14:06 +02:00
dvdsk
aa0880ddee
seek/error symphonia seekerror is now more precise
2024-04-05 13:59:40 +02:00
dvdsk
6034af32fe
fix(decoder/symphonia) seek is no longer off
2024-04-05 13:31:29 +02:00
dvdsk
40a9447fa1
refactor(decoder/sympthonia) use for loop instead loop + match & escape
...
More readable, prep for using the same lines in new refine_position fn.
Since that is already pretty complex this needed to be made simpler.
This code retries on all errors not only decode errors. Retries will not
work on anything else then a decode error however they also wont cause
any problems. Not checking the result does however make the code
simpler.
2024-04-05 13:28:16 +02:00
dvdsk
1fcf4b8363
test(seek) made channel order more brittle
2024-04-05 12:16:06 +02:00
dvdsk
a52a41bd86
refactor(decoder/symphonia) logic reorderd
2024-04-04 23:47:47 +02:00
dvdsk
f846cdf38d
fix(seek) hound(wav) now keeps channel order consistent
2024-04-04 23:36:01 +02:00
dvdsk
7eb13be288
(tests) use rstest to refactor and expand seek test
...
This adds two dependencies, they are only needed for the test suite.
Compile time will not increase for users. The extra overhead when
running the test suite is worth it imho. The test file is significantly
shorter and there is less code duplication. A run time solution would
decrease the test interface (you would have to manually find out which
params caused the test).
2024-04-04 21:22:53 +02:00
dvdsk
26e9db7b87
remove seek support for (lewton) vorbis
...
seek is broken, https://github.com/RustAudio/lewton/issues/73 .
We could work around it by:
- using unsafe to create an instance of Self
- use mem::swap to turn the &mut self into a mut self
- take out the underlying Read+Seek
- make a new self and seek
If this issue is fixed use the implementation in
commit: 3bafe32388
2024-04-04 12:54:09 +02:00
dvdsk
3bafe32388
refactor(seek) explain why seek to sample works
2024-04-03 14:04:59 +02:00
dvdsk
4e14b0acea
Vorbis actually can be implemented since the sample rate is constant
...
This reverts commit 80add81532
2024-04-03 13:49:10 +02:00
dvdsk
80add81532
removes seeking from vorbis decoder, can not be implemented
2024-04-03 13:08:21 +02:00
