Commit graph

929 commits

Author SHA1 Message Date
Gerardo Marset
a5f06750ef Clarify some code, fix small docs typo 2024-03-27 02:53:11 +01:00
Gerardo Marset
e6424ffd0a Update size_hint to work with previous changes
Update tests as well.
2024-03-27 02:50:57 +01:00
David Kleingeld
e0b8e9bb57
Merge pull request #563 from RustAudio/clippy_warnings
This fixes all clippy warnings
2024-03-26 18:19:30 +01:00
dvdsk
77ca23a450
This fixes all clippy warnings
Made an issue for missing `is_empty()`, see:
https://github.com/RustAudio/rodio/issues/562

The DecoderImpl enum triggerd large_enum_variant. There is not an easy
fix for that. We could box the VorbisDecoder but at 572 bytes
I really do not think thats worth it. Annotated it with an allow
2024-03-26 12:35:36 +01:00
David Kleingeld
daa07dc013
Merge pull request #561 from hamirmahal/refactor/remove-unnecessary-let-binding
refactor: remove unnecessary `let` binding
2024-03-26 12:21:04 +01:00
Gerardo Marset
41604cf54c Avoid duplicating signals when upscaling channels
Mono -> stereo remain the only exception.
2024-03-26 12:07:10 +01:00
Hamir Mahal
a2c2548a4d
refactor: remove unnecessary let binding 2024-03-26 02:01:29 -07:00
David Kleingeld
8d8b5dae21
Merge pull request #560 from hamirmahal/refactor/remove-unnecessary-box
refactor: remove unnecessary `Box` from `SymphoniaDecoder::into_inner`. 

The `SymphoniaDecoder` struct is small enough it fits on the stack without issues and its `into_inner` member is not part of the public API.
2024-03-25 22:49:50 +01:00
Hamir Mahal
371d9634f2
refactor: remove unnecessary Box::new conversion 2024-03-25 10:40:33 -07:00
Hamir Mahal
93d8215d7b
refactor: remove unnecessary Box from into_inner 2024-03-25 00:29:02 -07:00
Gerardo Marset
6de6f22a12 Fix channel count upscaling
This changes channel upscaling so all input samples are spread out
across the output channels, instead of repeating the last sample over
and over. This approach should yield more accurate results. Fixes #558.
2024-03-25 01:08:35 +01:00
Hamir Mahal
616ee26756
refactor: remove unnecessary Default::default() (#557) 2024-03-24 19:29:11 +01:00
Hamir Mahal
0466f60c94
refactor: remove reference that is unnecessary (#556) 2024-03-20 18:14:21 +01:00
Hamir Mahal
9289947974
fix: failing nightly CI tests (#554) 2024-03-18 19:07:12 +01:00
Hamir Mahal
f88a759d8b
refactor: remove unnecessary casting (#552) 2024-03-18 19:03:57 +01:00
Hamir Mahal
1d3a37a594
refactor: replace seek(SeekFrom::Current(0)) (#551)
with more concise `stream_position()`
2024-03-10 17:02:55 +01:00
Matty
01ec33f40b
Lift Sink::clear into SpatialSink (#548) 2024-03-10 05:33:33 +01:00
Hamir Mahal
77c5c5485c
refactor: remove unnecessary clone() calls (#550) 2024-03-10 03:15:03 +01:00
Hamir Mahal
698ca2d5c2
refactor: remove returns that are unnecessary (#549) 2024-03-08 17:56:34 +01:00
François
4688432c4b
expose feature for shared stdcxx from cpal (#546) 2024-03-05 13:03:19 +01:00
Anatol Ulrich
fee5e94066
always seek to start in mp3::is_mp3() (#543) 2024-02-10 13:52:51 +01:00
dvdsk
fb44f71dc9
Fixes seek example and various spell/grammar issues
Co-authored-by: naglis <827324+naglis@users.noreply.github.com>
2024-01-31 14:53:10 +01:00
dvdsk
4dea149dc2
fixes spell errors in docs and SeekError 2024-01-26 21:23:04 +01:00
dvdsk
470eba8328
Merge branch 'master' into seek_runtime_err 2024-01-26 21:21:34 +01:00
0Ahmed-0
8e604cfc08
chore: fix a typo (#537) 2024-01-07 15:17:46 +01:00
Alphyr
1b9c1933b3
Add Decoder::new_vorbis when symphonia-vorbis feature is enabled (#529) 2023-12-25 02:52:11 +01:00
dexterdy
e153a193ed
impl source for mut references (#532) 2023-12-25 01:36:26 +01:00
est31
4973f330e0
Release 0.17.3 (#522) 2023-10-23 14:50:26 +02:00
willxw
35dc35f426
Update sink.rs (#521) 2023-10-23 14:06:28 +02:00
dvdsk
57f2a3ca36
cargo fmt 2023-10-21 21:32:43 +02:00
David Kleingeld
50a781a093
Merge branch 'master' into seek_runtime_err 2023-10-21 21:00:51 +02:00
Alphyr
8eaa226cef
Fix build with minimp3 (#519) 2023-10-20 23:27:40 +02:00
Petr Gladkikh
08207b1aca
Merge branch 'master' into configurable-buffer-size 2023-10-20 10:52:58 +02:00
David Kleingeld
b7b5735afe
Merge branch 'master' into seek_runtime_err 2023-10-17 13:21:21 +02:00
est31
6a255fe70a
Release 0.17.2 (#518) 2023-10-17 12:41:00 +02:00
willxw
98bae98d05
added q value parameter to be passed to filter functions (#515)
I have added a 2nd parameter to the filter functions low_pass, high_pass, to_low_pass, and to_high pass; allowing a q value to be passed along with the frequency.

Co-authored-by: David Kleingeld <git@davidsk.dev>
2023-10-17 12:32:17 +02:00
David Kleingeld
5dd41356e8
Remove duplicate doc section and fix spelling in docs
Co-authored-by: naglis <827324+naglis@users.noreply.github.com>

Co-authored-by: naglis <827324+naglis@users.noreply.github.com>
2023-10-13 16:49:33 +02:00
David Kleingeld
8c774628fe
use From<f64> instead of custom time_from_duration
remove now unused time_from_duration

Co-authored-by: naglis <827324+naglis@users.noreply.github.com>
2023-10-13 15:47:38 +02:00
David Kleingeld
7357f191b8
remove commented out dead code in tests/seek.rs
Co-authored-by: naglis <827324+naglis@users.noreply.github.com>
2023-10-13 15:47:38 +02:00
dvdsk
c2c85e2332
improve seek beyond end documentation 2023-10-13 15:47:38 +02:00
dvdsk
963a48491f
refactors symphonia try_seek 2023-10-13 15:47:38 +02:00
dvdsk
b26194df91
make cargo fmt happy 2023-10-13 15:47:38 +02:00
dvdsk
724df4d884
completely remove sink usage from seek tests 2023-10-13 15:47:38 +02:00
dvdsk
a24e0e65eb
speeds up correct_remaining_playtime test 2023-10-13 15:47:38 +02:00
dvdsk
d1a809feac
formats everything with cargo fmt 2023-10-13 15:47:28 +02:00
dvdsk
82bfa417ff
fixes seek in m4a files, fixes seeking having 1 second granularity 2023-10-13 15:47:01 +02:00
dvdsk
3f4b530a42
Language and spelling fixes by @naglis
fix comment typo

Co-authored-by: naglis <827324+naglis@users.noreply.github.com>
2023-10-13 15:46:53 +02:00
dvdsk
4237effbf4
revert to upstream non-seekable minimp3, comment out minimp3-seek support 2023-10-13 15:45:40 +02:00
dvdsk
560961fc8b
adds try_seek to spatial source 2023-10-13 15:45:40 +02:00
dvdsk
f3a1966348
symphonia throws error if duration is unknown and seek is beyond source length 2023-10-13 15:45:40 +02:00