Mirrors/responsively-app
2
0
Fork 0
mirror of https://github.com/responsively-org/responsively-app synced 2024-11-10 06:44:13 +00:00
Code Issues Projects Releases Packages Wiki Activity

"Refactor popup.js: Extract functions into useCallback, simplify useEffect callbacks, and remove unnecessary returns."

Browse source
This commit is contained in:
aryan262 2024-09-09 12:17:36 +05:30
parent 61fc5377b5
commit 6157de24fa
1 changed files with 26 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
browser-extension/src/popup.js
View file

@ -27,28 +27,23 @@ const isChrome = () => {
const URLOpenerNonChrome = () => {
const [status, setStatus] = useState("loading");
useEffect(() => {
(async () => {
const [tab] = await window.browser.tabs.query({
currentWindow: true,
active: true,
});
if (!tab || !tab.url) {
setStatus("false");
return;
}
openCustomProtocolURI(
`responsively://${tab.url}`,
() => {
setStatus("false");
},
() => {
setStatus("true");
}
);
})();
const checkProtocolAndUpdateStatus = useCallback(async () => {
const [tab] = await window.browser.tabs.query({ currentWindow: true, active: true });
if (!tab || !tab.url) {
setStatus("false");
return;
}
openCustomProtocolURI(
`responsively://${tab.url}`,
() => setStatus("false"),
() => setStatus("true")
);
}, []);
useEffect(() => {
checkProtocolAndUpdateStatus();
}, [checkProtocolAndUpdateStatus]);
if (status === "loading") {
return (
<div className="popup">
@ -87,23 +82,20 @@ const URLOpenerNonChrome = () => {
};
const URLOpenerChrome = () => {
const updateTabURL = useCallback(async () => {
const [tab] = await window.browser.tabs.query({ currentWindow: true, active: true });
if (!tab || !tab.url) {
return;
}
window.browser.tabs.update({ url: `responsively://${tab.url}` });
}, []);
useEffect(() => {
(async () => {
const [tab] = await window.browser.tabs.query({
currentWindow: true,
active: true,
});
if (!tab || !tab.url) {
return;
}
window.browser.tabs.update({
url: `responsively://${tab.url}`,
});
})();
return setTimeout(() => {
updateTabURL();
setTimeout(() => {
window.close();
}, 5000);
}, []);
}, [updateTabURL]);
return (
<div className="popup">