From eaa180cc6847541319bfe7cebaa5891db6b96216 Mon Sep 17 00:00:00 2001 From: Josh McKinney Date: Sun, 15 Sep 2024 21:24:42 -0700 Subject: [PATCH] review fixes --- BREAKING-CHANGES.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/BREAKING-CHANGES.md b/BREAKING-CHANGES.md index 12a9052d..2330fb3b 100644 --- a/BREAKING-CHANGES.md +++ b/BREAKING-CHANGES.md @@ -71,7 +71,7 @@ This is a quick summary of the sections below: [#1373]: https://github.com/ratatui/ratatui/pull/1373 -As this adds an extra conversion, ambiguous inferred values may no longer compile. +As this adds an extra conversion, ambiguous inferred expressions may no longer compile. ```rust // given: @@ -81,7 +81,7 @@ impl From for Cow { ... } let foo = Foo { ... }; let line = Line::from(foo); // now fails due to now ambiguous inferred type -// replace with +// replace with e.g. let line = Line::from(String::from(foo)); ``` @@ -154,7 +154,9 @@ are also named terminal, and confusion about module exports for newer Rust users This change simplifies the trait and makes it easier to implement. -### `Frame::size` is deprecated and renamed to `Frame::area` +### `Frame::size` is deprecated and renamed to `Frame::area` ([#1293]) + +[#1293]: https://github.com/ratatui/ratatui/pull/1293 `Frame::size` is renamed to `Frame::area` as it's the more correct name.