From 4955380932ab4d657be15dd6c65f48334795c785 Mon Sep 17 00:00:00 2001 From: Josh McKinney Date: Sat, 18 May 2024 22:09:15 -0700 Subject: [PATCH] build: remove pre-push hooks (#1115) --- .cargo-husky/hooks/pre-push | 16 ---------------- CONTRIBUTING.md | 8 +++----- Cargo.toml | 3 --- 3 files changed, 3 insertions(+), 24 deletions(-) delete mode 100755 .cargo-husky/hooks/pre-push diff --git a/.cargo-husky/hooks/pre-push b/.cargo-husky/hooks/pre-push deleted file mode 100755 index 3c6555fa..00000000 --- a/.cargo-husky/hooks/pre-push +++ /dev/null @@ -1,16 +0,0 @@ -#!/usr/bin/env bash - -if !(command cargo-make >/dev/null 2>&1); then # Check if cargo-make is installed - echo Attempting to run cargo-make as part of the pre-push hook but it\'s not installed. - echo Please install it by running the following command: - echo - echo " cargo install --force cargo-make" - echo - echo If you don\'t want to run cargo-make as part of the pre-push hook, you can run - echo the following command instead of git push: - echo - echo " git push --no-verify" - exit 1 -fi - -cargo make ci diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 715685fe..6a14b1a9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -56,11 +56,9 @@ documented. ### Run CI tests before pushing a PR -We're using [cargo-husky](https://github.com/rhysd/cargo-husky) to automatically run git hooks, -which will run `cargo make ci` before each push. To initialize the hook run `cargo test`. If -`cargo-make` is not installed, it will provide instructions to install it for you. This will ensure -that your code is formatted, compiles and passes all tests before you push. If you need to skip this -check, you can use `git push --no-verify`. +Running `cargo make ci` before pushing will perform the same checks that we do in the CI process. +It's not mandatory to do this before pushing, however it may save you time to do so instead of +waiting for GitHub to run the checks. ### Sign your commits diff --git a/Cargo.toml b/Cargo.toml index 3ede7adc..d8714938 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -47,9 +47,6 @@ unicode-width = "0.1" anyhow = "1.0.71" argh = "0.1.12" better-panic = "0.3.0" -cargo-husky = { version = "1.5.0", default-features = false, features = [ - "user-hooks", -] } color-eyre = "0.6.2" criterion = { version = "0.5.1", features = ["html_reports"] } derive_builder = "0.20.0"