Mirrors/ratatui
2
0
Fork 0
mirror of https://github.com/ratatui-org/ratatui synced 2024-11-10 07:04:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix: fix u16 overflow in Terminal::insert_before. (#1323)

Browse source 
If the amount of characters in the screen above the viewport was greater
than u16::MAX, a multiplication would overflow. The multiply was used to
compute the maximum chunk size. The fix is to just do the multiplication
as a usize and also do the subsequent division as a usize.

There is currently another outstanding issue that limits the amount of
characters that can be inserted when calling Terminal::insert_before to
u16::MAX. However, this bug can still occur even if the viewport and the
amount of characters being inserted are both less than u16::MAX, since
it's dependant on how large the screen is above the viewport.

Fixes #1322
This commit is contained in:
Neal Fachan 2024-08-13 21:06:49 -07:00 committed by GitHub
parent 0256269a7f
commit 2fb0b8a741
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/terminal/terminal.rs
View file

@ -570,9 +570,9 @@ where
draw_fn(&mut buffer);
// Split buffer into screen-sized chunks and draw
let max_chunk_size = (self.viewport_area.top() * area.width).into();
let max_chunk_size = (self.viewport_area.top() as usize) * (area.width as usize);
for buffer_content_chunk in buffer.content.chunks(max_chunk_size) {
let chunk_size = buffer_content_chunk.len() as u16 / area.width;
let chunk_size = (buffer_content_chunk.len() / (area.width as usize)) as u16;
self.backend
.append_lines(self.viewport_area.height.saturating_sub(1) + chunk_size)?;