mirror of
https://github.com/pkkid/python-plexapi
synced 2024-11-23 04:03:05 +00:00
Apply review feedback
This commit is contained in:
parent
561a664362
commit
4872138635
1 changed files with 11 additions and 11 deletions
22
.github/workflows/ci.yaml
vendored
22
.github/workflows/ci.yaml
vendored
|
@ -11,15 +11,14 @@ on:
|
||||||
|
|
||||||
env:
|
env:
|
||||||
DEFAULT_PYTHON: 3.7
|
DEFAULT_PYTHON: 3.7
|
||||||
PLEXAPI_AUTH_SERVER_BASEURL: http://127.0.0.1:32400
|
|
||||||
PLEX_CONTAINER_TAG: latest
|
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
lint-flake8:
|
lint-flake8:
|
||||||
name: Check flake8
|
name: Check flake8
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v2
|
- name: Check out code from Github
|
||||||
|
uses: actions/checkout@v2
|
||||||
|
|
||||||
- name: Set up Python ${{ env.DEFAULT_PYTHON }}
|
- name: Set up Python ${{ env.DEFAULT_PYTHON }}
|
||||||
uses: actions/setup-python@v2
|
uses: actions/setup-python@v2
|
||||||
|
@ -30,8 +29,7 @@ jobs:
|
||||||
uses: actions/cache@v2
|
uses: actions/cache@v2
|
||||||
with:
|
with:
|
||||||
path: ~/.cache/pip
|
path: ~/.cache/pip
|
||||||
key: ${{ runner.os }}-${{ env.DEFAULT_PYTHON }}-pip-${{ hashFiles('requirements_dev.txt') }}
|
key: ${{ runner.os }}-${{ env.DEFAULT_PYTHON }}-pip-flake8
|
||||||
restore-keys: ${{ runner.os }}-${{ env.DEFAULT_PYTHON }}-pip
|
|
||||||
|
|
||||||
- name: Install dependencies
|
- name: Install dependencies
|
||||||
run: |
|
run: |
|
||||||
|
@ -51,7 +49,8 @@ jobs:
|
||||||
needs: lint-flake8
|
needs: lint-flake8
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
env:
|
env:
|
||||||
TEST_ACCOUNT_ONCE: 1
|
PLEXAPI_AUTH_SERVER_BASEURL: http://127.0.0.1:32400
|
||||||
|
PLEX_CONTAINER_TAG: latest
|
||||||
strategy:
|
strategy:
|
||||||
fail-fast: false
|
fail-fast: false
|
||||||
matrix:
|
matrix:
|
||||||
|
@ -63,7 +62,8 @@ jobs:
|
||||||
- is-master: false
|
- is-master: false
|
||||||
plex: claimed
|
plex: claimed
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v2
|
- name: Check out code from Github
|
||||||
|
uses: actions/checkout@v2
|
||||||
|
|
||||||
- name: Set up Python ${{ matrix.python-version }}
|
- name: Set up Python ${{ matrix.python-version }}
|
||||||
uses: actions/setup-python@v2
|
uses: actions/setup-python@v2
|
||||||
|
@ -75,7 +75,7 @@ jobs:
|
||||||
with:
|
with:
|
||||||
path: ~/.cache/pip
|
path: ~/.cache/pip
|
||||||
key: ${{ runner.os }}-${{ matrix.python-version }}-pip-${{ hashFiles('requirements_dev.txt') }}
|
key: ${{ runner.os }}-${{ matrix.python-version }}-pip-${{ hashFiles('requirements_dev.txt') }}
|
||||||
restore-keys: ${{ runner.os }}-${{ matrix.python-version }}-pip
|
restore-keys: ${{ runner.os }}-${{ matrix.python-version }}-pip-
|
||||||
|
|
||||||
- name: Install dependencies
|
- name: Install dependencies
|
||||||
run: |
|
run: |
|
||||||
|
@ -86,7 +86,7 @@ jobs:
|
||||||
- name: Set Plex credentials
|
- name: Set Plex credentials
|
||||||
if: matrix.plex == 'claimed'
|
if: matrix.plex == 'claimed'
|
||||||
run: |
|
run: |
|
||||||
echo "PLEXAPI_AUTH_MYPLEX_USERNAME=${{ secrets.PLEXAPI_AUTH_MYPLEX_USERNAME }}" > $GITHUB_ENV
|
echo "PLEXAPI_AUTH_MYPLEX_USERNAME=${{ secrets.PLEXAPI_AUTH_MYPLEX_USERNAME }}" >> $GITHUB_ENV
|
||||||
echo "PLEXAPI_AUTH_MYPLEX_PASSWORD=${{ secrets.PLEXAPI_AUTH_MYPLEX_PASSWORD }}" >> $GITHUB_ENV
|
echo "PLEXAPI_AUTH_MYPLEX_PASSWORD=${{ secrets.PLEXAPI_AUTH_MYPLEX_PASSWORD }}" >> $GITHUB_ENV
|
||||||
|
|
||||||
- name: Bootstrap ${{ matrix.plex }} Plex server
|
- name: Bootstrap ${{ matrix.plex }} Plex server
|
||||||
|
@ -142,6 +142,7 @@ jobs:
|
||||||
name: Process test coverage
|
name: Process test coverage
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
needs: pytest
|
needs: pytest
|
||||||
|
if: always()
|
||||||
steps:
|
steps:
|
||||||
- name: Check out code from GitHub
|
- name: Check out code from GitHub
|
||||||
uses: actions/checkout@v2
|
uses: actions/checkout@v2
|
||||||
|
@ -150,8 +151,7 @@ jobs:
|
||||||
uses: actions/cache@v2
|
uses: actions/cache@v2
|
||||||
with:
|
with:
|
||||||
path: ~/.cache/pip
|
path: ~/.cache/pip
|
||||||
key: ${{ runner.os }}-${{ env.DEFAULT_PYTHON }}-pip-${{ hashFiles('requirements_dev.txt') }}
|
key: ${{ runner.os }}-${{ env.DEFAULT_PYTHON }}-pip-coverage
|
||||||
restore-keys: ${{ runner.os }}-${{ env.DEFAULT_PYTHON }}-pip
|
|
||||||
|
|
||||||
- name: Set up Python ${{ env.DEFAULT_PYTHON }}
|
- name: Set up Python ${{ env.DEFAULT_PYTHON }}
|
||||||
uses: actions/setup-python@v2
|
uses: actions/setup-python@v2
|
||||||
|
|
Loading…
Reference in a new issue