After some more investigating and talking to the bulbapedia maintainers of the Johto Safari Zone page I've been able to gain additional insight on the mechanics and the encounter slots of the safari zone, as such I applied what I learned and had to correct large chunks of data here.
+ Update encounter slots
+ Repositioned encounter slots IDs
+ Updated encounter conditions (Johto Safari Zone's encounter aren't affected by the presence of the national dex)
+ National Dex requirement for Hearthome Eeevee D/P
+ Defeat Jupiter Eterna City Togepi Egg
+ Remove Togepi Egg from D/P (was incorrect)
+ Clear Team Galactic Iron Island Riolu Egg
For some reason the conditions on this specific area where missing in crystal, despite the data being present in encounters the conditions were not attached to them
After much research I was able to find out some mechanics from the johto safari zone, it uses completely different encounter slots in walking, surfing, old rod, good rod and super rod, I was able to determine that it's 10 walk slots all have a 10% chance but wasn't so lucky in finding the chance for the surfing, old rod, good rod and super rod 12 slots, I have -some- confidence that it has 10 10% chance slots and 2 0% chance slots, if more info comes to light about these slots I'll update this info at another time.
+ Added Johto Safari Zone location
+ Added all 12 Safari Zone areas
+ Added all 2880 encounters from the safari zone (For both HG and SS)
Due to an error the headbutt importer script used the wrong tables for gold and silver, this commit re-run this tool with the correct data and solved the inconsistencies that were present in the previous commits.
- Replaced all headbutt encounters with their correct counterparts
- Relocated some encounter's IDs
- Created location area Bell Tower 1f
- Moved Pokémon Crystal's Suicune encounter from Bell Tower Roof to Bell Tower 1f (it's correct position)
- Snorlax in GSC, HGSS
- Groudon, Kyogre and Rayquaza in RSE
- Removed unused Goldenrod city area location area
- Changed location area prose to some areas to correct duplicate location name in display
- Added proper default values for story-progress condition
- Added new condition 'other' for weirder conditions
- Added missing areas for legendary encounters in Hoenn
- Added missing locations for legendary encounters in Hoenn
Added:
- Encounter conditions for beat elite four, beat elite four round 2
- Added locations and areas for roaming Pokémon (One for each region)
- Added area for Bell Tower Roof
- Added encounters for Lugia, Ho-Oh, Articuno, Zapdos, Moltres, Mewtwo, Raikou, Entei, Suicune, Latios and Latias to GSC, HGSS, FRLG and RSE where applicable.
- Bound encounter conditions where applicable.
Filling out remaining data so Models have complete associations.
Data and models added for:
Pokemon
Moves
Pal Park
Berries
Regions
Pokeathlon
Contests
SuperContests
Items
Encounters
Locations