Commit graph

132 commits

Author SHA1 Message Date
Pavle Goloskokovic
d13fae2260 Preventing negative values for source start call 2017-11-26 18:12:55 +01:00
Pavle Goloskokovic
93ac04329b Updated WebAudioSound update method docs and signature 2017-11-26 17:25:01 +01:00
Pavle Goloskokovic
66dcd9f02f Resetting hasEnded in update method 2017-11-26 17:07:56 +01:00
Pavle Goloskokovic
0a078d26f6 Setting hasEnded when sound ends 2017-11-26 17:07:05 +01:00
Pavle Goloskokovic
f0bc96e68f Checking hasEnded on update in order to call stop method 2017-11-26 17:05:24 +01:00
Pavle Goloskokovic
84e6459b59 Added hasEnded property to WebAudioSound class 2017-11-26 17:03:36 +01:00
Pavle Goloskokovic
94e834fa96 Updating all sounds on sound manager update 2017-11-26 16:59:12 +01:00
Pavle Goloskokovic
ceeef0368c Added a todo to fix race condition 2017-11-26 16:41:46 +01:00
Pavle Goloskokovic
2995b7eaf6 Added short logic explanation for onended event handler 2017-11-26 16:37:03 +01:00
Pavle Goloskokovic
e13b829ab1 Removed redundant check in onended handler and reverted setting source to null before calling stop() on it since it does not invoke onended event handler immediately 2017-11-26 16:35:13 +01:00
Pavle Goloskokovic
007a565700 Just checking for null sound reference isn't enough since because calling play() on already playing sound is not covered by that condition 2017-11-26 16:31:06 +01:00
Pavle Goloskokovic
aab5150016 Setting source to null before calling stop on it to determine if onended event was fired when sound ended or when it was stopped by user 2017-11-26 16:28:54 +01:00
Pavle Goloskokovic
04eb680d52 Checking if source is null before stopping sound on ended handler because it is called also when stop() method is called on it 2017-11-26 16:27:39 +01:00
Pavle Goloskokovic
1808fab27e Calling stop method when sound ends 2017-11-26 16:24:49 +01:00
Pavle Goloskokovic
53dbf050d4 Marked a few methods as private 2017-11-26 16:19:56 +01:00
Pavle Goloskokovic
762c6cb147 Updated a TODO 2017-11-23 13:55:27 +01:00
Pavle Goloskokovic
266ebc4925 Taking into account marker start time on resuming sound 2017-11-23 13:55:08 +01:00
Pavle Goloskokovic
d369d46e35 Taking into account marker start time if marker is currently played 2017-11-23 13:53:57 +01:00
Pavle Goloskokovic
0ded9af3a9 Resetting current marker if no marker name is provided to play method 2017-11-23 13:52:03 +01:00
Pavle Goloskokovic
5f55931d22 Completed a TODO by setting BaseSound update method to NOOP 2017-11-23 13:19:22 +01:00
Pavle Goloskokovic
a2ceff63f1 Returning marker/null instead of boolean in removeMarker 2017-11-23 13:14:41 +01:00
Pavle Goloskokovic
b3337b6c51 Added validation for non existing marker in removeMarker method 2017-11-23 13:13:25 +01:00
Pavle Goloskokovic
c48f51de35 Setting marker to null on removeMarker call 2017-11-23 13:12:21 +01:00
Pavle Goloskokovic
9d8afee78f Added validation for non existing marker to updateMarker method 2017-11-23 12:56:32 +01:00
Pavle Goloskokovic
0e97a18553 Added validation for invalid marker name to updateMarker method 2017-11-23 12:56:06 +01:00
Pavle Goloskokovic
42735ee09f Added validation for when no marker is provided to updateMarker method 2017-11-23 12:55:22 +01:00
Pavle Goloskokovic
17d39f7bab Merging provided marker with existing marker in updateMarker method 2017-11-23 12:54:47 +01:00
Pavle Goloskokovic
8a4e439b55 Updated logging for addMarker method of BaseSound class 2017-11-23 12:52:19 +01:00
Pavle Goloskokovic
6c38853a6f Added update marker method to BaseSound class 2017-11-23 12:41:41 +01:00
Pavle Goloskokovic
76a32e20c6 Fixed return values for addMarker method 2017-11-23 12:37:10 +01:00
Pavle Goloskokovic
1e213e6d86 Added validation for existing marker 2017-11-23 12:35:55 +01:00
Pavle Goloskokovic
de5689b129 Added validation for marker name 2017-11-23 12:34:43 +01:00
Pavle Goloskokovic
2bcffe6f2f Merging provided marker with object with default values 2017-11-23 12:33:56 +01:00
Pavle Goloskokovic
40b4dc2e6e Adding validation and error handling if no marker is passed 2017-11-23 12:31:34 +01:00
Pavle Goloskokovic
084d309efb Adding market to markers array in addMarker method 2017-11-23 12:30:24 +01:00
Pavle Goloskokovic
c1b0bc4ee7 Added a TODO for scheduled playback 2017-11-22 18:07:08 +01:00
Pavle Goloskokovic
068fc6d1c9 Renamed 'marker' param of play method to 'markerName' to avoid any confusion for WebAudioSound 2017-11-22 18:06:21 +01:00
Pavle Goloskokovic
d367dc1a85 Renamed 'marker' param of play method to 'markerName' to avoid any confusion for BaseSound 2017-11-22 18:05:18 +01:00
Pavle Goloskokovic
8e912ab877 Updated currentMarker property to hold reference to marker object instead it's name 2017-11-22 18:03:44 +01:00
Pavle Goloskokovic
55e5041ef8 Setting correct duration value when calling play on BaseSound class 2017-11-22 18:00:53 +01:00
Pavle Goloskokovic
de0aefba7e Added default value for config in WebAudioSound constructor 2017-11-22 17:58:05 +01:00
Pavle Goloskokovic
9a143694d1 Using duration property instead of config duration setting in WebAudioSound 2017-11-22 17:56:55 +01:00
Pavle Goloskokovic
92abe3f678 Remove completed TODO 2017-11-22 17:54:38 +01:00
Pavle Goloskokovic
ffe4e49512 Setting duration and totalDuration properties in WebAudioSound constructor 2017-11-22 17:54:00 +01:00
Pavle Goloskokovic
90d2e8cf03 Removed setting duration setting in config for WebAudioSound 2017-11-22 17:51:10 +01:00
Pavle Goloskokovic
1296dd737d Added totalDuration property to BaseSound class 2017-11-22 17:48:10 +01:00
Pavle Goloskokovic
f932e315d6 Added duration property to BaseSound class 2017-11-22 17:47:18 +01:00
Pavle Goloskokovic
7442ab5bc8 Removed duration setting from sound config 2017-11-22 17:45:57 +01:00
Pavle Goloskokovic
cd43f0095c fixed deprecation issues with AudioParam for WebAudioSoundManager 2017-11-21 19:47:43 +01:00
Pavle Goloskokovic
1f32f04036 fixed deprecation issues with AudioParam for WebAudioSound 2017-11-21 19:47:27 +01:00