Commit graph

95 commits

Author SHA1 Message Date
Pavle Goloskokovic
fe9c9c0819 Added totalRate property to BaseSound class 2017-12-01 15:32:03 +01:00
Pavle Goloskokovic
f389176362 Added setRate method to BaseSound class that contains logic for applying rate and detune settings to sound so it can be reused in both Web Audio and HTML5 Audio implementations 2017-11-27 17:30:55 +01:00
Pavle Goloskokovic
53dbf050d4 Marked a few methods as private 2017-11-26 16:19:56 +01:00
Pavle Goloskokovic
0ded9af3a9 Resetting current marker if no marker name is provided to play method 2017-11-23 13:52:03 +01:00
Pavle Goloskokovic
5f55931d22 Completed a TODO by setting BaseSound update method to NOOP 2017-11-23 13:19:22 +01:00
Pavle Goloskokovic
a2ceff63f1 Returning marker/null instead of boolean in removeMarker 2017-11-23 13:14:41 +01:00
Pavle Goloskokovic
b3337b6c51 Added validation for non existing marker in removeMarker method 2017-11-23 13:13:25 +01:00
Pavle Goloskokovic
c48f51de35 Setting marker to null on removeMarker call 2017-11-23 13:12:21 +01:00
Pavle Goloskokovic
9d8afee78f Added validation for non existing marker to updateMarker method 2017-11-23 12:56:32 +01:00
Pavle Goloskokovic
0e97a18553 Added validation for invalid marker name to updateMarker method 2017-11-23 12:56:06 +01:00
Pavle Goloskokovic
42735ee09f Added validation for when no marker is provided to updateMarker method 2017-11-23 12:55:22 +01:00
Pavle Goloskokovic
17d39f7bab Merging provided marker with existing marker in updateMarker method 2017-11-23 12:54:47 +01:00
Pavle Goloskokovic
8a4e439b55 Updated logging for addMarker method of BaseSound class 2017-11-23 12:52:19 +01:00
Pavle Goloskokovic
6c38853a6f Added update marker method to BaseSound class 2017-11-23 12:41:41 +01:00
Pavle Goloskokovic
76a32e20c6 Fixed return values for addMarker method 2017-11-23 12:37:10 +01:00
Pavle Goloskokovic
1e213e6d86 Added validation for existing marker 2017-11-23 12:35:55 +01:00
Pavle Goloskokovic
de5689b129 Added validation for marker name 2017-11-23 12:34:43 +01:00
Pavle Goloskokovic
2bcffe6f2f Merging provided marker with object with default values 2017-11-23 12:33:56 +01:00
Pavle Goloskokovic
40b4dc2e6e Adding validation and error handling if no marker is passed 2017-11-23 12:31:34 +01:00
Pavle Goloskokovic
084d309efb Adding market to markers array in addMarker method 2017-11-23 12:30:24 +01:00
Pavle Goloskokovic
d367dc1a85 Renamed 'marker' param of play method to 'markerName' to avoid any confusion for BaseSound 2017-11-22 18:05:18 +01:00
Pavle Goloskokovic
8e912ab877 Updated currentMarker property to hold reference to marker object instead it's name 2017-11-22 18:03:44 +01:00
Pavle Goloskokovic
55e5041ef8 Setting correct duration value when calling play on BaseSound class 2017-11-22 18:00:53 +01:00
Pavle Goloskokovic
1296dd737d Added totalDuration property to BaseSound class 2017-11-22 17:48:10 +01:00
Pavle Goloskokovic
f932e315d6 Added duration property to BaseSound class 2017-11-22 17:47:18 +01:00
Pavle Goloskokovic
7442ab5bc8 Removed duration setting from sound config 2017-11-22 17:45:57 +01:00
Pavle Goloskokovic
cafa91005f updated description for detune setting and added a check to see if it's available, webkit implementation does not support it 2017-11-20 14:54:33 +01:00
Pavle Goloskokovic
6897d6567b updated checks in playback control methods for BaseSound class 2017-11-17 18:37:49 +01:00
Pavle Goloskokovic
40c4b9f6e5 added checks to playback control methods for BaseSound class 2017-11-17 17:16:06 +01:00
Pavle Goloskokovic
d1fcc39fd3 setting playback flags to correct values on resume call for BaseSound 2017-11-17 15:18:51 +01:00
Pavle Goloskokovic
1d7d488e68 setting playback flags to correct values on pause call for BaseSound 2017-11-17 15:16:25 +01:00
Pavle Goloskokovic
c5436c7fcc setting playback flags to correct values on play call for BaseSound 2017-11-17 15:14:57 +01:00
Pavle Goloskokovic
38a8ce378d resetting flags on stop call for BaseSound 2017-11-17 15:03:59 +01:00
Pavle Goloskokovic
7a4939d435 added isPaused field to BaseSound class 2017-11-17 14:51:23 +01:00
Pavle Goloskokovic
8ede77ddce setting detune value when applying config 2017-11-16 17:21:00 +01:00
Pavle Goloskokovic
3a8c665fd6 added detune field for BaseSound class 2017-11-16 16:41:48 +01:00
Pavle Goloskokovic
a4b7eb0fe5 added duration description 2017-11-16 16:30:31 +01:00
Pavle Goloskokovic
e38adfed79 updated description for rate property for BaseSound class
setting rate value when applying config
2017-11-16 15:23:04 +01:00
Pavle Goloskokovic
e7177c5731 handling the case when only config object is passed to the play method 2017-11-16 14:54:08 +01:00
Pavle Goloskokovic
5796cd4bc8 moved setting current config reference before setting default values in BaseSound class 2017-11-16 14:29:28 +01:00
Pavle Goloskokovic
872d93b788 moved validation ad marker logic from WebAudioSound class play method to BaseSound class play method 2017-11-16 14:19:04 +01:00
Pavle Goloskokovic
25bd3816c7 added applyConfig method to BaseSound class and calling it inside of WebAudioSound class play method 2017-11-16 13:32:35 +01:00
Pavle Goloskokovic
0363116383 updated BaseSound fields docs
updated sound config initialization
2017-11-15 17:26:20 +01:00
Pavle Goloskokovic
ced54044e9 added return value to BaseSound addMarker method 2017-11-14 16:26:52 +01:00
Pavle Goloskokovic
b5db604ae6 added BaseSound class 2017-11-14 16:00:24 +01:00