Commit graph

65 commits

Author SHA1 Message Date
Pavle Goloskokovic
47522af035 Reordering setting loop value in applyConfig before rate and detune to enable rate and detune to update loop source as well 2017-12-12 20:02:17 +01:00
Pavle Goloskokovic
594d1512aa Implemented destroy method for BaseSound class 2017-12-10 13:17:17 +01:00
Pavle Goloskokovic
e4ca4d4b75 Updated description for mute property 2017-12-07 20:57:05 +01:00
Pavle Goloskokovic
361ff7ff94 Updated description for volume property 2017-12-07 20:56:51 +01:00
Pavle Goloskokovic
42003ca74c Updated description for seek property 2017-12-07 20:56:34 +01:00
Pavle Goloskokovic
d856a97e98 Reverting to resetting config on every play method call 2017-12-07 20:55:47 +01:00
Pavle Goloskokovic
11d9d5455d Resetting config on stop call 2017-12-07 20:17:38 +01:00
Pavle Goloskokovic
1973781052 Resetting config when calling play method only if current call plays different marker than previous (to enable setting seek before replaying same sound) 2017-12-07 20:17:00 +01:00
Pavle Goloskokovic
0a5e8de376 Using subclass values for duration properties if available 2017-12-06 18:07:43 +01:00
Pavle Goloskokovic
0338d6f7c0 Initializing duration properties before config because some config options' setters use those values (seek) 2017-12-06 18:06:05 +01:00
Pavle Goloskokovic
b01859eb06 Moved config initialization right before config options initializations 2017-12-06 18:04:18 +01:00
Pavle Goloskokovic
260d519a7e Resetting config before merging it with config provided to play method 2017-12-05 20:25:31 +01:00
Pavle Goloskokovic
344aec2b86 Added resetConfig method where seek config, and later delay config, are reset 2017-12-05 19:40:25 +01:00
Pavle Goloskokovic
dc4bb51b93 Updated few members access modifiers from private to protected 2017-12-05 19:31:58 +01:00
Pavle Goloskokovic
00c2fd3189 Moved totalRate initialisation above setting config options since it is used in some of the config options' setters (detune, rate) 2017-12-05 19:28:08 +01:00
Pavle Goloskokovic
fd96a329de Moved isPlaying and isPaused flags initialisation above setting config options since they are used in some of the config options' setters (detune, rate) 2017-12-05 19:24:17 +01:00
Pavle Goloskokovic
de1657de01 Updated comments with private and readonly descriptors 2017-12-04 22:09:41 +01:00
Pavle Goloskokovic
fe36e80f24 Removing detune range limitation 2017-12-04 22:05:29 +01:00
Pavle Goloskokovic
a3dbb51d3e Removed return value for setRate method as it is not needed because that value is now stored in totalRate property 2017-12-01 15:40:35 +01:00
Pavle Goloskokovic
411fdd48b2 Setting totalRate value in setRate method 2017-12-01 15:33:02 +01:00
Pavle Goloskokovic
fe9c9c0819 Added totalRate property to BaseSound class 2017-12-01 15:32:03 +01:00
Pavle Goloskokovic
f389176362 Added setRate method to BaseSound class that contains logic for applying rate and detune settings to sound so it can be reused in both Web Audio and HTML5 Audio implementations 2017-11-27 17:30:55 +01:00
Pavle Goloskokovic
53dbf050d4 Marked a few methods as private 2017-11-26 16:19:56 +01:00
Pavle Goloskokovic
0ded9af3a9 Resetting current marker if no marker name is provided to play method 2017-11-23 13:52:03 +01:00
Pavle Goloskokovic
5f55931d22 Completed a TODO by setting BaseSound update method to NOOP 2017-11-23 13:19:22 +01:00
Pavle Goloskokovic
a2ceff63f1 Returning marker/null instead of boolean in removeMarker 2017-11-23 13:14:41 +01:00
Pavle Goloskokovic
b3337b6c51 Added validation for non existing marker in removeMarker method 2017-11-23 13:13:25 +01:00
Pavle Goloskokovic
c48f51de35 Setting marker to null on removeMarker call 2017-11-23 13:12:21 +01:00
Pavle Goloskokovic
9d8afee78f Added validation for non existing marker to updateMarker method 2017-11-23 12:56:32 +01:00
Pavle Goloskokovic
0e97a18553 Added validation for invalid marker name to updateMarker method 2017-11-23 12:56:06 +01:00
Pavle Goloskokovic
42735ee09f Added validation for when no marker is provided to updateMarker method 2017-11-23 12:55:22 +01:00
Pavle Goloskokovic
17d39f7bab Merging provided marker with existing marker in updateMarker method 2017-11-23 12:54:47 +01:00
Pavle Goloskokovic
8a4e439b55 Updated logging for addMarker method of BaseSound class 2017-11-23 12:52:19 +01:00
Pavle Goloskokovic
6c38853a6f Added update marker method to BaseSound class 2017-11-23 12:41:41 +01:00
Pavle Goloskokovic
76a32e20c6 Fixed return values for addMarker method 2017-11-23 12:37:10 +01:00
Pavle Goloskokovic
1e213e6d86 Added validation for existing marker 2017-11-23 12:35:55 +01:00
Pavle Goloskokovic
de5689b129 Added validation for marker name 2017-11-23 12:34:43 +01:00
Pavle Goloskokovic
2bcffe6f2f Merging provided marker with object with default values 2017-11-23 12:33:56 +01:00
Pavle Goloskokovic
40b4dc2e6e Adding validation and error handling if no marker is passed 2017-11-23 12:31:34 +01:00
Pavle Goloskokovic
084d309efb Adding market to markers array in addMarker method 2017-11-23 12:30:24 +01:00
Pavle Goloskokovic
d367dc1a85 Renamed 'marker' param of play method to 'markerName' to avoid any confusion for BaseSound 2017-11-22 18:05:18 +01:00
Pavle Goloskokovic
8e912ab877 Updated currentMarker property to hold reference to marker object instead it's name 2017-11-22 18:03:44 +01:00
Pavle Goloskokovic
55e5041ef8 Setting correct duration value when calling play on BaseSound class 2017-11-22 18:00:53 +01:00
Pavle Goloskokovic
1296dd737d Added totalDuration property to BaseSound class 2017-11-22 17:48:10 +01:00
Pavle Goloskokovic
f932e315d6 Added duration property to BaseSound class 2017-11-22 17:47:18 +01:00
Pavle Goloskokovic
7442ab5bc8 Removed duration setting from sound config 2017-11-22 17:45:57 +01:00
Pavle Goloskokovic
cafa91005f updated description for detune setting and added a check to see if it's available, webkit implementation does not support it 2017-11-20 14:54:33 +01:00
Pavle Goloskokovic
6897d6567b updated checks in playback control methods for BaseSound class 2017-11-17 18:37:49 +01:00
Pavle Goloskokovic
40c4b9f6e5 added checks to playback control methods for BaseSound class 2017-11-17 17:16:06 +01:00
Pavle Goloskokovic
d1fcc39fd3 setting playback flags to correct values on resume call for BaseSound 2017-11-17 15:18:51 +01:00