From 9485eef5c739f6e78aa2e6e7336f82eeed55db34 Mon Sep 17 00:00:00 2001 From: Richard Davey Date: Thu, 26 Sep 2019 13:42:59 +0100 Subject: [PATCH] `Leaderboard.getConnectedScores` incorrectly specified two parameters, neither of which were used. Fix #4702 --- CHANGELOG.md | 3 ++- plugins/fbinstant/src/Leaderboard.js | 8 +------- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 60bdd03ee..3ad3b61d6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ * Calling `showAd` or `showVideoAd` will now check to see if the ad has already been displayed, and skip it when iterating the ads array, allowing you to display an ad with the same Placement ID without preloading it again. Fix #4728 (thanks @NokFrt) * Calling `gameStarted` in a game that doesn't load any assets would cause the error `{code: "INVALID_OPERATION", message: "Can not perform this operation before game start."}`. The plugin will now has a new internal method `gameStartedHandler` and will redirect the flow accordingly based on asset loading. Fix #4550 (thanks @bchee) * The documentation for the `chooseContext` method has been fixed. Fix #4425 (thanks @krzysztof-grzybek) +* `Leaderboard.getConnectedScores` incorrectly specified two parameters, neither of which were used. Fix #4702 (thanks @NokFrt) ### New Features @@ -38,7 +39,7 @@ My thanks to the following for helping with the Phaser 3 Examples, Docs and TypeScript definitions, either by reporting errors, fixing them or helping author the docs: -@krzysztof-grzybek +@krzysztof-grzybek @NokFrt diff --git a/plugins/fbinstant/src/Leaderboard.js b/plugins/fbinstant/src/Leaderboard.js index 3e494da19..0d5ddaade 100644 --- a/plugins/fbinstant/src/Leaderboard.js +++ b/plugins/fbinstant/src/Leaderboard.js @@ -277,16 +277,10 @@ var Leaderboard = new Class({ * @method Phaser.FacebookInstantGamesLeaderboard#getConnectedScores * @since 3.16.0 * - * @param {integer} [count=10] - The number of entries to attempt to fetch from the leaderboard. Currently, up to a maximum of 100 entries may be fetched per query. - * @param {integer} [offset=0] - The offset from the top of the leaderboard that entries will be fetched from. - * * @return {this} This Leaderboard instance. */ - getConnectedScores: function (count, offset) + getConnectedScores: function () { - if (count === undefined) { count = 10; } - if (offset === undefined) { offset = 0; } - var _this = this; this.ref.getConnectedPlayerEntriesAsync().then(function (entries)