Mirrors/phaser
2
0
Fork 0
mirror of https://github.com/photonstorm/phaser synced 2024-09-20 14:31:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

PIXI.WebGLRenderer.destroy has been fixed to decrement the glContextId and remove it from the PIXI.instances global. Game.destroy now hooks into this. This now means that you can now delete and create your Phaser game over and over without it crashing WebGL after the 4th attempt (#1260)

Browse source
This commit is contained in:
photonstorm 2015-02-11 21:02:15 +00:00
parent b68c3071a6
commit 8892f46a83
3 changed files with 8 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
README.md
View file

@ -151,6 +151,7 @@ Thanks to @pnstickne for vast majority of this update.
* Pointer.stop would call `event.preventDefault` if `Pointer._stateReset` was `true`, which is always `true` after a State has changed and before Pointer.start has been called. However this broken interacting with DOM elements in the case where the State changes and you immediately try to use the DOM element without first having clicked on the Phaser game. An additional guard was added so `preventDefault` will now only be called if both `_stateReste` and `Pointer.withinGame` are true (thanks @satan6 #1509)
* Group.forEach (and many other Group methods) now uses the `children.length` value directly instead of caching it, which both helps performance and stops the loop from breaking should you remove a Group child in the invoked callback.
* Phaser.Ellipse.contains is now working again (thanks @spayton)
* PIXI.WebGLRenderer.destroy has been fixed to decrement the `glContextId` and remove it from the PIXI.instances global. `Game.destroy` now hooks into this. This now means that you can now delete and create your Phaser game over and over without it crashing WebGL after the 4th attempt (#1260)
For changes in previous releases please see the extensive [Version History](https://github.com/photonstorm/phaser/blob/master/CHANGELOG.md).

27
src/core/Game.js
View file

@ -956,31 +956,8 @@ Phaser.Game.prototype = {
this.world = null;
this.isBooted = false;
if (this.renderType === Phaser.WEBGL)
{
PIXI.glContexts[this.renderer.glContextId] = null;
this.renderer.projection = null;
this.renderer.offset = null;
this.renderer.shaderManager.destroy();
this.renderer.spriteBatch.destroy();
this.renderer.maskManager.destroy();
this.renderer.filterManager.destroy();
this.renderer.shaderManager = null;
this.renderer.spriteBatch = null;
this.renderer.maskManager = null;
this.renderer.filterManager = null;
this.renderer.gl = null;
this.renderer.renderSession = null;
Phaser.Canvas.removeFromDOM(this.canvas);
}
else
{
this.renderer.destroy(true);
}
this.renderer.destroy(false);
Phaser.Canvas.removeFromDOM(this.canvas);
Phaser.GAMES[this.id] = null;

7
src/pixi/renderers/webgl/WebGLRenderer.js
View file

@ -248,7 +248,7 @@ PIXI.WebGLRenderer.prototype.initContext = function()
throw new Error('This browser does not support webGL. Try using the canvas renderer');
}
this.glContextId = gl.id = PIXI.WebGLRenderer.glContextId ++;
this.glContextId = gl.id = PIXI.WebGLRenderer.glContextId++;
PIXI.glContexts[this.glContextId] = gl;
@ -502,7 +502,6 @@ PIXI.WebGLRenderer.prototype.destroy = function()
this.projection = null;
this.offset = null;
// time to create the render managers! each one focuses on managine a state in webGL
this.shaderManager.destroy();
this.spriteBatch.destroy();
this.maskManager.destroy();
@ -515,6 +514,10 @@ PIXI.WebGLRenderer.prototype.destroy = function()
this.gl = null;
this.renderSession = null;
PIXI.instances[this.glContextId] = null;
PIXI.WebGLRenderer.glContextId--;
};
/**