mirror of
https://github.com/nushell/nushell
synced 2025-01-28 12:55:40 +00:00
f65bc97a54
# Description Allows `Stack` to have a modified local `Config`, which is updated immediately when `$env.config` is assigned to. This means that even within a script, commands that come after `$env.config` changes will always see those changes in `Stack::get_config()`. Also fixed a lot of cases where `engine_state.get_config()` was used even when `Stack` was available. Closes #13324. # User-Facing Changes - Config changes apply immediately after the assignment is executed, rather than whenever config is read by a command that needs it. - Potentially slower performance when executing a lot of lines that change `$env.config` one after another. Recommended to get `$env.config` into a `mut` variable first and do modifications, then assign it back. - Much faster performance when executing a script that made modifications to `$env.config`, as the changes are only parsed once. # Tests + Formatting All passing. # After Submitting - [ ] release notes
126 lines
3.6 KiB
Rust
126 lines
3.6 KiB
Rust
use nu_engine::{command_prelude::*, get_eval_expression};
|
|
use nu_plugin_protocol::{CallInfo, EvaluatedCall};
|
|
use nu_protocol::{engine::CommandType, PluginIdentity, PluginSignature};
|
|
use std::sync::Arc;
|
|
|
|
use crate::{GetPlugin, PluginExecutionCommandContext, PluginSource};
|
|
|
|
/// The command declaration proxy used within the engine for all plugin commands.
|
|
#[derive(Clone)]
|
|
pub struct PluginDeclaration {
|
|
name: String,
|
|
signature: PluginSignature,
|
|
source: PluginSource,
|
|
}
|
|
|
|
impl PluginDeclaration {
|
|
pub fn new(plugin: Arc<dyn GetPlugin>, signature: PluginSignature) -> Self {
|
|
Self {
|
|
name: signature.sig.name.clone(),
|
|
signature,
|
|
source: PluginSource::new(plugin),
|
|
}
|
|
}
|
|
}
|
|
|
|
impl Command for PluginDeclaration {
|
|
fn name(&self) -> &str {
|
|
&self.name
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
self.signature.sig.clone()
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
self.signature.sig.usage.as_str()
|
|
}
|
|
|
|
fn extra_usage(&self) -> &str {
|
|
self.signature.sig.extra_usage.as_str()
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
self.signature
|
|
.sig
|
|
.search_terms
|
|
.iter()
|
|
.map(|term| term.as_str())
|
|
.collect()
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
let mut res = vec![];
|
|
for e in self.signature.examples.iter() {
|
|
res.push(Example {
|
|
example: &e.example,
|
|
description: &e.description,
|
|
result: e.result.clone(),
|
|
})
|
|
}
|
|
res
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let eval_expression = get_eval_expression(engine_state);
|
|
|
|
// Create the EvaluatedCall to send to the plugin first - it's best for this to fail early,
|
|
// before we actually try to run the plugin command
|
|
let evaluated_call =
|
|
EvaluatedCall::try_from_call(call, engine_state, stack, eval_expression)?;
|
|
|
|
// Get the engine config
|
|
let engine_config = stack.get_config(engine_state);
|
|
|
|
// Get, or start, the plugin.
|
|
let plugin = self
|
|
.source
|
|
.persistent(None)
|
|
.and_then(|p| {
|
|
// Set the garbage collector config from the local config before running
|
|
p.set_gc_config(engine_config.plugin_gc.get(p.identity().name()));
|
|
p.get_plugin(Some((engine_state, stack)))
|
|
})
|
|
.map_err(|err| {
|
|
let decl = engine_state.get_decl(call.decl_id);
|
|
ShellError::GenericError {
|
|
error: format!("Unable to spawn plugin for `{}`", decl.name()),
|
|
msg: err.to_string(),
|
|
span: Some(call.head),
|
|
help: None,
|
|
inner: vec![],
|
|
}
|
|
})?;
|
|
|
|
// Create the context to execute in - this supports engine calls and custom values
|
|
let mut context = PluginExecutionCommandContext::new(
|
|
self.source.identity.clone(),
|
|
engine_state,
|
|
stack,
|
|
call,
|
|
);
|
|
|
|
plugin.run(
|
|
CallInfo {
|
|
name: self.name.clone(),
|
|
call: evaluated_call,
|
|
input,
|
|
},
|
|
&mut context,
|
|
)
|
|
}
|
|
|
|
fn command_type(&self) -> CommandType {
|
|
CommandType::Plugin
|
|
}
|
|
|
|
fn plugin_identity(&self) -> Option<&PluginIdentity> {
|
|
Some(&self.source.identity)
|
|
}
|
|
}
|