nushell/crates/nu-command/src/filesystem
Leon a0b3a48e8b
Fix mv error message issues (arrows, Windows paths) (#7197)
# Description

BEFORE (notice Windows paths look wrong):
```
〉mv 8 9
Error:
  × Destination file already exists
   ╭─[entry #22:1:1]
 1 │ mv 8 9
   ·      ┬
   ·      ╰── you can use -f, --force to force overwriting the destination
   ╰────

〉mv d1 tmp
Error:
  × Can't move "C:\\Users\\Leon\\TODO\\d1" to "C:\\Users\\Leon\\TODO\\tmp\\d1"
   ╭─[entry #19:1:1]
 1 │ mv d1 tmp
   ·       ─┬─
   ·        ╰── Directory not empty
   ╰────

```
AFTER (full paths are now included in the arrows' messages to make lines
like `mv $foo` entirely unambiguous):
```
〉mv 8 9
Error:
  × Destination file already exists
   ╭─[entry #4:1:1]
 1 │ mv 8 9
   ·      ┬
   ·      ╰── Destination file 'C:\Users\Leon\TODO\tmp\9' already exists
   ╰────
  help: you can use -f, --force to force overwriting the destination

〉mv d1 tmp
Error:
  × Can't move 'C:\Users\Leon\TODO\d1' to 'C:\Users\Leon\TODO\tmp\d1'
   ╭─[entry #3:1:1]
 1 │ mv d1 tmp
   ·       ─┬─
   ·        ╰── Directory 'C:\Users\Leon\TODO\tmp' is not empty
   ╰────

```
# User-Facing Changes

See above.

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace --features=extra -- -D warnings -D
clippy::unwrap_used -A clippy::needless_collect` to check that you're
using the standard code style
- `cargo test --workspace --features=extra` to check that all tests pass

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2022-11-23 16:55:13 +13:00
..
cd.rs Refactor ansi stripping into nu-utils functions (#6966) 2022-11-05 07:49:45 +13:00
cd_query.rs Add hooks to cli/repl (#5479) 2022-05-09 07:28:39 +12:00
cp.rs Refactor ansi stripping into nu-utils functions (#6966) 2022-11-05 07:49:45 +13:00
glob.rs Fix glob error arrows (#7194) 2022-11-22 14:23:01 +01:00
ls.rs fix: ls not show pattern error (#7143) 2022-11-16 09:15:19 +01:00
mkdir.rs Test command names and search terms for redundancy (#6380) 2022-08-24 11:16:47 +02:00
mod.rs enable cd to work with directory abbreviations (#5452) 2022-05-06 07:58:32 -05:00
mv.rs Fix mv error message issues (arrows, Windows paths) (#7197) 2022-11-23 16:55:13 +13:00
open.rs Make external command substitution works friendly(like fish shell, trailing ending newlines) (#7156) 2022-11-23 16:51:57 +13:00
rm.rs Edit rm help messages (#7165) 2022-11-19 10:33:30 -08:00
save.rs feat: Use Raw Text to save if pipeline data is ExternalStream (#7082) 2022-11-20 19:32:15 -06:00
touch.rs remove -d and -t from touch (#6629) 2022-09-28 13:48:34 +13:00
util.rs Remove unnecessary #[allow(...)] annotations (#6870) 2022-10-24 20:12:16 +02:00
watch.rs Split blocks and closures (#7075) 2022-11-10 21:21:49 +13:00