mirror of
https://github.com/nushell/nushell
synced 2025-01-25 03:15:25 +00:00
850ecf648a
Also enforce this by #[non_exhaustive] span such that going forward we cannot, in debug builds (1), construct invalid spans. The motivation for this stems from #6431 where I've seen crashes due to invalid slice indexing. My hope is this will mitigate such senarios 1. https://github.com/nushell/nushell/pull/6431#issuecomment-1278147241 # Description (description of your pull request here) # Tests Make sure you've done the following: - [ ] Add tests that cover your changes, either in the command examples, the crate/tests folder, or in the /tests folder. - [ ] Try to think about corner cases and various ways how your changes could break. Cover them with tests. - [ ] If adding tests is not possible, please document in the PR body a minimal example with steps on how to reproduce so one can verify your change works. Make sure you've run and fixed any issues with these commands: - [x] `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - [ ] `cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - [ ] `cargo test --workspace --features=extra` to check that all the tests pass # Documentation - [ ] If your PR touches a user-facing nushell feature then make sure that there is an entry in the documentation (https://github.com/nushell/nushell.github.io) for the feature, and update it if necessary.
82 lines
2.1 KiB
Rust
82 lines
2.1 KiB
Rust
use nu_engine::env_to_strings;
|
|
use nu_protocol::{
|
|
ast::Call,
|
|
engine::{Command, EngineState, Stack},
|
|
Category, Example, PipelineData, ShellError, Signature, Span, Spanned,
|
|
};
|
|
|
|
use crate::ExternalCommand;
|
|
|
|
use super::utils::get_editor;
|
|
|
|
#[derive(Clone)]
|
|
pub struct ConfigEnv;
|
|
|
|
impl Command for ConfigEnv {
|
|
fn name(&self) -> &str {
|
|
"config env"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build(self.name()).category(Category::Env)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Edit nu environment configurations"
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![Example {
|
|
description: "allow user to open and update nu env",
|
|
example: "config env",
|
|
result: None,
|
|
}]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<nu_protocol::PipelineData, nu_protocol::ShellError> {
|
|
let env_vars_str = env_to_strings(engine_state, stack)?;
|
|
let mut config_path = match nu_path::config_dir() {
|
|
Some(path) => path,
|
|
None => {
|
|
return Err(ShellError::GenericError(
|
|
"Could not find nu env path".to_string(),
|
|
"Could not find nu env path".to_string(),
|
|
None,
|
|
None,
|
|
Vec::new(),
|
|
));
|
|
}
|
|
};
|
|
config_path.push("nushell");
|
|
let mut nu_config = config_path.clone();
|
|
nu_config.push("env.nu");
|
|
|
|
let name = Spanned {
|
|
item: get_editor(engine_state, stack)?,
|
|
span: call.head,
|
|
};
|
|
|
|
let args = vec![Spanned {
|
|
item: nu_config.to_string_lossy().to_string(),
|
|
span: Span::unknown(),
|
|
}];
|
|
|
|
let command = ExternalCommand {
|
|
name,
|
|
args,
|
|
arg_keep_raw: vec![false],
|
|
redirect_stdout: false,
|
|
redirect_stderr: false,
|
|
env_vars: env_vars_str,
|
|
trim_end_newline: false,
|
|
};
|
|
|
|
command.run_with_input(engine_state, stack, input, true)
|
|
}
|
|
}
|