mirror of
https://github.com/nushell/nushell
synced 2024-12-29 06:23:11 +00:00
b8d37a7541
<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),
e.g.
- this PR should close #xxxx
- fixes #xxxx
you can also mention related issues, PRs or discussions!
-->
# Description
<!--
Thank you for improving Nushell. Please, check our [contributing
guide](../CONTRIBUTING.md) and talk to the core team before making major
changes.
Description of your pull request goes here. **Provide examples and/or
screenshots** if your changes affect the user experience.
-->
Fixes https://github.com/nushell/nushell/issues/11716
The problem is in our [record creation
API](0d518bf813/crates/nu-protocol/src/value/record.rs (L33))
which panics if the numbers of columns and values are different. I added
a safe variant that returns a `Result` and used it in the `rotate`
command.
## TODO in another PR:
Go through all `from_raw_cols_vals_unchecked()` (this includes the
`record!` macro which uses the unchecked version) and make sure that
either
a) it is guaranteed the number of cols and vals is the same, or
b) convert the call to `from_raw_cols_vals()`
Reason: Nushell should never panic.
# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
99 lines
2.1 KiB
Rust
99 lines
2.1 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn counter_clockwise() {
|
|
let table = pipeline(
|
|
r#"
|
|
echo [
|
|
[col1, col2, EXPECTED];
|
|
|
|
[---, "|||", XX1]
|
|
[---, "|||", XX2]
|
|
[---, "|||", XX3]
|
|
]
|
|
"#,
|
|
);
|
|
|
|
let expected = nu!(pipeline(
|
|
r#"
|
|
echo [
|
|
[ column0, column1, column2, column3];
|
|
|
|
[ EXPECTED, XX1, XX2, XX3]
|
|
[ col2, "|||", "|||", "|||"]
|
|
[ col1, ---, ---, ---]
|
|
]
|
|
| where column0 == EXPECTED
|
|
| get column1 column2 column3
|
|
| str join "-"
|
|
"#,
|
|
));
|
|
|
|
let actual = nu!(format!(
|
|
"{} | {}",
|
|
table,
|
|
pipeline(
|
|
r#"
|
|
rotate --ccw
|
|
| where column0 == EXPECTED
|
|
| get column1 column2 column3
|
|
| str join "-"
|
|
"#
|
|
)
|
|
));
|
|
|
|
assert_eq!(actual.out, expected.out);
|
|
}
|
|
|
|
#[test]
|
|
fn clockwise() {
|
|
let table = pipeline(
|
|
r#"
|
|
echo [
|
|
[col1, col2, EXPECTED];
|
|
|
|
[ ---, "|||", XX1]
|
|
[ ---, "|||", XX2]
|
|
[ ---, "|||", XX3]
|
|
]
|
|
"#,
|
|
);
|
|
|
|
let expected = nu!(pipeline(
|
|
r#"
|
|
echo [
|
|
[ column0, column1, column2, column3];
|
|
|
|
[ ---, ---, ---, col1]
|
|
[ "|||", "|||", "|||", col2]
|
|
[ XX3, XX2, XX1, EXPECTED]
|
|
]
|
|
| where column3 == EXPECTED
|
|
| get column0 column1 column2
|
|
| str join "-"
|
|
"#,
|
|
));
|
|
|
|
let actual = nu!(format!(
|
|
"{} | {}",
|
|
table,
|
|
pipeline(
|
|
r#"
|
|
rotate
|
|
| where column3 == EXPECTED
|
|
| get column0 column1 column2
|
|
| str join "-"
|
|
"#
|
|
)
|
|
));
|
|
|
|
assert_eq!(actual.out, expected.out);
|
|
}
|
|
|
|
#[test]
|
|
fn different_cols_vals_err() {
|
|
let actual = nu!("[[[one], [two, three]]] | first | rotate");
|
|
assert!(actual
|
|
.err
|
|
.contains("Attempted to create a record from different number of columns and values"))
|
|
}
|