nushell/crates/nu-command/tests/commands/open.rs
Darren Schroeder af9c31152a
Add metadata on open --raw with bytestreams (#14141)
# Description

This PR closes #14137 and allows the display hook to be set on byte
streams. So, with a hook like this below.
```nushell
display_output: {
    metadata access {|meta| match $meta.content_type? {
        "application/x-nuscript" | "application/x-nuon" | "text/x-nushell" => { nu-highlight },
        "application/json" => { ^bat --language=json --color=always --style=plain --paging=never },
        _ => {},
        }
    } | table
}
```
You could type `open toolkit.nu` and the text of toolkit.nu would be
highlighted by nu-highlight. This PR also changes the way content-type
is assigned with `open`. Previously it would only assign it if `--raw`
was specified.

Lastly, it changes the `is_external()` function to only say
`ByteStreamSource::Child`'s are external instead of both Child and
`ByteStreamSource::File`. Again, this was to allow the hook to function
properly. I'm not sure what negative ramifications changing
`is_external()` could have, but there may be some?

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the
tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
2024-10-23 16:50:15 -05:00

405 lines
11 KiB
Rust

use nu_test_support::fs::Stub::EmptyFile;
use nu_test_support::fs::Stub::FileWithContent;
use nu_test_support::fs::Stub::FileWithContentToBeTrimmed;
use nu_test_support::playground::Playground;
use nu_test_support::{nu, pipeline};
use rstest::rstest;
#[test]
fn parses_file_with_uppercase_extension() {
Playground::setup("open_test_uppercase_extension", |dirs, sandbox| {
sandbox.with_files(&[FileWithContent(
"nu.zion.JSON",
r#"{
"glossary": {
"GlossDiv": {
"GlossList": {
"GlossEntry": {
"ID": "SGML"
}
}
}
}
}"#,
)]);
let actual = nu!(
cwd: dirs.test(), pipeline(
r#"
open nu.zion.JSON
| get glossary.GlossDiv.GlossList.GlossEntry.ID
"#
));
assert_eq!(actual.out, "SGML");
})
}
#[test]
fn parses_file_with_multiple_extensions() {
Playground::setup("open_test_multiple_extensions", |dirs, sandbox| {
sandbox.with_files(&[
FileWithContent("file.tar.gz", "this is a tar.gz file"),
FileWithContent("file.tar.xz", "this is a tar.xz file"),
]);
let actual = nu!(
cwd: dirs.test(), pipeline(
r#"
hide "from tar.gz" ;
hide "from gz" ;
def "from tar.gz" [] { 'opened tar.gz' } ;
def "from gz" [] { 'opened gz' } ;
open file.tar.gz
"#
));
assert_eq!(actual.out, "opened tar.gz");
let actual2 = nu!(
cwd: dirs.test(), pipeline(
r#"
hide "from tar.xz" ;
hide "from xz" ;
hide "from tar" ;
def "from tar" [] { 'opened tar' } ;
def "from xz" [] { 'opened xz' } ;
open file.tar.xz
"#
));
assert_eq!(actual2.out, "opened xz");
})
}
#[test]
fn parses_dotfile() {
Playground::setup("open_test_dotfile", |dirs, sandbox| {
sandbox.with_files(&[FileWithContent(
".gitignore",
r#"
/target/
"#,
)]);
let actual = nu!(
cwd: dirs.test(), pipeline(
r#"
hide "from gitignore" ;
def "from gitignore" [] { 'opened gitignore' } ;
open .gitignore
"#
));
assert_eq!(actual.out, "opened gitignore");
})
}
#[test]
fn parses_csv() {
Playground::setup("open_test_1", |dirs, sandbox| {
sandbox.with_files(&[FileWithContentToBeTrimmed(
"nu.zion.csv",
r#"
author,lang,source
JT Turner,Rust,New Zealand
Andres N. Robalino,Rust,Ecuador
Yehuda Katz,Rust,Estados Unidos
"#,
)]);
let actual = nu!(
cwd: dirs.test(), pipeline(
r#"
open nu.zion.csv
| where author == "Andres N. Robalino"
| get source.0
"#
));
assert_eq!(actual.out, "Ecuador");
})
}
// sample.db has the following format:
//
// ╭─────────┬────────────────╮
// │ strings │ [table 6 rows] │
// │ ints │ [table 5 rows] │
// │ floats │ [table 4 rows] │
// ╰─────────┴────────────────╯
//
// In this case, this represents a sqlite database
// with three tables named `strings`, `ints`, and `floats`.
//
// Each table has different columns. `strings` has `x` and `y`, while
// `ints` has just `z`, and `floats` has only the column `f`. In general, when working
// with sqlite, one will want to select a single table, e.g.:
//
// open sample.db | get ints
// ╭───┬──────╮
// │ # │ z │
// ├───┼──────┤
// │ 0 │ 1 │
// │ 1 │ 42 │
// │ 2 │ 425 │
// │ 3 │ 4253 │
// │ 4 │ │
// ╰───┴──────╯
#[cfg(feature = "sqlite")]
#[test]
fn parses_sqlite() {
let actual = nu!(
cwd: "tests/fixtures/formats", pipeline(
"
open sample.db
| columns
| length
"
));
assert_eq!(actual.out, "3");
}
#[cfg(feature = "sqlite")]
#[test]
fn parses_sqlite_get_column_name() {
let actual = nu!(
cwd: "tests/fixtures/formats", pipeline(
"
open sample.db
| get strings
| get x.0
"
));
assert_eq!(actual.out, "hello");
}
#[test]
fn parses_toml() {
let actual = nu!(
cwd: "tests/fixtures/formats",
"open cargo_sample.toml | get package.edition"
);
assert_eq!(actual.out, "2018");
}
#[test]
fn parses_tsv() {
let actual = nu!(
cwd: "tests/fixtures/formats", pipeline(
"
open caco3_plastics.tsv
| first
| get origin
"
));
assert_eq!(actual.out, "SPAIN")
}
#[test]
fn parses_json() {
let actual = nu!(
cwd: "tests/fixtures/formats", pipeline(
"
open sgml_description.json
| get glossary.GlossDiv.GlossList.GlossEntry.GlossSee
"
));
assert_eq!(actual.out, "markup")
}
#[test]
fn parses_xml() {
let actual = nu!(
cwd: "tests/fixtures/formats",
pipeline("
open jt.xml
| get content
| where tag == channel
| get content
| flatten
| where tag == item
| get content
| flatten
| where tag == guid
| get content.0.content.0
")
);
assert_eq!(actual.out, "https://www.jntrnr.com/off-to-new-adventures/")
}
#[test]
fn errors_if_file_not_found() {
let actual = nu!(
cwd: "tests/fixtures/formats",
"open i_dont_exist.txt"
);
// Common error code between unixes and Windows for "No such file or directory"
//
// This seems to be not directly affected by localization compared to the OS
// provided error message
let expected = "File not found";
assert!(
actual.err.contains(expected),
"Error:\n{}\ndoes not contain{}",
actual.err,
expected
);
}
#[test]
fn open_wildcard() {
let actual = nu!(
cwd: "tests/fixtures/formats", pipeline(
"
open *.nu | where $it =~ echo | length
"
));
assert_eq!(actual.out, "3")
}
#[test]
fn open_multiple_files() {
let actual = nu!(
cwd: "tests/fixtures/formats", pipeline(
"
open caco3_plastics.csv caco3_plastics.tsv | get tariff_item | math sum
"
));
assert_eq!(actual.out, "58309279992")
}
#[test]
fn test_open_block_command() {
let actual = nu!(
cwd: "tests/fixtures/formats",
r#"
def "from blockcommandparser" [] { lines | split column ",|," }
let values = (open sample.blockcommandparser)
print ($values | get column1 | get 0)
print ($values | get column2 | get 0)
print ($values | get column1 | get 1)
print ($values | get column2 | get 1)
"#
);
assert_eq!(actual.out, "abcd")
}
#[test]
fn open_ignore_ansi() {
Playground::setup("open_test_ansi", |dirs, sandbox| {
sandbox.with_files(&[EmptyFile("nu.zion.txt")]);
let actual = nu!(
cwd: dirs.test(), pipeline(
"
ls | find nu.zion | get 0 | get name | open $in
"
));
assert!(actual.err.is_empty());
})
}
#[test]
fn open_no_parameter() {
let actual = nu!("open");
assert!(actual.err.contains("needs filename"));
}
#[rstest]
#[case("a]c")]
#[case("a[c")]
#[case("a[bc]d")]
#[case("a][c")]
fn open_files_with_glob_metachars(#[case] src_name: &str) {
Playground::setup("open_test_with_glob_metachars", |dirs, sandbox| {
sandbox.with_files(&[FileWithContent(src_name, "hello")]);
let src = dirs.test().join(src_name);
let actual = nu!(
cwd: dirs.test(),
"open '{}'",
src.display(),
);
assert!(actual.err.is_empty());
assert!(actual.out.contains("hello"));
// also test for variables.
let actual = nu!(
cwd: dirs.test(),
"let f = '{}'; open $f",
src.display(),
);
assert!(actual.err.is_empty());
assert!(actual.out.contains("hello"));
});
}
#[cfg(not(windows))]
#[rstest]
#[case("a]?c")]
#[case("a*.?c")]
// windows doesn't allow filename with `*`.
fn open_files_with_glob_metachars_nw(#[case] src_name: &str) {
open_files_with_glob_metachars(src_name);
}
#[test]
fn open_files_inside_glob_metachars_dir() {
Playground::setup("open_files_inside_glob_metachars_dir", |dirs, sandbox| {
let sub_dir = "test[]";
sandbox
.within(sub_dir)
.with_files(&[FileWithContent("test_file.txt", "hello")]);
let actual = nu!(
cwd: dirs.test().join(sub_dir),
"open test_file.txt",
);
assert!(actual.err.is_empty());
assert!(actual.out.contains("hello"));
});
}
#[test]
fn test_content_types_with_open_raw() {
Playground::setup("open_files_content_type_test", |dirs, _| {
let result = nu!(cwd: dirs.formats(), "open --raw random_numbers.csv | metadata");
assert!(result.out.contains("text/csv"));
let result = nu!(cwd: dirs.formats(), "open --raw caco3_plastics.tsv | metadata");
assert!(result.out.contains("text/tab-separated-values"));
let result = nu!(cwd: dirs.formats(), "open --raw sample-simple.json | metadata");
assert!(result.out.contains("application/json"));
let result = nu!(cwd: dirs.formats(), "open --raw sample.ini | metadata");
assert!(result.out.contains("text/plain"));
let result = nu!(cwd: dirs.formats(), "open --raw sample_data.xlsx | metadata");
assert!(result.out.contains("vnd.openxmlformats-officedocument"));
let result = nu!(cwd: dirs.formats(), "open --raw sample_def.nu | metadata");
assert!(result.out.contains("application/x-nuscript"));
let result = nu!(cwd: dirs.formats(), "open --raw sample.eml | metadata");
assert!(result.out.contains("message/rfc822"));
let result = nu!(cwd: dirs.formats(), "open --raw cargo_sample.toml | metadata");
assert!(result.out.contains("text/x-toml"));
let result = nu!(cwd: dirs.formats(), "open --raw appveyor.yml | metadata");
assert!(result.out.contains("application/yaml"));
})
}