mirror of
https://github.com/nushell/nushell
synced 2024-11-16 01:37:57 +00:00
208ffdc1da
# Description From nushell 0.8 philosophy: https://github.com/nushell/nushell.github.io/blob/main/contributor-book/philosophy_0_80.md#core-categories > The following categories should be moved to plugins: Uncommon format support So this pr is trying to move following commands to plugin: - [X] from eml - [x] from ics - [x] from ini - [x] from vcf And we can have a new plugin handles for these formatting, currently it's implemented here: https://github.com/WindSoilder/nu_plugin_format The command usage should be the same to original command. If it's ok, the plugin can support more formats like [parquet](https://github.com/fdncred/nu_plugin_from_parquet), or [EDN format](https://github.com/nushell/nushell/issues/6415), or something else. Just create a draft pr to show what's the blueprint looks like, and is it a good direction to move forward? # User-Facing Changes _(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)_ # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
65 lines
1.7 KiB
Rust
65 lines
1.7 KiB
Rust
use nu_test_support::nu_with_plugins;
|
|
|
|
const TEST_CWD: &str = "tests/fixtures/formats";
|
|
|
|
// Note: the tests can only run successfully if nushell binary is in `target/debug/`
|
|
// The To field in this email is just "to@example.com", which gets parsed out as the Address. The Name is empty.
|
|
#[test]
|
|
fn from_eml_get_to_field() {
|
|
let actual = nu_with_plugins!(
|
|
cwd: TEST_CWD,
|
|
plugin: ("nu_plugin_formats"),
|
|
"open sample.eml | get To.Address"
|
|
);
|
|
|
|
assert_eq!(actual.out, "to@example.com");
|
|
let actual = nu_with_plugins!(
|
|
cwd: TEST_CWD,
|
|
plugin: ("nu_plugin_formats"),
|
|
"open sample.eml | get To | get Name"
|
|
);
|
|
|
|
assert_eq!(actual.out, "");
|
|
}
|
|
|
|
// The Reply-To field in this email is "replyto@example.com" <replyto@example.com>, meaning both the Name and Address values are identical.
|
|
#[test]
|
|
fn from_eml_get_replyto_field() {
|
|
let actual = nu_with_plugins!(
|
|
cwd: TEST_CWD,
|
|
plugin: ("nu_plugin_formats"),
|
|
"open sample.eml | get Reply-To | get Address"
|
|
);
|
|
|
|
assert_eq!(actual.out, "replyto@example.com");
|
|
|
|
let actual = nu_with_plugins!(
|
|
cwd: TEST_CWD,
|
|
plugin: ("nu_plugin_formats"),
|
|
"open sample.eml | get Reply-To | get Name"
|
|
);
|
|
|
|
assert_eq!(actual.out, "replyto@example.com");
|
|
}
|
|
|
|
#[test]
|
|
fn from_eml_get_subject_field() {
|
|
let actual = nu_with_plugins!(
|
|
cwd: TEST_CWD,
|
|
plugin: ("nu_plugin_formats"),
|
|
"open sample.eml | get Subject"
|
|
);
|
|
|
|
assert_eq!(actual.out, "Test Message");
|
|
}
|
|
|
|
#[test]
|
|
fn from_eml_get_another_header_field() {
|
|
let actual = nu_with_plugins!(
|
|
cwd: TEST_CWD,
|
|
plugin: ("nu_plugin_formats"),
|
|
"open sample.eml | get MIME-Version"
|
|
);
|
|
|
|
assert_eq!(actual.out, "1.0");
|
|
}
|