mirror of
https://github.com/nushell/nushell
synced 2025-01-15 14:44:14 +00:00
d00a040da9
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> Added comments to support API docs for the `nu-plugin` crate. Removed a few items that I'd expect should only be used internally to Nushell from the documentation and reduced the visibility of some items that did not need to be public. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> There should be no user facing impact. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> Standard tests run. Additionally numerous doctests were added to the `nu-plugin` crate. # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. --> No changes to the website necessary.
180 lines
6.1 KiB
Rust
180 lines
6.1 KiB
Rust
use crate::EvaluatedCall;
|
|
|
|
use super::{call_plugin, create_command, get_plugin_encoding};
|
|
use crate::protocol::{
|
|
CallInfo, CallInput, PluginCall, PluginCustomValue, PluginData, PluginResponse,
|
|
};
|
|
use std::path::{Path, PathBuf};
|
|
|
|
use nu_protocol::engine::{Command, EngineState, Stack};
|
|
use nu_protocol::{ast::Call, PluginSignature, Signature};
|
|
use nu_protocol::{Example, PipelineData, ShellError, Value};
|
|
|
|
#[doc(hidden)] // Note: not for plugin authors / only used in nu-parser
|
|
#[derive(Clone)]
|
|
pub struct PluginDeclaration {
|
|
name: String,
|
|
signature: PluginSignature,
|
|
filename: PathBuf,
|
|
shell: Option<PathBuf>,
|
|
}
|
|
|
|
impl PluginDeclaration {
|
|
pub fn new(filename: PathBuf, signature: PluginSignature, shell: Option<PathBuf>) -> Self {
|
|
Self {
|
|
name: signature.sig.name.clone(),
|
|
signature,
|
|
filename,
|
|
shell,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl Command for PluginDeclaration {
|
|
fn name(&self) -> &str {
|
|
&self.name
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
self.signature.sig.clone()
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
self.signature.sig.usage.as_str()
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
let mut res = vec![];
|
|
for e in self.signature.examples.iter() {
|
|
res.push(Example {
|
|
example: &e.example,
|
|
description: &e.description,
|
|
result: e.result.clone(),
|
|
})
|
|
}
|
|
res
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
// Call the command with self path
|
|
// Decode information from plugin
|
|
// Create PipelineData
|
|
let source_file = Path::new(&self.filename);
|
|
let mut plugin_cmd = create_command(source_file, &self.shell);
|
|
// We need the current environment variables for `python` based plugins
|
|
// Or we'll likely have a problem when a plugin is implemented in a virtual Python environment.
|
|
let current_envs = nu_engine::env::env_to_strings(engine_state, stack).unwrap_or_default();
|
|
plugin_cmd.envs(current_envs);
|
|
|
|
let mut child = plugin_cmd.spawn().map_err(|err| {
|
|
let decl = engine_state.get_decl(call.decl_id);
|
|
ShellError::GenericError(
|
|
format!("Unable to spawn plugin for {}", decl.name()),
|
|
format!("{err}"),
|
|
Some(call.head),
|
|
None,
|
|
Vec::new(),
|
|
)
|
|
})?;
|
|
|
|
let input = input.into_value(call.head);
|
|
let input = match input {
|
|
Value::CustomValue { val, span } => {
|
|
match val.as_any().downcast_ref::<PluginCustomValue>() {
|
|
Some(plugin_data) if plugin_data.filename == self.filename => {
|
|
CallInput::Data(PluginData {
|
|
data: plugin_data.data.clone(),
|
|
span,
|
|
})
|
|
}
|
|
_ => {
|
|
let custom_value_name = val.value_string();
|
|
return Err(ShellError::GenericError(
|
|
format!(
|
|
"Plugin {} can not handle the custom value {}",
|
|
self.name, custom_value_name
|
|
),
|
|
format!("custom value {custom_value_name}"),
|
|
Some(span),
|
|
None,
|
|
Vec::new(),
|
|
));
|
|
}
|
|
}
|
|
}
|
|
Value::LazyRecord { val, .. } => CallInput::Value(val.collect()?),
|
|
value => CallInput::Value(value),
|
|
};
|
|
|
|
let plugin_call = PluginCall::CallInfo(CallInfo {
|
|
name: self.name.clone(),
|
|
call: EvaluatedCall::try_from_call(call, engine_state, stack)?,
|
|
input,
|
|
});
|
|
|
|
let encoding = {
|
|
let stdout_reader = match &mut child.stdout {
|
|
Some(out) => out,
|
|
None => {
|
|
return Err(ShellError::PluginFailedToLoad(
|
|
"Plugin missing stdout reader".into(),
|
|
))
|
|
}
|
|
};
|
|
get_plugin_encoding(stdout_reader)?
|
|
};
|
|
let response = call_plugin(&mut child, plugin_call, &encoding, call.head).map_err(|err| {
|
|
let decl = engine_state.get_decl(call.decl_id);
|
|
ShellError::GenericError(
|
|
format!("Unable to decode call for {}", decl.name()),
|
|
err.to_string(),
|
|
Some(call.head),
|
|
None,
|
|
Vec::new(),
|
|
)
|
|
});
|
|
|
|
let pipeline_data = match response {
|
|
Ok(PluginResponse::Value(value)) => {
|
|
Ok(PipelineData::Value(value.as_ref().clone(), None))
|
|
}
|
|
Ok(PluginResponse::PluginData(name, plugin_data)) => Ok(PipelineData::Value(
|
|
Value::CustomValue {
|
|
val: Box::new(PluginCustomValue {
|
|
name,
|
|
data: plugin_data.data,
|
|
filename: self.filename.clone(),
|
|
shell: self.shell.clone(),
|
|
source: engine_state.get_decl(call.decl_id).name().to_owned(),
|
|
}),
|
|
span: plugin_data.span,
|
|
},
|
|
None,
|
|
)),
|
|
Ok(PluginResponse::Error(err)) => Err(err.into()),
|
|
Ok(PluginResponse::Signature(..)) => Err(ShellError::GenericError(
|
|
"Plugin missing value".into(),
|
|
"Received a signature from plugin instead of value".into(),
|
|
Some(call.head),
|
|
None,
|
|
Vec::new(),
|
|
)),
|
|
Err(err) => Err(err),
|
|
};
|
|
|
|
// We need to call .wait() on the child, or we'll risk summoning the zombie horde
|
|
let _ = child.wait();
|
|
|
|
pipeline_data
|
|
}
|
|
|
|
fn is_plugin(&self) -> Option<(&PathBuf, &Option<PathBuf>)> {
|
|
Some((&self.filename, &self.shell))
|
|
}
|
|
}
|