nushell/crates/nu-explore/src/views
paulie4 88d27fd607
explore: add more less key bindings and add Transition::None (#14468)
# Description
The `explore` command is `less`-like, but it's missing the `Emacs`
keybindings for up/down and PageUp/PageDown as well as the "q" to quit
out. When I looked into adding those additional keybindings, I noticed
there was a lot of duplicated code in the various views, so I refactored
the code into a new `trait CursorMoveHandler`. I also noticed that there
was an existing `TODO: should we add a noop transition instead of doing
Option<Transition> everywhere?` comment in the code. I went ahead and
implemented a new `Transition::None`, and that made the new `trait
CursorMoveHandler` code MUCH cleaner, in addition to making some of the
old code a little cleaner as well.

# User-Facing Changes
Users that are used to the keybindings for `less` should feel much more
comfortable using `explore`.

# Tests + Formatting
Unfortunately, there aren't any existing tests for the `explore`
command, so I didn't know where I should add new tests to cover my code
changes.

---------

Co-authored-by: paulie4 <203125+paulie4@users.noreply.github.com>
Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
2024-11-30 08:22:52 -06:00
..
binary explore: add more less key bindings and add Transition::None (#14468) 2024-11-30 08:22:52 -06:00
cursor explore: add more less key bindings and add Transition::None (#14468) 2024-11-30 08:22:52 -06:00
record explore: add more less key bindings and add Transition::None (#14468) 2024-11-30 08:22:52 -06:00
colored_text_widget.rs explore refactoring+clarification (#12940) 2024-05-23 08:51:39 -05:00
mod.rs explore: add more less key bindings and add Transition::None (#14468) 2024-11-30 08:22:52 -06:00
preview.rs explore: add more less key bindings and add Transition::None (#14468) 2024-11-30 08:22:52 -06:00
try.rs explore: add more less key bindings and add Transition::None (#14468) 2024-11-30 08:22:52 -06:00
util.rs Overhaul explore config (#13075) 2024-06-06 08:46:43 -05:00