mirror of
https://github.com/nushell/nushell
synced 2024-12-30 15:03:25 +00:00
0e2167884d
This PR adds tests to confirm that: 1. `http get` does the right thing (bail) when it encounters common SSL errors 2. the `--insecure` flag works to ignore SSL errors It's prompted by #8098, where `--insecure` stopped working and we didn't notice until it was reported by a user. ## Deets + considerations This PR uses [badssl.com](https://badssl.com/), a very handy website affiliated with the Google Chrome team. The badssl authors mention that stability is not guaranteed: > Most subdomains are likely to have stable functionality, but anything could change without notice. I suspect that the badssl.com subdomains I've chosen will be stable enough in practice. Can revisit this if the tests end up being flaky. This PR does mean our tests are now making an external network call... which I _think_ is OK. Our CI isn't exactly designed for offline machines; test runners already have to download a bunch of crates etc. I think the new tests are quick enough:  |
||
|---|---|---|
| .. | ||
| http | ||
| mod.rs | ||
| port.rs | ||
