mirror of
https://github.com/nushell/nushell
synced 2024-12-30 15:03:25 +00:00
9945241b77
# Description Remove `--numbered` from ~~`for`~~, `each`, `par-each`, `reduce` and `each while`. These all provide indexes (numbering) via the optional second param to their closures. EDIT: Closes #6986. # User-Facing Changes Every command that had `--numbered` listed as "deprecated" in their help docs is affected. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. --------- Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
93 lines
2 KiB
Rust
93 lines
2 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn each_works_separately() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
echo [1 2 3] | each { |it| echo $it 10 | math sum } | to json -r
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[11,12,13]");
|
|
}
|
|
|
|
#[test]
|
|
fn each_group_works() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
echo [1 2 3 4 5 6] | group 3 | to json --raw
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[[1,2,3],[4,5,6]]");
|
|
}
|
|
|
|
#[test]
|
|
fn each_window() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
echo [1 2 3 4] | window 3 | to json --raw
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[[1,2,3],[2,3,4]]");
|
|
}
|
|
|
|
#[test]
|
|
fn each_window_stride() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
echo [1 2 3 4 5 6] | window 3 -s 2 | to json --raw
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[[1,2,3],[3,4,5]]");
|
|
}
|
|
|
|
#[test]
|
|
fn each_no_args_in_block() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
echo [[foo bar]; [a b] [c d] [e f]] | each {|i| $i | to json -r } | get 1
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, r#"{"foo": "c","bar": "d"}"#);
|
|
}
|
|
|
|
#[test]
|
|
fn each_implicit_it_in_block() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
echo [[foo bar]; [a b] [c d] [e f]] | each { |it| nu --testbin cococo $it.foo } | str join
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "ace");
|
|
}
|
|
|
|
#[test]
|
|
fn each_uses_enumerate_index() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[7 8 9 10] | enumerate | each {|el| $el.index } | to nuon"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[0, 1, 2, 3]");
|
|
}
|
|
|
|
#[test]
|
|
fn each_while_uses_enumerate_index() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[7 8 9 10] | enumerate | each while {|el| $el.index } | to nuon"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[0, 1, 2, 3]");
|
|
}
|