mirror of
https://github.com/nushell/nushell
synced 2024-12-28 14:03:09 +00:00
451a9c64d3
# Description This changes `echo` to work more closely to what users of other shells would expect: * when redirected, `echo` works as before and sends values through the pipeline * when not redirected, `echo` will print values to the screen/terminal # User-Facing Changes A standalone `echo` now will print to the terminal, if not redirected. The `echo` command is no longer const eval-able, as it will now print to the terminal in some cases. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
42 lines
954 B
Rust
42 lines
954 B
Rust
use nu_test_support::nu;
|
|
|
|
#[test]
|
|
fn for_doesnt_auto_print_in_each_iteration() {
|
|
let actual = nu!("
|
|
for i in 1..2 {
|
|
$i
|
|
}");
|
|
// Make sure we don't see any of these values in the output
|
|
// As we do not auto-print loops anymore
|
|
assert!(!actual.out.contains('1'));
|
|
}
|
|
|
|
#[test]
|
|
fn for_break_on_external_failed() {
|
|
let actual = nu!("
|
|
for i in 1..2 {
|
|
print 1;
|
|
nu --testbin fail
|
|
}");
|
|
// Note: nu! macro auto replace "\n" and "\r\n" with ""
|
|
// so our output will be `1`
|
|
assert_eq!(actual.out, "1");
|
|
}
|
|
|
|
#[test]
|
|
fn failed_for_should_break_running() {
|
|
let actual = nu!("
|
|
for i in 1..2 {
|
|
nu --testbin fail
|
|
}
|
|
print 3");
|
|
assert!(!actual.out.contains('3'));
|
|
|
|
let actual = nu!("
|
|
let x = [1 2]
|
|
for i in $x {
|
|
nu --testbin fail
|
|
}
|
|
print 3");
|
|
assert!(!actual.out.contains('3'));
|
|
}
|