mirror of
https://github.com/nushell/nushell
synced 2025-01-01 15:58:55 +00:00
90b65018b6
# Description Require that any value that looks like it might be a number (starts with a digit, or a '-' + digit, or a '+' + digits, or a special form float like `-inf`, `inf`, or `NaN`) must now be treated as a number-like value. Number-like syntax can only parse into number-like values. Number-like values include: durations, ints, floats, ranges, filesizes, binary data, etc. # User-Facing Changes BREAKING CHANGE BREAKING CHANGE BREAKING CHANGE BREAKING CHANGE BREAKING CHANGE BREAKING CHANGE BREAKING CHANGE BREAKING CHANGE Just making sure we see this for release notes 😅 This breaks any and all numberlike values that were treated as strings before. Example, we used to allow `3,` as a bare word. Anything like this would now require quotes or backticks to be treated as a string or bare word, respectively. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
149 lines
3.5 KiB
Rust
149 lines
3.5 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn regular_columns() {
|
|
let actual = nu!(cwd: ".", pipeline(
|
|
r#"
|
|
echo [
|
|
[first_name, last_name, rusty_at, type];
|
|
|
|
[Andrés Robalino '10/11/2013' A]
|
|
[JT Turner '10/12/2013' B]
|
|
[Yehuda Katz '10/11/2013' A]
|
|
]
|
|
| reject type first_name
|
|
| columns
|
|
| str join ", "
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "last_name, rusty_at");
|
|
}
|
|
|
|
#[test]
|
|
fn skip_cell_rejection() {
|
|
let actual = nu!(cwd: ".", pipeline(
|
|
r#"[ {a: 1, b: 2,c:txt}, { a:val } ] | reject a | get c?.0"#));
|
|
|
|
assert_eq!(actual.out, "txt");
|
|
}
|
|
|
|
#[test]
|
|
fn complex_nested_columns() {
|
|
let actual = nu!(cwd: ".", pipeline(
|
|
r#"
|
|
{
|
|
"nu": {
|
|
"committers": [
|
|
{"name": "Andrés N. Robalino"},
|
|
{"name": "JT Turner"},
|
|
{"name": "Yehuda Katz"}
|
|
],
|
|
"releases": [
|
|
{"version": "0.2"}
|
|
{"version": "0.8"},
|
|
{"version": "0.9999999"}
|
|
],
|
|
"0xATYKARNU": [
|
|
["Th", "e", " "],
|
|
["BIG", " ", "UnO"],
|
|
["punto", "cero"]
|
|
]
|
|
}
|
|
}
|
|
| reject nu."0xATYKARNU" nu.committers
|
|
| get nu
|
|
| columns
|
|
| str join ", "
|
|
"#,
|
|
));
|
|
|
|
assert_eq!(actual.out, "releases");
|
|
}
|
|
|
|
#[test]
|
|
fn ignores_duplicate_columns_rejected() {
|
|
let actual = nu!(cwd: ".", pipeline(
|
|
r#"
|
|
echo [
|
|
["first name", "last name"];
|
|
|
|
[Andrés Robalino]
|
|
[Andrés Jnth]
|
|
]
|
|
| reject "first name" "first name"
|
|
| columns
|
|
| str join ", "
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "last name");
|
|
}
|
|
|
|
#[test]
|
|
fn reject_record_from_raw_eval() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
{"a": 3, "a": 4} | reject a | describe
|
|
"#
|
|
)
|
|
);
|
|
|
|
assert!(actual.out.contains("record"));
|
|
}
|
|
|
|
#[test]
|
|
fn reject_table_from_raw_eval() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[{"a": 3, "a": 4}] | reject a
|
|
"#
|
|
)
|
|
);
|
|
|
|
assert!(actual.out.contains("record 0 fields"));
|
|
}
|
|
|
|
#[test]
|
|
fn reject_nested_field() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
{a:{b:3,c:5}} | reject a.b | debug
|
|
"#
|
|
)
|
|
);
|
|
|
|
assert_eq!(actual.out, "{a: {c: 5}}");
|
|
}
|
|
|
|
#[test]
|
|
fn reject_two_identical_elements() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[[a, a]; [1, 2]] | reject a"#
|
|
)
|
|
);
|
|
assert!(actual.out.contains("record 0 fields"));
|
|
}
|
|
|
|
#[test]
|
|
fn reject_large_vec_with_two_identical_elements() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[[a, b, c, d, e, a]; [1323, 23, 45, 100, 2, 2423]] | reject a"#
|
|
)
|
|
);
|
|
assert!(!actual.out.contains("1323"));
|
|
assert!(!actual.out.contains("2423"));
|
|
assert!(actual.out.contains('b'));
|
|
assert!(actual.out.contains('c'));
|
|
assert!(actual.out.contains('d'));
|
|
assert!(actual.out.contains('e'));
|
|
assert!(actual.out.contains("23"));
|
|
assert!(actual.out.contains("45"));
|
|
assert!(actual.out.contains("100"));
|
|
assert!(actual.out.contains('2'));
|
|
}
|